Merged in develop (pull request #17)

Added support for LX-200 EMC

AstroMath.UnitTests/AstroMath.UnitTests.csproj

@@ -39,7 +39,7 @@
     <OutputPath>bin\x86\Debug\</OutputPath>
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <DebugType>full</DebugType>
-    <PlatformTarget>x86</PlatformTarget>
+    <PlatformTarget>AnyCPU</PlatformTarget>
     <ErrorReport>prompt</ErrorReport>
     <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
@@ -68,8 +68,8 @@
     <Reference Include="System.Runtime.CompilerServices.Unsafe, Version=4.0.4.1, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
       <HintPath>..\packages\System.Runtime.CompilerServices.Unsafe.4.5.2\lib\netstandard2.0\System.Runtime.CompilerServices.Unsafe.dll</HintPath>
     </Reference>
-    <Reference Include="System.Threading.Tasks.Extensions, Version=4.2.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL">
-      <HintPath>..\packages\System.Threading.Tasks.Extensions.4.5.2\lib\netstandard2.0\System.Threading.Tasks.Extensions.dll</HintPath>
+    <Reference Include="System.Threading.Tasks.Extensions, Version=4.2.0.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL">
+      <HintPath>..\packages\System.Threading.Tasks.Extensions.4.5.3\lib\netstandard2.0\System.Threading.Tasks.Extensions.dll</HintPath>
     </Reference>
     <Reference Include="System.Xml.Linq" />
     <Reference Include="System.Data.DataSetExtensions" />
@@ -89,6 +89,7 @@
     </ProjectReference>
   </ItemGroup>
   <ItemGroup>
+    <None Include="app.config" />
     <None Include="packages.config" />
   </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />

AstroMath.UnitTests/AstroMathsUnitTests.cs

@@ -113,11 +113,13 @@ namespace AstroMath.UnitTests
         {
             var latitude = 52.0;
 
-            EquatorialCoordinates equatorialCoordinates = new EquatorialCoordinates();
-            equatorialCoordinates.RightAscension = 5.862222222222222;//5 51' 44"
-            equatorialCoordinates.Declination = 23.21944444444444;//23 13' 10"
+            var equatorialCoordinates = new EquatorialCoordinates
+            {
+                RightAscension = 5.862222222222222, //5 51' 44"
+                Declination = 23.21944444444444 //23 13' 10"
+            };
 
-            var hourAngle = 5.682222;
+            const double hourAngle = 5.682222;
 
             var altAz = _astroMath.ConvertEqToHoz(hourAngle, latitude, equatorialCoordinates);
 
@@ -131,9 +133,11 @@ namespace AstroMath.UnitTests
             DateTime dateTime = new DateTime(2019, 05, 18, 22, 26, 15, DateTimeKind.Utc);
             var longitude = -1.7833333333333332;
             var latitude = 52.0;
-            EquatorialCoordinates equatorialCoordinates = new EquatorialCoordinates();
-            equatorialCoordinates.RightAscension = 4.15361111111111;
-            equatorialCoordinates.Declination = 30.0019444444444;
+            EquatorialCoordinates equatorialCoordinates = new EquatorialCoordinates
+            {
+                RightAscension = 4.15361111111111,
+                Declination = 30.0019444444444
+            };
 
             var hourAngle = _astroMath.RightAscensionToHourAngle(dateTime, longitude, equatorialCoordinates.RightAscension);
             var altaz = _astroMath.ConvertEqToHoz(hourAngle, latitude, equatorialCoordinates);

AstroMath.UnitTests/app.config

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="utf-8"?>
+<configuration>
+  <runtime>
+    <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
+      <dependentAssembly>
+        <assemblyIdentity name="System.Threading.Tasks.Extensions" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
+        <bindingRedirect oldVersion="0.0.0.0-4.2.0.1" newVersion="4.2.0.1" />
+      </dependentAssembly>
+    </assemblyBinding>
+  </runtime>
+</configuration>

AstroMath.UnitTests/packages.config

@@ -4,5 +4,5 @@
   <package id="Moq" version="4.12.0" targetFramework="net472" />
   <package id="NUnit" version="3.12.0" targetFramework="net472" />
   <package id="System.Runtime.CompilerServices.Unsafe" version="4.5.2" targetFramework="net472" />
-  <package id="System.Threading.Tasks.Extensions" version="4.5.2" targetFramework="net472" />
+  <package id="System.Threading.Tasks.Extensions" version="4.5.3" targetFramework="net472" />
 </packages>

FocuserTestConsole/FocuserTestConsole.csproj

@@ -36,6 +36,25 @@
     <WarningLevel>4</WarningLevel>
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|AnyCPU'">
+    <DebugSymbols>true</DebugSymbols>
+    <OutputPath>bin\Debug\</OutputPath>
+    <DefineConstants>DEBUG;TRACE</DefineConstants>
+    <DebugType>full</DebugType>
+    <PlatformTarget>AnyCPU</PlatformTarget>
+    <ErrorReport>prompt</ErrorReport>
+    <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
+    <Prefer32Bit>true</Prefer32Bit>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|AnyCPU'">
+    <OutputPath>bin\Release\</OutputPath>
+    <DefineConstants>TRACE</DefineConstants>
+    <Optimize>true</Optimize>
+    <DebugType>pdbonly</DebugType>
+    <PlatformTarget>AnyCPU</PlatformTarget>
+    <ErrorReport>prompt</ErrorReport>
+    <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
+  </PropertyGroup>
   <ItemGroup>
     <Reference Include="ASCOM.DeviceInterfaces, Version=6.0.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL" />
     <Reference Include="ASCOM.DriverAccess, Version=6.0.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL" />

Meade.net.Focuser.UnitTests/BootstrapAscomProfileStore.ps1

@@ -0,0 +1,36 @@
+<#
+This script initializes a bare minimum set of registry entries required for ASCOM.Utilities.Profile to work
+without throwing any exceptions. When building on a build server, or on a computer without the ASCOM Platform installed,
+it may be useful to execute this script as a build step prior to running any unit tests, or calling any code that relies on
+ASCOM.Utilities.Profile. The alternative is to install the ASCOM Platform on the build agent.
+
+NOTE: This script equires elevated permissions because it creates registry keys in the LocalMachine hive.
+#>
+
+$wow = Test-Path HKLM:\SOFTWARE\Wow6432Node
+if ($wow)
+    {
+    $root = "HKLM:\SOFTWARE\Wow6432Node"
+    }
+else
+    {
+    $root = "HKLM:\SOFTWARE"
+    }
+$ascomRoot = $root + "\ASCOM"
+
+if (Test-Path $ascomRoot) 
+    {
+    <# Don't upset an already-existing ASCOM registry #>
+    exit
+    }
+
+<# Create the ASCOM root key and set it's ACL to allow all users read/write access #>
+New-Item -Path $root -Name ASCOM –Force
+$ascomAcl = Get-Acl $ascomRoot
+$aclRule = New-Object System.Security.AccessControl.RegistryAccessRule ("Users","FullControl","Allow")
+$ascomAcl.SetAccessRule($aclRule)
+$ascomAcl | Set-Acl -Path $ascomRoot
+
+<# Now create the bare minimum keys required so that ASCOM.Utilities.Profile doesn't crash and burn #>
+New-ItemProperty -Path $ascomRoot -Name PlatformVersion -Value "6.1" -PropertyType String –Force
+New-ItemProperty -Path $ascomRoot -Name SerTraceFile -Value "C:\SerialTraceAuto.txt" -PropertyType String –Force

Meade.net.Focuser.UnitTests/FocuserUnitTests.cs

@@ -0,0 +1,475 @@
+using System;
+using System.Reflection;
+using ASCOM;
+using ASCOM.DeviceInterface;
+using ASCOM.Meade.net;
+using ASCOM.Meade.net.Wrapper;
+using ASCOM.Utilities.Interfaces;
+using Moq;
+using NUnit.Framework;
+
+namespace Meade.net.Focuser.UnitTests
+{
+    [TestFixture]
+    public class FocuserUnitTests
+    {
+        private Mock<IUtil> _utilMock;
+        private Mock<ISharedResourcesWrapper> _sharedResourcesWrapperMock;
+
+        private ProfileProperties _profileProperties;
+
+        private ASCOM.Meade.net.Focuser _focuser;
+
+        [SetUp]
+        public void Setup()
+        {
+            _profileProperties = new ProfileProperties
+            {
+                TraceLogger = false,
+                ComPort = "TestCom1",
+                GuideRateArcSecondsPerSecond = 1.23,
+                Precision = "Unchanged"
+            };
+
+            _utilMock = new Mock<IUtil>();
+
+            _sharedResourcesWrapperMock = new Mock<ISharedResourcesWrapper>();
+
+            _sharedResourcesWrapperMock.Setup(x => x.Lock(It.IsAny<Action>())).Callback<Action>(action => { action(); });
+
+            _sharedResourcesWrapperMock.Setup(x => x.ReadProfile()).Returns(() => _profileProperties);
+
+            _focuser = new ASCOM.Meade.net.Focuser(_utilMock.Object, _sharedResourcesWrapperMock.Object);
+        }
+
+        private void ConnectFocuser()
+        {
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => TelescopeList.Autostar497);
+            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => TelescopeList.Autostar497_31Ee);
+            _focuser.Connected = true;
+        }
+
+        [Test]
+        public void CheckThatClassCreatedProperly()
+        {
+            Assert.That(_focuser, Is.Not.Null);
+        }
+
+        [Test]
+        public void NotConnectedByDefault()
+        {
+            Assert.That(_focuser.Connected, Is.False);
+        }
+
+        [Test]
+        public void SetupDialog()
+        {
+            _sharedResourcesWrapperMock.Verify(x => x.ReadProfile(), Times.Once);
+
+            _focuser.SetupDialog();
+
+            _sharedResourcesWrapperMock.Verify(x => x.SetupDialog(), Times.Once);
+            _sharedResourcesWrapperMock.Verify(x => x.ReadProfile(), Times.Exactly(2));
+        }
+
+        [Test]
+        public void SupportedActions()
+        {
+            var supportedActions = _focuser.SupportedActions;
+
+            Assert.That(supportedActions, Is.Not.Null);
+            Assert.That(supportedActions.Count, Is.EqualTo(0));
+        }
+
+        [Test]
+        public void Action_WhenNotConnected_ThrowsNotConnectedException()
+        {
+            var actionName = "Action";
+
+            Assert.Throws<ActionNotImplementedException>(() =>
+            {
+                var actualResult = _focuser.Action(actionName, string.Empty);
+                Assert.Fail($"{actualResult} should not have a value");
+            });
+        }
+
+        [Test]
+        public void CommandBlind_WhenNotConnected_ThenThrowsNotConnectedException()
+        {
+            string expectedMessage = "test blind Message";
+            var exception = Assert.Throws<NotConnectedException>(() => { _focuser.CommandBlind(expectedMessage, true); });
+
+            Assert.That(exception.Message, Is.EqualTo("Not connected to focuser when trying to execute: CommandBlind"));
+        }
+
+        [Test]
+        public void CommandBlind_WhenConnected_ThenSendsExpectedMessage()
+        {
+            string expectedMessage = "test blind Message";
+
+            ConnectFocuser();
+
+            _focuser.CommandBlind(expectedMessage, true);
+
+            _sharedResourcesWrapperMock.Verify(x => x.SendBlind(expectedMessage), Times.Once);
+        }
+
+        [Test]
+        public void CommandBool_WhenNotConnected_ThenThrowsNotConnectedException()
+        {
+            string expectedMessage = "test blind Message";
+            var exception = Assert.Throws<NotConnectedException>(() => { _focuser.CommandBool(expectedMessage, true); });
+
+            Assert.That(exception.Message, Is.EqualTo("Not connected to focuser when trying to execute: CommandBool"));
+        }
+
+        [Test]
+        public void CommandBool_WhenConnected_ThenSendsExpectedMessage()
+        {
+            string expectedMessage = "test blind Message";
+
+            ConnectFocuser();
+
+            var exception = Assert.Throws<MethodNotImplementedException>(() => { _focuser.CommandBool(expectedMessage, true); });
+
+            Assert.That(exception.Message, Is.EqualTo("Method CommandBool is not implemented in this driver."));
+        }
+
+        [Test]
+        public void CommandString_WhenNotConnected_ThenThrowsNotConnectedException()
+        {
+            string expectedMessage = "test blind Message";
+            var exception = Assert.Throws<NotConnectedException>(() => { _focuser.CommandString(expectedMessage, true); });
+
+            Assert.That(exception.Message, Is.EqualTo("Not connected to focuser when trying to execute: CommandString"));
+        }
+
+        [Test]
+        public void CommandString_WhenConnected_ThenSendsExpectedMessage()
+        {
+            string expectedMessage = "expected result message";
+            string sendMessage = "test blind Message";
+
+            ConnectFocuser();
+
+            _sharedResourcesWrapperMock.Setup(x => x.SendString(sendMessage)).Returns(() => expectedMessage);
+
+            var actualMessage = _focuser.CommandString(sendMessage, true);
+
+            _sharedResourcesWrapperMock.Verify(x => x.SendString(sendMessage), Times.Once);
+            Assert.That(actualMessage, Is.EqualTo(expectedMessage));
+        }
+
+        [TestCase(true)]
+        [TestCase(false)]
+        public void Connected_Get_ReturnsExpectedValue(bool expectedConnected)
+        {
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => TelescopeList.Autostar497);
+            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => TelescopeList.Autostar497_31Ee);
+            _focuser.Connected = expectedConnected;
+
+            Assert.That(_focuser.Connected, Is.EqualTo(expectedConnected));
+        }
+
+        [Test]
+        public void Connected_Set_WhenConnecting_Then_ConnectsToSerialDevice()
+        {
+            var productName = "LX2001";
+            var firmware = string.Empty;
+
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(productName);
+            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(firmware);
+            _focuser.Connected = true;
+
+            _sharedResourcesWrapperMock.Verify(x => x.Connect("Serial", It.IsAny<string>()), Times.Once);
+        }
+
+
+        [Test]
+        public void Connected_Set_SettingTrueWhenTrue_ThenDoesNothing()
+        {
+            ConnectFocuser();
+            _sharedResourcesWrapperMock.Verify(x => x.Connect(It.IsAny<string>(), It.IsAny<string>()), Times.Once);
+
+            //act
+            _focuser.Connected = true;
+
+            //assert
+            _sharedResourcesWrapperMock.Verify(x => x.Connect(It.IsAny<string>(), It.IsAny<string>()), Times.Once);
+        }
+
+        [Test]
+        public void Connected_Set_SettingFalseWhenTrue_ThenDisconnects()
+        {
+            ConnectFocuser();
+            _sharedResourcesWrapperMock.Verify(x => x.Connect(It.IsAny<string>(), It.IsAny<string>()), Times.Once);
+
+            //act
+            _focuser.Connected = false;
+
+            //assert
+            _sharedResourcesWrapperMock.Verify(x => x.Disconnect(It.IsAny<string>(), It.IsAny<string>()), Times.Once());
+        }
+
+        //Commented out for now as the catch after connect is currently unreachable code.
+        //[Test]
+        //public void Connected_Set_WhenFailsToConnect_ThenDisconnects()
+        //{
+        //    _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => TelescopeList.Autostar497);
+        //    _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => TelescopeList.Autostar497_31Ee);
+
+        //    _sharedResourcesWrapperMock.Setup(x => x.SendString(It.IsAny<string>())).Throws(new Exception("TestFailed"));
+
+        //    //act
+        //    _focuser.Connected = true;
+
+        //    //assert
+        //    _sharedResourcesWrapperMock.Verify(x => x.Disconnect(It.IsAny<string>(), It.IsAny<string>()), Times.Once());
+        //}
+
+        [Test]
+        public void Description_Get()
+        {
+            var expectedDescription = "Meade Generic";
+
+            var description = _focuser.Description;
+
+            Assert.That(description, Is.EqualTo(expectedDescription));
+        }
+
+        [Test]
+        public void DriverVersion_Get()
+        {
+            Version version = Assembly.GetAssembly(typeof(ASCOM.Meade.net.Focuser)).GetName().Version;
+
+            string exptectedDriverInfo = $"{version.Major}.{version.Minor}.{version.Build}.{version.Revision}";
+
+            var driverVersion = _focuser.DriverVersion;
+
+            Assert.That(driverVersion, Is.EqualTo(exptectedDriverInfo));
+        }
+
+        [Test]
+        public void DriverInfo_Get()
+        {
+            string exptectedDriverInfo = $"{_focuser.Description} .net driver. Version: {_focuser.DriverVersion}";
+
+            var driverInfo = _focuser.DriverInfo;
+
+            Assert.That(driverInfo, Is.EqualTo(exptectedDriverInfo));
+        }
+
+        [Test]
+        public void InterfaceVersion_Get()
+        {
+            var interfaceVersion = _focuser.InterfaceVersion;
+            Assert.That(interfaceVersion, Is.EqualTo(3));
+
+            Assert.That(_focuser, Is.AssignableTo<IFocuserV3>());
+        }
+
+        [Test]
+        public void Name_Get()
+        {
+            string expectedName = "Meade Generic";
+
+            var name = _focuser.Name;
+
+            Assert.That(name, Is.EqualTo(expectedName));
+        }
+
+        [Test]
+        public void Absolute_Get_WhenNotConnected_ThenThrowsException()
+        {
+            var exception = Assert.Throws<NotConnectedException>(() =>
+            {
+                var result = _focuser.Absolute;
+                Assert.Fail($"{result} should not have a value");
+            });
+            Assert.That(exception.Message, Is.EqualTo("Not connected to focuser when trying to execute: Absolute Get"));
+        }
+
+        [Test]
+        public void Absolute_Get_WhenConnected_ThenReturnsFalse()
+        {
+            ConnectFocuser();
+            var result = _focuser.Absolute;
+
+            Assert.That(result, Is.False);
+        }
+
+        [Test]
+        public void Halt_WhenNotConnected_ThenThrowsException()
+        {
+            var exception = Assert.Throws<NotConnectedException>(() => { _focuser.Halt(); });
+            Assert.That(exception.Message, Is.EqualTo("Not connected to focuser when trying to execute: Halt"));
+        }
+
+        [Test]
+        public void Halt_WhenConnected_ThenSendsHaltCommand()
+        {
+            ConnectFocuser();
+
+            _focuser.Halt();
+
+            _sharedResourcesWrapperMock.Verify( x => x.SendBlind(":FQ#"), Times.AtLeastOnce);
+            _utilMock.Verify( x => x.WaitForMilliseconds(250), Times.AtLeastOnce);
+        }
+
+        [Test]
+        public void IsMoving_WhenCalled_ThenReturnsFalse()
+        {
+            ConnectFocuser();
+
+            var result = _focuser.IsMoving;
+
+            Assert.That(result, Is.False);
+        }
+
+        [TestCase(false)]
+        [TestCase(true)]
+        public void Link_Get_ReturnsSameValueAsConnected( bool connected)
+        {
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => TelescopeList.Autostar497);
+            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => TelescopeList.Autostar497_31Ee);
+            _focuser.Connected = connected;
+
+            Assert.That( _focuser.Link, Is.EqualTo(connected));
+        }
+
+        [TestCase(false)]
+        [TestCase(true)]
+        public void Link_Set_WhenSet_ThenSetsConnectedState(bool connected)
+        {
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => TelescopeList.Autostar497);
+            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => TelescopeList.Autostar497_31Ee);
+            _focuser.Link = connected;
+
+            Assert.That(_focuser.Link, Is.EqualTo(connected));
+        }
+
+        [Test]
+        public void MaxIncrement_WhenCalled_ThenReturnsExpectedValue()
+        {
+            var result = _focuser.MaxIncrement;
+
+            Assert.That(result, Is.EqualTo(7000));
+        }
+
+        [Test]
+        public void MaxStep_WhenCalled_ThenReturnsExpectedValue()
+        {
+            var result = _focuser.MaxStep;
+
+            Assert.That(result, Is.EqualTo(7000));
+        }
+
+        [Test]
+        public void Move_WhenNotConnected_ThenThrowsException()
+        {
+            var exception = Assert.Throws<NotConnectedException>(() => { _focuser.Move(0); });
+            Assert.That(exception.Message, Is.EqualTo("Not connected to focuser when trying to execute: Move"));
+        }
+
+        [TestCase(-7001)]
+        [TestCase(7001)]
+        public void Move_WhenLargerThanMaxIncrement_ThenThrowsException(int position)
+        {
+            ConnectFocuser();
+
+            var exception = Assert.Throws<InvalidValueException>(() => { _focuser.Move(position); });
+            Assert.That(exception.Message, Is.EqualTo($"position out of range -{_focuser.MaxIncrement} < {position} < {_focuser.MaxIncrement}"));
+        }
+
+        [Test]
+        public void Move_WhenIncrementIs0_ThenDoesNothing()
+        {
+            ConnectFocuser();
+
+            _focuser.Move(0);
+
+            _utilMock.Verify( x => x.WaitForMilliseconds(It.IsAny<int>()), Times.Never);
+        }
+
+        [TestCase(200)]
+        [TestCase(-200)]
+        public void Move_WhenIncrementIsNot0_ThenMovesFocuserAndStopsFocuser( int position)
+        {
+            ConnectFocuser();
+
+            _focuser.Move(position);
+
+            if (position < 0)
+            {
+                _sharedResourcesWrapperMock.Verify( x => x.SendBlind(":F-#"), Times.AtLeastOnce);
+                _sharedResourcesWrapperMock.Verify(x => x.SendBlind(":F+#"), Times.Never);
+            }
+            else
+            {
+                _sharedResourcesWrapperMock.Verify(x => x.SendBlind(":F-#"), Times.Never);
+                _sharedResourcesWrapperMock.Verify(x => x.SendBlind(":F+#"), Times.AtLeastOnce);
+            }
+
+            _sharedResourcesWrapperMock.Verify( x => x.Lock(It.IsAny<Action>()), Times.Once);
+
+            _utilMock.Verify(x => x.WaitForMilliseconds(250), Times.AtLeastOnce);
+
+            _utilMock.Verify(x => x.WaitForMilliseconds(100), Times.Once());
+            _utilMock.Verify(x => x.WaitForMilliseconds(1000), Times.Once());
+        }
+
+        [Test]
+        public void Position_WhenCalled_ThenThrowsException()
+        {
+            var exception = Assert.Throws<PropertyNotImplementedException>(() =>
+            {
+                var result = _focuser.Position;
+                Assert.Fail($"{result} should not have a value");
+            });
+            Assert.That(exception.Message, Is.EqualTo("Property read Position is not implemented in this driver."));
+        }
+
+        [Test]
+        public void StepSize_WhenCalled_ThenThrowsException()
+        {
+            var exception = Assert.Throws<PropertyNotImplementedException>(() =>
+            {
+                var result = _focuser.StepSize;
+                Assert.Fail($"{result} should not have a value");
+            });
+            Assert.That(exception.Message, Is.EqualTo("Property read StepSize is not implemented in this driver."));
+        }
+
+        [Test]
+        public void TempComp_WhenRead_ThenReturnsFalse()
+        {
+            var result = _focuser.TempComp;
+            Assert.That(result, Is.False);
+        }
+
+        [Test]
+        public void TempComp_WhenWrite_ThenThrowsException()
+        {
+            var exception = Assert.Throws<PropertyNotImplementedException>(() => { _focuser.TempComp = false; });
+            Assert.That(exception.Message, Is.EqualTo("Property read TempComp is not implemented in this driver."));
+        }
+
+        [Test]
+        public void TempCompAvailable_WhenRead_ThenReturnsFalse()
+        {
+            var result = _focuser.TempCompAvailable;
+            Assert.That(result, Is.False);
+        }
+
+        [Test]
+        public void Temperature_WhenCalled_ThenThrowsException()
+        {
+            var exception = Assert.Throws<PropertyNotImplementedException>(() =>
+            {
+                var result = _focuser.Temperature; 
+                Assert.Fail($"{result} should not have a value");
+            });
+            Assert.That(exception.Message, Is.EqualTo("Property read Temperature is not implemented in this driver."));
+        }
+    }
+}

Meade.net.Focuser.UnitTests/Meade.net.Focuser.UnitTests.csproj

@@ -0,0 +1,122 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <Import Project="..\packages\NUnit.3.12.0\build\NUnit.props" Condition="Exists('..\packages\NUnit.3.12.0\build\NUnit.props')" />
+  <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
+  <PropertyGroup>
+    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
+    <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
+    <ProjectGuid>{A3991FA7-23C3-405A-96F9-5AB03AC58F30}</ProjectGuid>
+    <OutputType>Library</OutputType>
+    <AppDesignerFolder>Properties</AppDesignerFolder>
+    <RootNamespace>Meade.net.Focuser.UnitTests</RootNamespace>
+    <AssemblyName>Meade.net.Focuser.UnitTests</AssemblyName>
+    <TargetFrameworkVersion>v4.7.2</TargetFrameworkVersion>
+    <FileAlignment>512</FileAlignment>
+    <Deterministic>true</Deterministic>
+    <NuGetPackageImportStamp>
+    </NuGetPackageImportStamp>
+  </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
+    <DebugSymbols>true</DebugSymbols>
+    <DebugType>full</DebugType>
+    <Optimize>false</Optimize>
+    <OutputPath>bin\Debug\</OutputPath>
+    <DefineConstants>DEBUG;TRACE</DefineConstants>
+    <ErrorReport>prompt</ErrorReport>
+    <WarningLevel>4</WarningLevel>
+    <PlatformTarget>AnyCPU</PlatformTarget>
+  </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
+    <DebugType>pdbonly</DebugType>
+    <Optimize>true</Optimize>
+    <OutputPath>bin\Release\</OutputPath>
+    <DefineConstants>TRACE</DefineConstants>
+    <ErrorReport>prompt</ErrorReport>
+    <WarningLevel>4</WarningLevel>
+  </PropertyGroup>
+  <ItemGroup>
+    <Reference Include="ASCOM.Astrometry, Version=6.0.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL">
+      <HintPath>..\packages\ASCOM.Platform.6.4.2\lib\net40\ASCOM.Astrometry.dll</HintPath>
+    </Reference>
+    <Reference Include="ASCOM.Attributes, Version=6.0.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL">
+      <HintPath>..\packages\ASCOM.Platform.6.4.2\lib\net40\ASCOM.Attributes.dll</HintPath>
+    </Reference>
+    <Reference Include="ASCOM.Cache, Version=6.0.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL">
+      <HintPath>..\packages\ASCOM.Platform.6.4.2\lib\net40\ASCOM.Cache.dll</HintPath>
+    </Reference>
+    <Reference Include="ASCOM.Controls, Version=6.0.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL">
+      <HintPath>..\packages\ASCOM.Platform.6.4.2\lib\net40\ASCOM.Controls.dll</HintPath>
+    </Reference>
+    <Reference Include="ASCOM.DeviceInterfaces, Version=6.0.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL">
+      <HintPath>..\packages\ASCOM.Platform.6.4.2\lib\net40\ASCOM.DeviceInterfaces.dll</HintPath>
+    </Reference>
+    <Reference Include="ASCOM.DriverAccess, Version=6.0.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL">
+      <HintPath>..\packages\ASCOM.Platform.6.4.2\lib\net40\ASCOM.DriverAccess.dll</HintPath>
+    </Reference>
+    <Reference Include="ASCOM.Exceptions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL">
+      <HintPath>..\packages\ASCOM.Platform.6.4.2\lib\net40\ASCOM.Exceptions.dll</HintPath>
+    </Reference>
+    <Reference Include="ASCOM.Internal.Extensions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL">
+      <HintPath>..\packages\ASCOM.Platform.6.4.2\lib\net40\ASCOM.Internal.Extensions.dll</HintPath>
+    </Reference>
+    <Reference Include="ASCOM.SettingsProvider, Version=6.0.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL">
+      <HintPath>..\packages\ASCOM.Platform.6.4.2\lib\net40\ASCOM.SettingsProvider.dll</HintPath>
+    </Reference>
+    <Reference Include="ASCOM.Utilities, Version=6.0.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL">
+      <HintPath>..\packages\ASCOM.Platform.6.4.2\lib\net40\ASCOM.Utilities.dll</HintPath>
+    </Reference>
+    <Reference Include="ASCOM.Utilities.Video, Version=6.1.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL">
+      <HintPath>..\packages\ASCOM.Platform.6.4.2\lib\net40\ASCOM.Utilities.Video.dll</HintPath>
+    </Reference>
+    <Reference Include="Castle.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=407dd0808d44fbdc, processorArchitecture=MSIL">
+      <HintPath>..\packages\Castle.Core.4.4.0\lib\net45\Castle.Core.dll</HintPath>
+    </Reference>
+    <Reference Include="Moq, Version=4.12.0.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
+      <HintPath>..\packages\Moq.4.12.0\lib\net45\Moq.dll</HintPath>
+    </Reference>
+    <Reference Include="nunit.framework, Version=3.12.0.0, Culture=neutral, PublicKeyToken=2638cd05610744eb, processorArchitecture=MSIL">
+      <HintPath>..\packages\NUnit.3.12.0\lib\net45\nunit.framework.dll</HintPath>
+    </Reference>
+    <Reference Include="System" />
+    <Reference Include="System.Configuration" />
+    <Reference Include="System.Core" />
+    <Reference Include="System.Runtime.CompilerServices.Unsafe, Version=4.0.4.1, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
+      <HintPath>..\packages\System.Runtime.CompilerServices.Unsafe.4.5.2\lib\netstandard2.0\System.Runtime.CompilerServices.Unsafe.dll</HintPath>
+    </Reference>
+    <Reference Include="System.Threading.Tasks.Extensions, Version=4.2.0.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL">
+      <HintPath>..\packages\System.Threading.Tasks.Extensions.4.5.3\lib\netstandard2.0\System.Threading.Tasks.Extensions.dll</HintPath>
+    </Reference>
+    <Reference Include="System.Xml.Linq" />
+    <Reference Include="System.Data.DataSetExtensions" />
+    <Reference Include="Microsoft.CSharp" />
+    <Reference Include="System.Data" />
+    <Reference Include="System.Net.Http" />
+    <Reference Include="System.Xml" />
+  </ItemGroup>
+  <ItemGroup>
+    <Compile Include="FocuserUnitTests.cs" />
+    <Compile Include="Properties\AssemblyInfo.cs" />
+  </ItemGroup>
+  <ItemGroup>
+    <None Include="app.config" />
+    <None Include="BootstrapAscomProfileStore.ps1" />
+    <None Include="packages.config" />
+  </ItemGroup>
+  <ItemGroup>
+    <ProjectReference Include="..\Meade.net.focuser\Meade.net.focuser.csproj">
+      <Project>{a97e3aec-f11d-49da-b259-de99da813a86}</Project>
+      <Name>Meade.net.focuser</Name>
+    </ProjectReference>
+    <ProjectReference Include="..\Meade.net\Meade.net.csproj">
+      <Project>{3689a2cb-94c5-4012-a5cf-7e7d1dd27143}</Project>
+      <Name>Meade.net</Name>
+    </ProjectReference>
+  </ItemGroup>
+  <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
+  <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
+    <PropertyGroup>
+      <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
+    </PropertyGroup>
+    <Error Condition="!Exists('..\packages\NUnit.3.12.0\build\NUnit.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\NUnit.3.12.0\build\NUnit.props'))" />
+  </Target>
+</Project>

Meade.net.Focuser.UnitTests/Properties/AssemblyInfo.cs

@@ -0,0 +1,35 @@
+using System.Reflection;
+using System.Runtime.InteropServices;
+
+// General Information about an assembly is controlled through the following
+// set of attributes. Change these attribute values to modify the information
+// associated with an assembly.
+[assembly: AssemblyTitle("Meade.net.Focuser.UnitTests")]
+[assembly: AssemblyDescription("")]
+[assembly: AssemblyConfiguration("")]
+[assembly: AssemblyCompany("")]
+[assembly: AssemblyProduct("Meade.net.Focuser.UnitTests")]
+[assembly: AssemblyCopyright("Copyright ©  2019")]
+[assembly: AssemblyTrademark("")]
+[assembly: AssemblyCulture("")]
+
+// Setting ComVisible to false makes the types in this assembly not visible
+// to COM components.  If you need to access a type in this assembly from
+// COM, set the ComVisible attribute to true on that type.
+[assembly: ComVisible(false)]
+
+// The following GUID is for the ID of the typelib if this project is exposed to COM
+[assembly: Guid("a3991fa7-23c3-405a-96f9-5ab03ac58f30")]
+
+// Version information for an assembly consists of the following four values:
+//
+//      Major Version
+//      Minor Version
+//      Build Number
+//      Revision
+//
+// You can specify all the values or you can default the Build and Revision Numbers
+// by using the '*' as shown below:
+// [assembly: AssemblyVersion("1.0.*")]
+[assembly: AssemblyVersion("1.0.0.0")]
+[assembly: AssemblyFileVersion("1.0.0.0")]

Meade.net.Focuser.UnitTests/app.config

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="utf-8"?>
+<configuration>
+  <runtime>
+    <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
+      <dependentAssembly>
+        <assemblyIdentity name="System.Threading.Tasks.Extensions" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
+        <bindingRedirect oldVersion="0.0.0.0-4.2.0.1" newVersion="4.2.0.1" />
+      </dependentAssembly>
+    </assemblyBinding>
+  </runtime>
+</configuration>

Meade.net.Focuser.UnitTests/packages.config

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="ASCOM.Platform" version="6.4.2" targetFramework="net472" />
+  <package id="Castle.Core" version="4.4.0" targetFramework="net472" />
+  <package id="Moq" version="4.12.0" targetFramework="net472" />
+  <package id="NUnit" version="3.12.0" targetFramework="net472" />
+  <package id="System.Runtime.CompilerServices.Unsafe" version="4.5.2" targetFramework="net472" />
+  <package id="System.Threading.Tasks.Extensions" version="4.5.3" targetFramework="net472" />
+</packages>

Meade.net.Setup/AscomFocuserDriver.wxs

@@ -18,41 +18,6 @@
               Vital="yes"
               Assembly=".net"
               AssemblyApplication="filFocuserDriverAssembly" />
-        <!-- Registry entries suitable for a LocalServer served class -->
-        <!-- HKCR\CLSID\{driver-guid} -->
-        <RegistryKey Root="HKCR" Key="CLSID">
-          <RegistryKey Key="$(var.FocuserDriverClassId)">
-            <RegistryValue Value="$(var.FocuserDriverProgId)" Type="string"/>
-            <RegistryValue Name="AppId" Value="$(var.LocalServerAppId)" Type="string"/>
-            <RegistryKey Key="Implemented Categories">
-              <RegistryKey Key="{62C8FE65-4EBB-45e7-B440-6E39B2CDBF29}"
-                           ForceCreateOnInstall="yes"
-                           ForceDeleteOnUninstall="yes"/>
-            </RegistryKey>
-            <RegistryKey Key="ProgId">
-              <RegistryValue Value="$(var.FocuserDriverProgId)" Type="string"/>
-            </RegistryKey>
-            <RegistryKey Key="Programmable"
-                         ForceCreateOnInstall="yes"
-                         ForceDeleteOnUninstall="yes" />
-            <RegistryKey Key="LocalServer32">
-              <RegistryValue Value="[#filLocalServerAssembly]" Type="string"/>
-            </RegistryKey>
-          </RegistryKey>
-        </RegistryKey>
-
-        <!-- HKCR\{driver-prog-id} -->
-        <RegistryKey Root="HKCR" Key="$(var.FocuserDriverProgId)">
-          <RegistryValue Value="$(var.FocuserDriverDescription)" Type="string"/>
-          <RegistryKey Key="CLSID">
-            <RegistryValue Value="$(var.FocuserDriverClassId)" Type="string" />
-          </RegistryKey>
-        </RegistryKey>
-
-        <!--Register the driver with the ASCOM Profile-->
-        <RegistryKey Root="HKLM" Key="SOFTWARE\ASCOM\Focuser Drivers\$(var.FocuserDriverProgId)">
-          <RegistryValue Value="$(var.FocuserDriverDescription)" Type="string"/>
-        </RegistryKey>
       </Component>
     </ComponentGroup>
   </Fragment>

Meade.net.Setup/AscomLocalServer.wxs

@@ -12,21 +12,31 @@
               Assembly=".net"
               AssemblyApplication="filLocalServerAssembly" />
       </Component>
-      <Component Id="cmpLocalServerRegistry" Win64="no">
-        <!-- LocalServer32 COM Registration -->
-        <RegistryKey Root="HKCR" Key="AppID" >
-          <!-- HKCR\AppID\{my-app-id} -->
-          <RegistryKey Key="$(var.LocalServerAppId)">
-            <RegistryValue Value="$(var.InstallName)" Type="string"/>
-            <RegistryValue Name="AppID" Value="$(var.LocalServerAppId)" Type="string"/>
-            <RegistryValue Name="AuthenticationLevel" Value="1" Type="integer"/>
-          </RegistryKey>
-          <!-- HKCR\AppID\{exe-name} -->
-          <RegistryKey Key="$(var.Meade.net.TargetFileName)">
-            <RegistryValue Name="AppID" Value="$(var.LocalServerAppId)" Type="string"/>
-          </RegistryKey>
-        </RegistryKey>
-      </Component>
     </ComponentGroup>
+
+    <CustomAction Id="RegisterEXE"
+                  Directory="INSTALLFOLDER"
+                  ExeCommand="&quot;[#filLocalServerAssembly]&quot; /register"
+                  Execute="deferred"
+                  Return="ignore"
+                  Impersonate="no"
+    />
+
+    <CustomAction Id="UnRegisterEXE"
+                  Directory="INSTALLFOLDER"
+                  ExeCommand="&quot;[#filLocalServerAssembly]&quot; /unregister"
+                  Execute="deferred"
+                  Return="ignore"
+                  Impersonate="no"
+    />
+
+    <InstallExecuteSequence>
+      <Custom Action='RegisterEXE' Before="InstallFinalize">
+        <![CDATA[(NOT Installed)]]>
+      </Custom>
+      <Custom Action="UnRegisterEXE" After="InstallInitialize">
+        <![CDATA[(REMOVE ~= "ALL" AND NOT UPGRADINGPRODUCTCODE)]]>
+      </Custom>
+    </InstallExecuteSequence>
   </Fragment>
 </Wix>

Meade.net.Setup/AscomTelescopeDriver.wxs

@@ -18,41 +18,6 @@
               Vital="yes"
               Assembly=".net"
               AssemblyApplication="filTelescopeDriverAssembly" />
-        <!-- Registry entries suitable for a LocalServer served class -->
-        <!-- HKCR\CLSID\{driver-guid} -->
-        <RegistryKey Root="HKCR" Key="CLSID">
-          <RegistryKey Key="$(var.TelescopeDriverClassId)">
-            <RegistryValue Value="$(var.TelescopeDriverProgId)" Type="string"/>
-            <RegistryValue Name="AppId" Value="$(var.LocalServerAppId)" Type="string"/>
-            <RegistryKey Key="Implemented Categories">
-              <RegistryKey Key="{62C8FE65-4EBB-45e7-B440-6E39B2CDBF29}"
-                           ForceCreateOnInstall="yes"
-                           ForceDeleteOnUninstall="yes"/>
-            </RegistryKey>
-            <RegistryKey Key="ProgId">
-              <RegistryValue Value="$(var.TelescopeDriverProgId)" Type="string"/>
-            </RegistryKey>
-            <RegistryKey Key="Programmable"
-                         ForceCreateOnInstall="yes"
-                         ForceDeleteOnUninstall="yes" />
-            <RegistryKey Key="LocalServer32">
-              <RegistryValue Value="[#filLocalServerAssembly]" Type="string"/>
-            </RegistryKey>
-          </RegistryKey>
-        </RegistryKey>
-
-        <!-- HKCR\{driver-prog-id} -->
-        <RegistryKey Root="HKCR" Key="$(var.TelescopeDriverProgId)">
-          <RegistryValue Value="$(var.TelescopeDriverDescription)" Type="string"/>
-          <RegistryKey Key="CLSID">
-            <RegistryValue Value="$(var.TelescopeDriverClassId)" Type="string" />
-          </RegistryKey>
-        </RegistryKey>
-
-        <!--Register the driver with the ASCOM Profile-->
-        <RegistryKey Root="HKLM" Key="SOFTWARE\ASCOM\Telescope Drivers\$(var.TelescopeDriverProgId)">
-          <RegistryValue Value="$(var.TelescopeDriverDescription)" Type="string"/>
-        </RegistryKey>
       </Component>
     </ComponentGroup>
   </Fragment>

Meade.net.Setup/Config.wxi

@@ -11,7 +11,7 @@
     UpgradeCode must be unique to this product and should not be changed for the product lifetime.
   -->
 
-  <?define InstallName = "ASCOM Meade.net" ?>
+  <?define InstallName = "ASCOM Meade Generic" ?>
   <?define Manufacturer = "cjdawson.com" ?>
   <?define UpgradeCode = "{57597bb6-f207-4998-97f4-8a041950d062}" ?>
   <?define INSTALLFOLDER = "$(var.InstallName)" ?>

Meade.net.Setup/Meade.net.Setup.wixproj

@@ -48,6 +48,7 @@
   </ItemGroup>
   <ItemGroup>
     <Content Include="Config.wxi" />
+    <Content Include="License.rtf" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\Meade.net.focuser\Meade.net.focuser.csproj">

Meade.net.Setup/Product.wxs

@@ -30,12 +30,7 @@
       <![CDATA[Installed OR NETFRAMEWORK40FULL]]>
     </Condition>
 
-    <!--todo create a method to check if ASCOM is installed.-->
-    <!--<Condition Message="This application requires ASCOM Platform 6.4 or later.  Please install this and try again.">
-      <![CDATA[Installed or WIX_IS_NETFRAMEWORK_471_OR_LATER_INSTALLED]]>
-    </Condition>-->
-
-   <!-- <Condition Message="Please use the correct installer for your operating system - x86 for 32-bit, x64 for 64-bit.">
+    <!-- <Condition Message="Please use the correct installer for your operating system - x86 for 32-bit, x64 for 64-bit.">
       <?if $(var.Win64) = "yes" ?>
       VersionNT64
       <?else?>
@@ -46,6 +41,7 @@
     
     <UIRef Id="InstallationUI"/>
     <Property Id="WIXUI_INSTALLDIR" Value="INSTALLFOLDER" />
+    <WixVariable Id="WixUILicenseRtf" Value="License.rtf" />
 
     <FeatureGroupRef Id="fgRoot"/>
 	</Product>

Meade.net.Telescope.UnitTests/Meade.net.Telescope.UnitTests.csproj

@@ -26,7 +26,7 @@
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <Prefer32Bit>false</Prefer32Bit>
-    <PlatformTarget>x86</PlatformTarget>
+    <PlatformTarget>AnyCPU</PlatformTarget>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
@@ -104,8 +104,8 @@
     <Reference Include="System.Runtime.CompilerServices.Unsafe, Version=4.0.4.1, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
       <HintPath>..\packages\System.Runtime.CompilerServices.Unsafe.4.5.2\lib\netstandard1.0\System.Runtime.CompilerServices.Unsafe.dll</HintPath>
     </Reference>
-    <Reference Include="System.Threading.Tasks.Extensions, Version=4.2.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL">
-      <HintPath>..\packages\System.Threading.Tasks.Extensions.4.5.2\lib\portable-net45+win8+wp8+wpa81\System.Threading.Tasks.Extensions.dll</HintPath>
+    <Reference Include="System.Threading.Tasks.Extensions, Version=4.2.0.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL">
+      <HintPath>..\packages\System.Threading.Tasks.Extensions.4.5.3\lib\netstandard2.0\System.Threading.Tasks.Extensions.dll</HintPath>
     </Reference>
     <Reference Include="System.Xml.Linq" />
     <Reference Include="System.Data.DataSetExtensions" />

Meade.net.Telescope.UnitTests/TelescopeUnitTests.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Reflection;
 using ASCOM;
 using ASCOM.Astrometry.AstroUtils;
 using ASCOM.DeviceInterface;
@@ -23,13 +24,18 @@ namespace Meade.net.Telescope.UnitTests
         private Mock<IAstroMaths> _astroMathsMock;
 
         private ProfileProperties _profileProperties;
+        private ConnectionInfo _connectionInfo;
 
         [SetUp]
         public void Setup()
         {
-            _profileProperties = new ProfileProperties();
-            _profileProperties.TraceLogger = false;
-            _profileProperties.ComPort = "TestCom1";
+            _profileProperties = new ProfileProperties
+            {
+                TraceLogger = false,
+                ComPort = "TestCom1",
+                GuideRateArcSecondsPerSecond = 1.23,
+                Precision = "Unchanged"
+            };
 
             _utilMock = new Mock<IUtil>();
             _utilExtraMock = new Mock<IUtilExtra>();
@@ -37,13 +43,15 @@ namespace Meade.net.Telescope.UnitTests
 
             _sharedResourcesWrapperMock = new Mock<ISharedResourcesWrapper>();
             _sharedResourcesWrapperMock.Setup(x => x.SendString(":GZ#")).Returns("DDD*MM’SS");
-            _sharedResourcesWrapperMock.Setup(x => x.Autostar497).Returns(() => "AUTOSTAR");
-            _sharedResourcesWrapperMock.Setup(x => x.Autostar49731Ee).Returns(() => "31Ee");
-            _sharedResourcesWrapperMock.Setup(x => x.Autostar49743Eg) .Returns(() => "43Eg");
 
+            _sharedResourcesWrapperMock.Setup(x => x.ReadProfile()).Returns(() =>_profileProperties);
             _sharedResourcesWrapperMock.Setup(x => x.Lock(It.IsAny<Action>())).Callback<Action>(action => { action(); });
-            _sharedResourcesWrapperMock.Setup(x => x.Lock(It.IsAny<Func<ASCOM.Meade.net.Telescope.TelescopeDateDetails>>())).Returns<Func<ASCOM.Meade.net.Telescope.TelescopeDateDetails>>( (func) => func());
-            _sharedResourcesWrapperMock.Setup(x => x.Lock(It.IsAny<Func<AltitudeData>>())).Returns<Func<AltitudeData>>((func) => func());
+            _sharedResourcesWrapperMock.Setup(x => x.Lock(It.IsAny<Func<ASCOM.Meade.net.Telescope.TelescopeDateDetails>>())).Returns<Func<ASCOM.Meade.net.Telescope.TelescopeDateDetails>>( func => func());
+            _sharedResourcesWrapperMock.Setup(x => x.Lock(It.IsAny<Func<AltitudeData>>())).Returns<Func<AltitudeData>>(func => func());
+
+            _connectionInfo = new ConnectionInfo {Connections = 1, SameDevice = 1};
+
+            _sharedResourcesWrapperMock.Setup(x => x.Connect("Serial", It.IsAny<string>())).Returns( () => _connectionInfo );
 
 
             _sharedResourcesWrapperMock.Setup(x => x.ReadProfile()).Returns(_profileProperties);
@@ -56,8 +64,8 @@ namespace Meade.net.Telescope.UnitTests
 
         private void ConnectTelescope()
         {
-            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => _sharedResourcesWrapperMock.Object.Autostar497);
-            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => _sharedResourcesWrapperMock.Object.Autostar49731Ee);
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => TelescopeList.Autostar497);
+            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => TelescopeList.Autostar497_31Ee);
             _telescope.Connected = true;
         }
 
@@ -90,14 +98,18 @@ namespace Meade.net.Telescope.UnitTests
             var supportedActions = _telescope.SupportedActions;
 
             Assert.That(supportedActions, Is.Not.Null);
-            Assert.That(supportedActions.Count, Is.EqualTo(1));
+            Assert.That(supportedActions.Count, Is.EqualTo(2));
             Assert.That(supportedActions.Contains("handbox"), Is.True);
+            Assert.That(supportedActions.Contains("site"), Is.True);
         }
 
         [Test]
         public void Action_WhenNotConnected_ThrowsNotConnectedException()
         {
-            var exception = Assert.Throws<NotConnectedException>(() => { var actualResult = _telescope.Action(string.Empty, string.Empty); });
+            var exception = Assert.Throws<NotConnectedException>(() =>
+            {
+                _telescope.Action(string.Empty, string.Empty);
+            });
             Assert.That(exception.Message,Is.EqualTo("Not connected to telescope when trying to execute: Action"));
         }
 
@@ -135,7 +147,7 @@ namespace Meade.net.Telescope.UnitTests
         [TestCase("back", ":EK87#")]
         [TestCase("forward", ":EK69#")]
         [TestCase("?", ":EK63#")]
-        public void Action_Handbox_blindCommands(string action, string expectedString)
+        public void Action_Handbox_WhenCalling_ThenSendsAppropriateBlindCommands(string action, string expectedString)
         {
             ConnectTelescope();
 
@@ -144,6 +156,100 @@ namespace Meade.net.Telescope.UnitTests
             _sharedResourcesWrapperMock.Verify(x => x.SendBlind(expectedString), Times.Once);
         }
 
+        [TestCase("1")]
+        [TestCase("2")]
+        [TestCase("3")]
+        [TestCase("4")]
+        public void Action_Site_WhenCallingWithValidValues_ThenSelectsCorrectSite(string site)
+        {
+            ConnectTelescope();
+
+            string parameters = $"select {site}";
+            _telescope.Action("site", parameters);
+
+            _sharedResourcesWrapperMock.Verify(x => x.SendBlind($":W{site}#"), Times.Once);
+        }
+
+        [TestCase("0")]
+        [TestCase("5")]
+        public void Action_Site_WhenCallingWithInCorrectValues_ThenThrowsException(string site)
+        {
+            ConnectTelescope();
+
+            string parameters = $"select {site}";
+            var exception = Assert.Throws<InvalidValueException>(() => { _telescope.Action("site", parameters); });
+
+            Assert.That(exception.Message, Is.EqualTo($"Site {parameters} not allowed, must be between 1 and 4"));
+        }
+
+        [TestCase("1", ":GM#", "Home")]
+        [TestCase("2", ":GN#", "Club")]
+        [TestCase("3", ":GO#", "GPS")]
+        [TestCase("4", ":GP#", "Parents")]
+        public void Action_Site_GetName_WhenCallingWithValidValues_ThenSelectsCorrectSite(string site, string telescopeCommand, string siteName)
+        {
+            ConnectTelescope();
+
+            _sharedResourcesWrapperMock.Setup(x => x.SendString(telescopeCommand)).Returns(siteName);
+
+            string parameters = $"GetName {site}";
+            var result = _telescope.Action("site", parameters);
+
+            _sharedResourcesWrapperMock.Verify(x => x.SendString(telescopeCommand), Times.Once);
+            Assert.That(result, Is.EqualTo(siteName));
+        }
+
+        [TestCase("0")]
+        [TestCase("5")]
+        public void Action_Site_GetName_WhenCallingWithInCorrectValues_ThenThrowsException(string site)
+        {
+            ConnectTelescope();
+
+            string parameters = $"GetName {site}";
+            var exception = Assert.Throws<InvalidValueException>(() => { _telescope.Action("site", parameters); });
+
+            Assert.That(exception.Message, Is.EqualTo($"Site {parameters} not allowed, must be between 1 and 4"));
+        }
+
+        [TestCase("1", ":SMHome#", "Home")]
+        [TestCase("2", ":SNClub#", "Club")]
+        [TestCase("3", ":SOGPS Site#", "GPS Site")]
+        [TestCase("4", ":SPParents#", "Parents")]
+        public void Action_Site_SetName_WhenCallingWithValidValues_ThenSelectsCorrectSite(string site, string telescopeCommand, string siteName)
+        {
+            ConnectTelescope();
+
+            _sharedResourcesWrapperMock.Setup(x => x.SendChar(telescopeCommand)).Returns("1");
+
+            string parameters = $"SetName {site} {siteName}";
+            _telescope.Action("site", parameters);
+
+            _sharedResourcesWrapperMock.Verify(x => x.SendChar(telescopeCommand), Times.Once);
+        }
+
+        [TestCase("0")]
+        [TestCase("5")]
+        public void Action_Site_SetName_WhenCallingWithInCorrectValues_ThenThrowsException(string site)
+        {
+            ConnectTelescope();
+
+            string parameters = $"SetName {site}";
+            var exception = Assert.Throws<InvalidValueException>(() => { _telescope.Action("site", parameters); });
+
+            Assert.That(exception.Message, Is.EqualTo($"Site {parameters} not allowed, must be between 1 and 4"));
+        }
+
+        [Test]
+        public void Action_Site_WhenCallingUnknownParam_ThenThrowsException()
+        {
+            ConnectTelescope();
+
+            string parameters = "unknown";
+            var exception = Assert.Throws<InvalidValueException>(() => { _telescope.Action("site", parameters); });
+
+            Assert.That(exception.Message, Is.EqualTo($"Site parameters {parameters} not known"));
+        }
+
         [Test]
         public void Action_Handbox_nonExistantAction()
         {
@@ -238,11 +344,48 @@ namespace Meade.net.Telescope.UnitTests
         [TestCase(false)]
         public void Connected_Get_ReturnsExpectedValue(bool expectedConnected)
         {
-            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => _sharedResourcesWrapperMock.Object.Autostar497);
-            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => _sharedResourcesWrapperMock.Object.Autostar49731Ee);
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => TelescopeList.Autostar497);
+            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => TelescopeList.Autostar497_31Ee);
             _telescope.Connected = expectedConnected;
 
             Assert.That(_telescope.Connected, Is.EqualTo(expectedConnected));
+
+            if (expectedConnected)
+            {
+                _sharedResourcesWrapperMock.Verify(x => x.SendString(":GZ#"), Times.Once);
+                _sharedResourcesWrapperMock.Verify(x => x.SendBlind($":Rg{_profileProperties.GuideRateArcSecondsPerSecond:00.0}#"), Times.Never);
+            }
+        }
+        
+        [Test]
+        public void Connected_Set_WhenConnectingLX200GPS_Then_ConnectsToSerialDevice()
+        {
+            var productName = TelescopeList.LX200GPS;
+            var firmware = string.Empty;
+
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(productName);
+            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(firmware);
+            _telescope.Connected = true;
+
+            _sharedResourcesWrapperMock.Verify( x => x.Connect("Serial", It.IsAny<string>()), Times.Once);
+            _sharedResourcesWrapperMock.Verify(x => x.SendString(":GZ#"), Times.Once);
+
+            _sharedResourcesWrapperMock.Verify(x => x.SendBlind($":Rg{_profileProperties.GuideRateArcSecondsPerSecond:00.0}#"),Times.Once);
+        }
+
+        [Test]
+        public void Connected_Set_WhenConnectingToLX200EMC_Then_ConnectsToSerialDevice()
+        {
+            var productName = TelescopeList.LX200CLASSIC;
+            var firmware = string.Empty;
+
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(productName);
+            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(firmware);
+            _telescope.Connected = true;
+
+            _sharedResourcesWrapperMock.Verify(x => x.Connect("Serial", It.IsAny<string>()), Times.Once);
+            _sharedResourcesWrapperMock.Verify(x => x.SendString(":GZ#"), Times.Never);
+            _sharedResourcesWrapperMock.Verify(x => x.SendBlind($":Rg{_profileProperties.GuideRateArcSecondsPerSecond:00.0}#"), Times.Never);
         }
 
 
@@ -250,33 +393,33 @@ namespace Meade.net.Telescope.UnitTests
         public void Connected_Set_SettingTrueWhenTrue_ThenDoesNothing()
         {
             ConnectTelescope();
-            _sharedResourcesWrapperMock.Verify( x => x.Connect(It.IsAny<string>()),Times.Once);
+            _sharedResourcesWrapperMock.Verify( x => x.Connect(It.IsAny<string>(), It.IsAny<string>()),Times.Once);
 
             //act
             _telescope.Connected = true;
 
             //assert
-            _sharedResourcesWrapperMock.Verify(x => x.Connect(It.IsAny<string>()), Times.Once);
+            _sharedResourcesWrapperMock.Verify(x => x.Connect(It.IsAny<string>(), It.IsAny<string>()), Times.Once);
         }
 
         [Test]
         public void Connected_Set_SettingFalseWhenTrue_ThenDisconnects()
         {
             ConnectTelescope();
-            _sharedResourcesWrapperMock.Verify(x => x.Connect(It.IsAny<string>()), Times.Once);
+            _sharedResourcesWrapperMock.Verify(x => x.Connect(It.IsAny<string>(), It.IsAny<string>()), Times.Once);
 
             //act
             _telescope.Connected = false;
 
             //assert
-            _sharedResourcesWrapperMock.Verify(x => x.Disconnect(It.IsAny<string>()), Times.Once());
+            _sharedResourcesWrapperMock.Verify(x => x.Disconnect(It.IsAny<string>(), It.IsAny<string>()), Times.Once());
         }
 
         [Test]
         public void Connected_Set_WhenFailsToConnect_ThenDisconnects()
         {
-            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => _sharedResourcesWrapperMock.Object.Autostar497);
-            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => _sharedResourcesWrapperMock.Object.Autostar49731Ee);
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => TelescopeList.Autostar497);
+            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => TelescopeList.Autostar497_31Ee);
 
             _sharedResourcesWrapperMock.Setup(x => x.SendString(It.IsAny<string>())).Throws(new Exception("TestFailed"));
 
@@ -284,13 +427,15 @@ namespace Meade.net.Telescope.UnitTests
             _telescope.Connected = true;
 
             //assert
-            _sharedResourcesWrapperMock.Verify(x => x.Disconnect(It.IsAny<string>()), Times.Once());
+            _sharedResourcesWrapperMock.Verify(x => x.Disconnect(It.IsAny<string>(), It.IsAny<string>()), Times.Once());
         }
 
-        [TestCase("AUTOSTAR", "30Ab", false)]
-        [TestCase("AUTOSTAR","31Ee", true)]
-        [TestCase("AUTOSTAR", "43Eg", true)]
-        [TestCase("AUTOSTAR II", "", false)]
+        [TestCase("Autostar", "30Ab", false)]
+        [TestCase("Autostar", "31Ee", true)]
+        [TestCase("Autostar", "43Eg", true)]
+        [TestCase("Autostar II", "", false)]
+        [TestCase("LX2001", "", true)]
+        [TestCase(":GVP", "", false)] //LX200 Classic
         public void IsNewPulseGuidingSupported_ThenIsSupported_ThenReturnsTrue(string productName, string firmware, bool isSupported)
         {
             _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(productName);
@@ -337,9 +482,18 @@ namespace Meade.net.Telescope.UnitTests
             _sharedResourcesWrapperMock.Verify(x => x.SendBlind(":U#"), Times.Once);
         }
 
+        [Test]
+        public void SelectSite_Get_WhenNotConnected_ThrowsException()
+        {
+            var exception = Assert.Throws<NotConnectedException>(() => { _telescope.SelectSite(1); });
+            Assert.That(exception.Message, Is.EqualTo("Not connected to telescope when trying to execute: SelectSite"));
+        }
+
         [Test]
         public void SelectSite_WhenNewSiteToLow_ThenThrowsException()
         {
+            ConnectTelescope();
+
             var site = 0;
             var result = Assert.Throws<ArgumentOutOfRangeException>(() => { _telescope.SelectSite(site); });
 
@@ -349,6 +503,8 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void SelectSite_WhenNewSiteToHigh_ThenThrowsException()
         {
+            ConnectTelescope();
+
             var site = 5;
             var result = Assert.Throws<ArgumentOutOfRangeException>(() => { _telescope.SelectSite(site); });
 
@@ -361,6 +517,8 @@ namespace Meade.net.Telescope.UnitTests
         [TestCase(4)]
         public void SelectSite_WhenNewSiteToHigh_ThenThrowsException(int site)
         {
+            ConnectTelescope();
+
             _telescope.SelectSite(site);
 
             _sharedResourcesWrapperMock.Verify(x => x.SendBlind($":W{site}#"), Times.Once);
@@ -379,9 +537,9 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void DriverVersion_Get()
         {
-            Version version = System.Reflection.Assembly.GetAssembly(typeof(ASCOM.Meade.net.Telescope)).GetName().Version;
+            Version version = Assembly.GetAssembly(typeof(ASCOM.Meade.net.Telescope)).GetName().Version;
 
-            string exptectedDriverInfo = $"{version.Major}.{version.Minor}.{version.Revision}.{version.Build}";
+            string exptectedDriverInfo = $"{version.Major}.{version.Minor}.{version.Build}.{version.Revision}";
 
             var driverVersion = _telescope.DriverVersion;
 
@@ -391,8 +549,6 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void DriverInfo_Get()
         {
-            Version version = System.Reflection.Assembly.GetAssembly(typeof(ASCOM.Meade.net.Telescope)).GetName().Version;
-
             string exptectedDriverInfo = $"{_telescope.Description} .net driver. Version: {_telescope.DriverVersion}";
 
             var driverInfo = _telescope.DriverInfo;
@@ -422,7 +578,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void AlignmentMode_Get_WhenNotConnected_ThrowsException()
         {
-            var exception = Assert.Throws<NotConnectedException>(() => { var actualResult = _telescope.AlignmentMode; });
+            var exception = Assert.Throws<NotConnectedException>(() =>
+            {
+                var actualResult = _telescope.AlignmentMode;
+                Assert.Fail($"{actualResult} should not have returned");
+            });
             Assert.That(exception.Message, Is.EqualTo("Not connected to telescope when trying to execute: AlignmentMode Get"));
         }
 
@@ -447,7 +607,11 @@ namespace Meade.net.Telescope.UnitTests
         {
             ConnectTelescope();
 
-            Assert.Throws<InvalidValueException>(() => { var actualResult = _telescope.AlignmentMode; });
+            Assert.Throws<InvalidValueException>(() =>
+            {
+                var actualResult = _telescope.AlignmentMode;
+                Assert.Fail($"{actualResult} should not have returned");
+            });
         }
 
         [Test]
@@ -487,7 +651,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void ApertureArea_Get_ThrowsNotImplementedException()
         {
-            var excpetion = Assert.Throws<PropertyNotImplementedException>(() => { var result = _telescope.ApertureArea; });
+            var excpetion = Assert.Throws<PropertyNotImplementedException>(() =>
+            {
+                var result = _telescope.ApertureArea;
+                Assert.Fail($"{result} should not have returned");
+            });
 
             Assert.That(excpetion.Property, Is.EqualTo("ApertureArea"));
             Assert.That(excpetion.AccessorSet, Is.False);
@@ -496,7 +664,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void ApertureDiameter_Get_ThrowsNotImplementedException()
         {
-            var excpetion = Assert.Throws<PropertyNotImplementedException>(() => { var result = _telescope.ApertureDiameter; });
+            var excpetion = Assert.Throws<PropertyNotImplementedException>(() =>
+            {
+                var result = _telescope.ApertureDiameter;
+                Assert.Fail($"{result} should not have returned");
+            });
 
             Assert.That(excpetion.Property, Is.EqualTo("ApertureDiameter"));
             Assert.That(excpetion.AccessorSet, Is.False);
@@ -582,13 +754,90 @@ namespace Meade.net.Telescope.UnitTests
         }
 
         [Test]
-        public void CanSetGuideRates_Get_ReturnsFalse()
+        public void CanSetGuideRates_Get_WhenNotConnected_ThenThrowsException()
         {
+            var exception = Assert.Throws<NotConnectedException>(() =>
+            {
+                var result = _telescope.CanSetGuideRates;
+                Assert.Fail($"{result} should not have returned");
+            });
+            Assert.That(exception.Message, Is.EqualTo("Not connected to telescope when trying to execute: CanSetGuideRates Get"));
+        }
+        
+        [Test]
+        public void CanSetGuideRates_Get_WhenConnectedToAutostar_ThenReturnsFalse()
+        {
+            ConnectTelescope();
+
             var result = _telescope.CanSetGuideRates;
 
             Assert.That(result, Is.False);
         }
 
+        [Test]
+        public void CanSetGuideRates_Get_WhenConnectedToLX200GPS_ThenReturnsTrue()
+        {
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => TelescopeList.LX200GPS);
+            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => TelescopeList.LX200GPS_42G);
+            _telescope.Connected = true;
+
+            var result = _telescope.CanSetGuideRates;
+
+            Assert.That(result, Is.True);
+        }
+
+        [Test]
+        public void Precision_Set_WhenConnectedAndPrecisionSetUnChanged_ThenDoesNotSetPrecision()
+        {
+            _telescope.Connected = true;
+
+            _sharedResourcesWrapperMock.Verify( x => x.SendString(":P#"), Times.Never);
+        }
+
+        [TestCase("High", false, true)]
+        [TestCase("High", true, true)]
+        [TestCase("Low", false, false)]
+        [TestCase("Low", true, false)]
+        public void Precision_Set_WhenConnectedAndPrecisionSetHighScopeIsLow_ThenTelescopePrecisionChanged(string desiredPresision, bool telescopePrecision, bool finalPrecision)
+        {
+            _profileProperties.Precision = desiredPresision;
+            var currentPrecision = telescopePrecision;
+
+            _sharedResourcesWrapperMock.Setup(x => x.SendChar(":P#")).Returns(() =>
+            {
+                currentPrecision = !currentPrecision;
+
+                switch (currentPrecision)
+                {
+                    case true:
+                        return "H";
+                    default:
+                        return "L";
+                }
+            });
+
+            _telescope.Connected = true;
+
+            Assert.That(currentPrecision, Is.EqualTo(finalPrecision));
+            _sharedResourcesWrapperMock.Verify(x => x.SendChar(":P#"), Times.AtLeastOnce);
+        }
+
+        [TestCase("High", false, true)]
+        [TestCase("High", true, true)]
+        [TestCase("Low", false, false)]
+        [TestCase("Low", true, false)]
+        public void Precision_Set_WhenSecondConnectionMade_ThenTelescopePrecisionNotChanged(string desiredPresision, bool telescopePrecision, bool finalPrecision)
+        {
+            _profileProperties.Precision = desiredPresision;
+
+            _connectionInfo.SameDevice = 2;
+            _connectionInfo.Connections = 2;
+
+            _telescope.Connected = true;
+
+            _sharedResourcesWrapperMock.Verify(x => x.SendChar(":P#"), Times.Never);
+        }
+
         [Test]
         public void CanSetPark_Get_ReturnsFalse()
         {
@@ -680,7 +929,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void Declination_Get_WhenNotConnected_ThenThrowsException()
         {
-            var exception = Assert.Throws<NotConnectedException>(() => { var actualResult = _telescope.Declination; });
+            var exception = Assert.Throws<NotConnectedException>(() =>
+            {
+                var actualResult = _telescope.Declination;
+                Assert.Fail($"{actualResult} should not have returned");
+            });
             Assert.That(exception.Message, Is.EqualTo("Not connected to telescope when trying to execute: Declination Get"));
         }
 
@@ -718,7 +971,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void DestinationSideOfPier_ThenThrowsException()
         {
-            var excpetion = Assert.Throws<MethodNotImplementedException>(() => { var result = _telescope.DestinationSideOfPier(0,0); });
+            var excpetion = Assert.Throws<MethodNotImplementedException>(() =>
+            {
+                var result = _telescope.DestinationSideOfPier(0,0);
+                Assert.Fail($"{result} should not have returned");
+            });
 
             Assert.That(excpetion.Method, Is.EqualTo("DestinationSideOfPier"));
         }
@@ -726,7 +983,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void DoesRefraction_Get_ThenThrowsException()
         {
-            var excpetion = Assert.Throws<PropertyNotImplementedException>(() => { var result = _telescope.DoesRefraction; });
+            var excpetion = Assert.Throws<PropertyNotImplementedException>(() =>
+            {
+                var result = _telescope.DoesRefraction;
+                Assert.Fail($"{result} should not have returned");
+            });
 
             Assert.That(excpetion.Property, Is.EqualTo("DoesRefraction"));
             Assert.That(excpetion.AccessorSet, Is.False);
@@ -760,7 +1021,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void FocalLength_Get_ThenThrowsException()
         {
-            var excpetion = Assert.Throws<PropertyNotImplementedException>(() => { var result = _telescope.FocalLength; });
+            var excpetion = Assert.Throws<PropertyNotImplementedException>(() =>
+            {
+                var result = _telescope.FocalLength;
+                Assert.Fail($"{result} should not have returned");
+            });
 
             Assert.That(excpetion.Property, Is.EqualTo("FocalLength"));
             Assert.That(excpetion.AccessorSet, Is.False);
@@ -769,15 +1034,16 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void GuideRateDeclination_Get_ThenThrowsException()
         {
-            var excpetion = Assert.Throws<PropertyNotImplementedException>(() => { var result = _telescope.GuideRateDeclination; });
+            var result = _telescope.GuideRateDeclination;
 
-            Assert.That(excpetion.Property, Is.EqualTo("GuideRateDeclination"));
-            Assert.That(excpetion.AccessorSet, Is.False);
+            Assert.That(result, Is.EqualTo(0.00034166666666666666));
         }
 
         [Test]
-        public void GuideRateDeclination_Set_ThenThrowsException()
+        public void GuideRateDeclination_Set_WhenNotSupported_ThenThrowsException()
         {
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => TelescopeList.Autostar497);
+
             var excpetion = Assert.Throws<PropertyNotImplementedException>(() => { _telescope.GuideRateDeclination = 0; });
 
             Assert.That(excpetion.Property, Is.EqualTo("GuideRateDeclination"));
@@ -785,23 +1051,52 @@ namespace Meade.net.Telescope.UnitTests
         }
 
         [Test]
-        public void GuideRateRightAscension_Get_ThenThrowsException()
+        public void GuideRateDeclination_Set_WhenIsSupported_ThenSetsNewGuideRate()
         {
-            var excpetion = Assert.Throws<PropertyNotImplementedException>(() => { var result = _telescope.GuideRateRightAscension; });
+            var newGuideRate = 0.00034166666666666666;
 
-            Assert.That(excpetion.Property, Is.EqualTo("GuideRateRightAscension"));
-            Assert.That(excpetion.AccessorSet, Is.False);
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => TelescopeList.LX200GPS);
+
+            _telescope.GuideRateDeclination = newGuideRate;
+
+            _sharedResourcesWrapperMock.Verify(x => x.SendBlind(":Rg01.2#"), Times.Once);
+
+            Assert.That(_telescope.GuideRateDeclination, Is.EqualTo(newGuideRate));
         }
 
         [Test]
-        public void GuideRateRightAscension_Set_ThenThrowsException()
+        public void GuideRateRightAscension_Get_ThenThrowsException()
         {
+            var result = _telescope.GuideRateRightAscension;
+
+            Assert.That(result, Is.EqualTo(0.00034166666666666666));
+        }
+
+        [Test]
+        public void GuideRateRightAscension_Set_WhenNotSupported_ThenThrowsException()
+        {
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => TelescopeList.Autostar497);
+
             var excpetion = Assert.Throws<PropertyNotImplementedException>(() => { _telescope.GuideRateRightAscension = 0; });
 
             Assert.That(excpetion.Property, Is.EqualTo("GuideRateRightAscension"));
             Assert.That(excpetion.AccessorSet, Is.True);
         }
 
+        [Test]
+        public void GuideRateRightAscension_Set_WhenIsSupported_ThenSetsNewGuideRate()
+        {
+            var newGuideRate = 0.00034166666666666666;
+
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => TelescopeList.LX200GPS);
+
+            _telescope.GuideRateRightAscension = newGuideRate;
+
+            _sharedResourcesWrapperMock.Verify(x => x.SendBlind(":Rg01.2#"), Times.Once);
+
+            Assert.That(_telescope.GuideRateDeclination, Is.EqualTo(newGuideRate));
+        }
+
         [Test]
         public void IsPulseGuiding_Get_ReturnsFalse()
         {
@@ -911,7 +1206,7 @@ namespace Meade.net.Telescope.UnitTests
 
             var exception = Assert.Throws<InvalidValueException>(() => { _telescope.MoveAxis(TelescopeAxes.axisTertiary, testRate); });
 
-            Assert.That(exception.Message, Is.EqualTo($"Can not move this axis."));
+            Assert.That(exception.Message, Is.EqualTo("Can not move this axis."));
         }
 
         [Test]
@@ -969,7 +1264,7 @@ namespace Meade.net.Telescope.UnitTests
             var duration = 0;
             ConnectTelescope();
 
-            _telescope.PulseGuide(direction, 0);
+            _telescope.PulseGuide(direction, duration);
 
             string d = string.Empty;
             switch (direction)
@@ -999,11 +1294,47 @@ namespace Meade.net.Telescope.UnitTests
         public void PulseGuide_WhenConnectedAndNewerPulseGuidingNotAvailable_ThenSendsOldCommandsAndWaits(GuideDirections direction)
         {
             var duration = 0;
-            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => _sharedResourcesWrapperMock.Object.Autostar497);
-            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => "31Ed");
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => TelescopeList.Autostar497);
+            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => TelescopeList.Autostar497_30Ee);
             _telescope.Connected = true;
 
-            _telescope.PulseGuide(direction, 0);
+            _telescope.PulseGuide(direction, duration);
+
+            string d = string.Empty;
+            switch (direction)
+            {
+                case GuideDirections.guideEast:
+                    d = "e";
+                    break;
+                case GuideDirections.guideWest:
+                    d = "w";
+                    break;
+                case GuideDirections.guideNorth:
+                    d = "n";
+                    break;
+                case GuideDirections.guideSouth:
+                    d = "s";
+                    break;
+            }
+
+            _sharedResourcesWrapperMock.Verify(x => x.SendBlind(":RG#"));
+            _sharedResourcesWrapperMock.Verify(x => x.SendBlind($":M{d}#"));
+            _utilMock.Verify(x => x.WaitForMilliseconds(duration), Times.Once);
+            _sharedResourcesWrapperMock.Verify(x => x.SendBlind($":Q{d}#"));
+        }
+
+        [TestCase(GuideDirections.guideEast)]
+        [TestCase(GuideDirections.guideWest)]
+        [TestCase(GuideDirections.guideNorth)]
+        [TestCase(GuideDirections.guideSouth)]
+        public void PulseGuide_WhenConnectedAndNewerPulseGuidingAvailableButDurationTooLong_ThenSendsOldCommandsAndWaits(GuideDirections direction)
+        {
+            var duration = 10000;
+            _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => TelescopeList.Autostar497);
+            _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => TelescopeList.Autostar497_30Ee);
+            _telescope.Connected = true;
+
+            _telescope.PulseGuide(direction, duration);
 
             string d = string.Empty;
             switch (direction)
@@ -1031,7 +1362,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void RightAscension_Get_WhenNotConnected_ThenThrowsException()
         {
-            var exception = Assert.Throws<NotConnectedException>(() => { var result = _telescope.RightAscension; });
+            var exception = Assert.Throws<NotConnectedException>(() =>
+            {
+                var result = _telescope.RightAscension;
+                Assert.Fail($"{result} should not have returned");
+            });
             Assert.That(exception.Message, Is.EqualTo("Not connected to telescope when trying to execute: RightAscension Get"));
         }
 
@@ -1082,7 +1417,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void SideOfPier_Get_ThenThrowsException()
         {
-            var excpetion = Assert.Throws<PropertyNotImplementedException>(() => { var result = _telescope.SideOfPier; });
+            var excpetion = Assert.Throws<PropertyNotImplementedException>(() =>
+            {
+                var result = _telescope.SideOfPier;
+                Assert.Fail($"{result} should not have returned");
+            });
 
             Assert.That(excpetion.Property, Is.EqualTo("SideOfPier"));
             Assert.That(excpetion.AccessorSet, Is.False);
@@ -1100,7 +1439,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void SiteElevation_Get_ThenThrowsException()
         {
-            var excpetion = Assert.Throws<PropertyNotImplementedException>(() => { var result = _telescope.SiteElevation; });
+            var excpetion = Assert.Throws<PropertyNotImplementedException>(() =>
+            {
+                var result = _telescope.SiteElevation;
+                Assert.Fail($"{result} should not have returned");
+            });
 
             Assert.That(excpetion.Property, Is.EqualTo("SiteElevation"));
             Assert.That(excpetion.AccessorSet, Is.False);
@@ -1118,7 +1461,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void SlewSettleTime_Get_ThenThrowsException()
         {
-            var excpetion = Assert.Throws<PropertyNotImplementedException>(() => { var result = _telescope.SlewSettleTime; });
+            var excpetion = Assert.Throws<PropertyNotImplementedException>(() =>
+            {
+                var result = _telescope.SlewSettleTime;
+                Assert.Fail($"{result} should not have returned");
+            });
 
             Assert.That(excpetion.Property, Is.EqualTo("SlewSettleTime"));
             Assert.That(excpetion.AccessorSet, Is.False);
@@ -1144,7 +1491,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void SiteLatitude_Get_WhenNotConnected_ThenThrowsException()
         {
-            var exception = Assert.Throws<NotConnectedException>(() => { var result = _telescope.SiteLatitude; });
+            var exception = Assert.Throws<NotConnectedException>(() =>
+            {
+                var result = _telescope.SiteLatitude;
+                Assert.Fail($"{result} should not have returned");
+            });
             Assert.That(exception.Message, Is.EqualTo("Not connected to telescope when trying to execute: SiteLatitude Get"));
         }
 
@@ -1219,7 +1570,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void SiteLongitude_Get_WhenNotConnected_ThenThrowsException()
         {
-            var exception = Assert.Throws<NotConnectedException>(() => { var result = _telescope.SiteLongitude; });
+            var exception = Assert.Throws<NotConnectedException>(() =>
+            {
+                var result = _telescope.SiteLongitude;
+                Assert.Fail($"{result} should not have returned");
+            });
             Assert.That(exception.Message, Is.EqualTo("Not connected to telescope when trying to execute: SiteLongitude Get"));
         }
 
@@ -1294,8 +1649,6 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void SyncToAltAz_WhenConnected_ThenSendsExpectedMessage()
         {
-            string expectedMessage = "test blind Message";
-
             ConnectTelescope();
 
             var exception = Assert.Throws<MethodNotImplementedException>(() => { _telescope.SyncToAltAz(0,0); });
@@ -1392,7 +1745,11 @@ namespace Meade.net.Telescope.UnitTests
         {
             ConnectTelescope();
 
-            var exception = Assert.Throws<InvalidOperationException>(() => { var result = _telescope.TargetDeclination; });
+            var exception = Assert.Throws<InvalidOperationException>(() =>
+            {
+                var result = _telescope.TargetDeclination;
+                Assert.Fail($"{result} should not have returned");
+            });
             Assert.That(exception.Message, Is.EqualTo("Target not set"));
         }
 
@@ -1466,7 +1823,11 @@ namespace Meade.net.Telescope.UnitTests
         {
             ConnectTelescope();
 
-            var exception = Assert.Throws<InvalidOperationException>(() => { var result = _telescope.TargetRightAscension; });
+            var exception = Assert.Throws<InvalidOperationException>(() =>
+            {
+                var result = _telescope.TargetRightAscension;
+                Assert.Fail($"{result} should not have returned");
+            });
             Assert.That(exception.Message, Is.EqualTo("Target not set"));
         }
 
@@ -1563,7 +1924,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void UTCDate_Get_WhenNotConnected_ThenThrowsException()
         {
-            var exception = Assert.Throws<NotConnectedException>(() => { var result = _telescope.UTCDate; });
+            var exception = Assert.Throws<NotConnectedException>(() =>
+            {
+                var result = _telescope.UTCDate;
+                Assert.Fail($"{result} should not have returned");
+            });
             Assert.That(exception.Message, Is.EqualTo("Not connected to telescope when trying to execute: UTCDate Get"));
         }
 
@@ -1848,8 +2213,7 @@ namespace Meade.net.Telescope.UnitTests
                 slewCounter++;
                 if (slewCounter <= iterations)
                     return "|";
-                else
-                    return "";
+                return "";
             });
 
             _telescope.SlewToTarget();
@@ -1917,8 +2281,7 @@ namespace Meade.net.Telescope.UnitTests
                 slewCounter++;
                 if (slewCounter <= iterations)
                     return "|";
-                else
-                    return "";
+                return "";
             });
 
             _telescope.SlewToCoordinates(rightAscension, declination);
@@ -1988,7 +2351,7 @@ namespace Meade.net.Telescope.UnitTests
 
             _astroMathsMock
                 .Setup(x => x.ConvertHozToEq(It.IsAny<DateTime>(), It.IsAny<double>(), It.IsAny<double>(),
-                    It.IsAny<HorizonCoordinates>())).Returns(new EquatorialCoordinates(){ Declination = declination, RightAscension = rightAscension });
+                    It.IsAny<HorizonCoordinates>())).Returns(new EquatorialCoordinates { Declination = declination, RightAscension = rightAscension });
 
             _sharedResourcesWrapperMock.Setup(x => x.SendChar(":MS#")).Returns("0");
 
@@ -2022,7 +2385,7 @@ namespace Meade.net.Telescope.UnitTests
 
             _astroMathsMock
                 .Setup(x => x.ConvertHozToEq(It.IsAny<DateTime>(), It.IsAny<double>(), It.IsAny<double>(),
-                    It.IsAny<HorizonCoordinates>())).Returns(new EquatorialCoordinates() { Declination = declination, RightAscension = rightAscension });
+                    It.IsAny<HorizonCoordinates>())).Returns(new EquatorialCoordinates { Declination = declination, RightAscension = rightAscension });
 
             _sharedResourcesWrapperMock.Setup(x => x.SendChar(":MS#")).Returns("0");
 
@@ -2033,8 +2396,7 @@ namespace Meade.net.Telescope.UnitTests
                 slewCounter++;
                 if (slewCounter <= iterations)
                     return "|";
-                else
-                    return "";
+                return "";
             });
 
             _telescope.SlewToAltAz( azimuth, altitude);
@@ -2048,7 +2410,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void Azimuth_WhenNotConnected_ThenThrowsException()
         {
-            var exception = Assert.Throws<NotConnectedException>(() => { var result = _telescope.Azimuth; });
+            var exception = Assert.Throws<NotConnectedException>(() =>
+            {
+                var result = _telescope.Azimuth;
+                Assert.Fail($"{result} should not have returned");
+            });
             Assert.That(exception.Message, Is.EqualTo("Not connected to telescope when trying to execute: Azimuth Get"));
         }
 
@@ -2089,7 +2455,11 @@ namespace Meade.net.Telescope.UnitTests
         [Test]
         public void Altitude_WhenNotConnected_ThenThrowsException()
         {
-            var exception = Assert.Throws<NotConnectedException>(() => { var result = _telescope.Altitude; });
+            var exception = Assert.Throws<NotConnectedException>(() =>
+            {
+                var result = _telescope.Altitude;
+                Assert.Fail($"{result} should not have returned");
+            });
             Assert.That(exception.Message, Is.EqualTo("Not connected to telescope when trying to execute: Altitude Get"));
         }
 
@@ -2149,5 +2519,4 @@ namespace Meade.net.Telescope.UnitTests
             _sharedResourcesWrapperMock.Verify( x => x.SendString(":D#"), Times.Once);
         }
     }
-}
-;
+}

Meade.net.Telescope.UnitTests/app.config

@@ -1,11 +1,15 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <configuration>
   <runtime>
     <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
       <dependentAssembly>
-        <assemblyIdentity name="System.Runtime.CompilerServices.Unsafe" publicKeyToken="b03f5f7f11d50a3a" culture="neutral"/>
-        <bindingRedirect oldVersion="0.0.0.0-4.0.4.1" newVersion="4.0.4.1"/>
+        <assemblyIdentity name="System.Runtime.CompilerServices.Unsafe" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
+        <bindingRedirect oldVersion="0.0.0.0-4.0.4.1" newVersion="4.0.4.1" />
+      </dependentAssembly>
+      <dependentAssembly>
+        <assemblyIdentity name="System.Threading.Tasks.Extensions" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
+        <bindingRedirect oldVersion="0.0.0.0-4.2.0.1" newVersion="4.2.0.1" />
       </dependentAssembly>
     </assemblyBinding>
   </runtime>
-<startup><supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.7.2"/></startup></configuration>
+<startup><supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.7.2" /></startup></configuration>

Meade.net.Telescope.UnitTests/packages.config

@@ -5,5 +5,5 @@
   <package id="Moq" version="4.12.0" targetFramework="net45" />
   <package id="NUnit" version="3.12.0" targetFramework="net40" requireReinstallation="true" />
   <package id="System.Runtime.CompilerServices.Unsafe" version="4.5.2" targetFramework="net45" requireReinstallation="true" />
-  <package id="System.Threading.Tasks.Extensions" version="4.5.2" targetFramework="net45" requireReinstallation="true" />
+  <package id="System.Threading.Tasks.Extensions" version="4.5.3" targetFramework="net472" />
 </packages>

Meade.net.Telescope/AstroMaths/AstroMaths.cs

@@ -9,7 +9,7 @@ namespace ASCOM.Meade.net.AstroMaths
         //returns the decimal hour angle for given right ascension on a given datetime for a given logitude.
         public double RightAscensionToHourAngle(DateTime utcDateTime, double longitude, double rightAscension)
         {
-            var ut = DateTimeToDecimalHours( utcDateTime);
+            //var ut = DateTimeToDecimalHours( utcDateTime);
             var gst = UTtoGst( utcDateTime);
             var lst = GsTtoLst( gst, longitude);
             var raHours = rightAscension;
@@ -82,10 +82,11 @@ namespace ASCOM.Meade.net.AstroMaths
             var upperA = Math.Atan2(y, x);
             var upperB = RadiansToDegrees(upperA);
 
-            var horizonCoordinates = new HorizonCoordinates();
-            horizonCoordinates.Altitude = RadiansToDegrees(Math.Asin(sinA));
+            var horizonCoordinates = new HorizonCoordinates
+            {
+                Altitude = RadiansToDegrees(Math.Asin(sinA)), Azimuth = upperB
+            };
 
-            horizonCoordinates.Azimuth = upperB;
 
             if (upperB < 0)
             {
@@ -106,7 +107,7 @@ namespace ASCOM.Meade.net.AstroMaths
         public double RadiansToDegrees(double radians)
         {
             double degrees = (180 / Math.PI) * radians;
-            return (degrees);
+            return degrees;
         }
 
         //todo convert to extension method

Meade.net.Telescope/DoubleExtensions.cs

@@ -0,0 +1,14 @@
+namespace ASCOM.Meade.net
+{
+    public static class DoubleExtensions
+    {
+        public static bool InRange(this double value, double low, double high)
+        {
+            if (value < low)
+                return false;
+            if (value > high)
+                return false;
+            return true;
+        }
+    }
+}

Meade.net.Telescope/Meade.net.Telescope.csproj

@@ -46,7 +46,7 @@
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <RegisterForComInterop>true</RegisterForComInterop>
-    <PlatformTarget>x86</PlatformTarget>
+    <PlatformTarget>AnyCPU</PlatformTarget>
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
@@ -65,7 +65,7 @@
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">
     <OutputPath>..\bin\Debug\</OutputPath>
-    <PlatformTarget>x86</PlatformTarget>
+    <PlatformTarget>AnyCPU</PlatformTarget>
   </PropertyGroup>
   <ItemGroup>
     <Reference Include="ASCOM.Astrometry, Version=6.0.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL">
@@ -118,6 +118,7 @@
     <Compile Include="AstroMaths\EquatorialCoordinates.cs" />
     <Compile Include="AstroMaths\HorizonCoordinates.cs" />
     <Compile Include="AstroMaths\IAstroMaths.cs" />
+    <Compile Include="DoubleExtensions.cs" />
     <Compile Include="StringExtensions.cs" />
     <Compile Include="Telescope.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
@@ -151,7 +152,6 @@
       <LastGenOutput>Settings.Designer.cs</LastGenOutput>
     </None>
     <Content Include="ASCOM.ico" />
-    <Content Include="ReadMe.htm" />
     <None Include="Resources\ASCOM.bmp" />
   </ItemGroup>
   <ItemGroup>

Meade.net.Telescope/Properties/Resources.Designer.cs

@@ -8,10 +8,16 @@
 // </auto-generated>
 //------------------------------------------------------------------------------
 
+using System.CodeDom.Compiler;
+using System.ComponentModel;
+using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
+using System.Drawing;
+using System.Globalization;
+using System.Resources;
+using System.Runtime.CompilerServices;
+
 namespace ASCOM.Meade.net.Properties {
-    using System;
-    
-    
     /// <summary>
     ///   A strongly-typed resource class, for looking up localized strings, etc.
     /// </summary>
@@ -19,27 +25,27 @@ namespace ASCOM.Meade.net.Properties {
     // class via a tool like ResGen or Visual Studio.
     // To add or remove a member, edit your .ResX file then rerun ResGen
     // with the /str option, or rebuild your VS project.
-    [global::System.CodeDom.Compiler.GeneratedCodeAttribute("System.Resources.Tools.StronglyTypedResourceBuilder", "16.0.0.0")]
-    [global::System.Diagnostics.DebuggerNonUserCodeAttribute()]
-    [global::System.Runtime.CompilerServices.CompilerGeneratedAttribute()]
+    [GeneratedCode("System.Resources.Tools.StronglyTypedResourceBuilder", "16.0.0.0")]
+    [DebuggerNonUserCode()]
+    [CompilerGenerated()]
     internal class Resources {
         
-        private static global::System.Resources.ResourceManager resourceMan;
+        private static ResourceManager resourceMan;
         
-        private static global::System.Globalization.CultureInfo resourceCulture;
+        private static CultureInfo resourceCulture;
         
-        [global::System.Diagnostics.CodeAnalysis.SuppressMessageAttribute("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
+        [SuppressMessage("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
         internal Resources() {
         }
         
         /// <summary>
         ///   Returns the cached ResourceManager instance used by this class.
         /// </summary>
-        [global::System.ComponentModel.EditorBrowsableAttribute(global::System.ComponentModel.EditorBrowsableState.Advanced)]
-        internal static global::System.Resources.ResourceManager ResourceManager {
+        [EditorBrowsable(EditorBrowsableState.Advanced)]
+        internal static ResourceManager ResourceManager {
             get {
-                if (object.ReferenceEquals(resourceMan, null)) {
-                    global::System.Resources.ResourceManager temp = new global::System.Resources.ResourceManager("ASCOM.Meade.net.Properties.Resources", typeof(Resources).Assembly);
+                if (ReferenceEquals(resourceMan, null)) {
+                    ResourceManager temp = new ResourceManager("ASCOM.Meade.net.Properties.Resources", typeof(Resources).Assembly);
                     resourceMan = temp;
                 }
                 return resourceMan;
@@ -50,8 +56,8 @@ namespace ASCOM.Meade.net.Properties {
         ///   Overrides the current thread's CurrentUICulture property for all
         ///   resource lookups using this strongly typed resource class.
         /// </summary>
-        [global::System.ComponentModel.EditorBrowsableAttribute(global::System.ComponentModel.EditorBrowsableState.Advanced)]
-        internal static global::System.Globalization.CultureInfo Culture {
+        [EditorBrowsable(EditorBrowsableState.Advanced)]
+        internal static CultureInfo Culture {
             get {
                 return resourceCulture;
             }
@@ -63,20 +69,47 @@ namespace ASCOM.Meade.net.Properties {
         /// <summary>
         ///   Looks up a localized resource of type System.Drawing.Bitmap.
         /// </summary>
-        internal static System.Drawing.Bitmap ASCOM {
+        internal static Bitmap ASCOM {
             get {
                 object obj = ResourceManager.GetObject("ASCOM", resourceCulture);
-                return ((System.Drawing.Bitmap)(obj));
+                return ((Bitmap)(obj));
             }
         }
         
         /// <summary>
         ///   Looks up a localized resource of type System.Drawing.Icon similar to (Icon).
         /// </summary>
-        internal static System.Drawing.Icon DefaultIcon {
+        internal static Icon DefaultIcon {
             get {
                 object obj = ResourceManager.GetObject("DefaultIcon", resourceCulture);
-                return ((System.Drawing.Icon)(obj));
+                return ((Icon)(obj));
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Site out of range.
+        /// </summary>
+        internal static string Telescope_GetSiteName_Site_out_of_range {
+            get {
+                return ResourceManager.GetString("Telescope_GetSiteName_Site_out_of_range", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Site cannot be higher than 4.
+        /// </summary>
+        internal static string Telescope_SelectSite_Site_cannot_be_higher_than_4 {
+            get {
+                return ResourceManager.GetString("Telescope_SelectSite_Site_cannot_be_higher_than_4", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Site cannot be lower than 1.
+        /// </summary>
+        internal static string Telescope_SelectSite_Site_cannot_be_lower_than_1 {
+            get {
+                return ResourceManager.GetString("Telescope_SelectSite_Site_cannot_be_lower_than_1", resourceCulture);
             }
         }
     }

Meade.net.Telescope/Properties/Resources.resx

@@ -124,4 +124,13 @@
   <data name="DefaultIcon" type="System.Resources.ResXFileRef, System.Windows.Forms">
     <value>..\ASCOM.ico;System.Drawing.Icon, System.Drawing, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
   </data>
+  <data name="Telescope_SelectSite_Site_cannot_be_lower_than_1" xml:space="preserve">
+    <value>Site cannot be lower than 1</value>
+  </data>
+  <data name="Telescope_SelectSite_Site_cannot_be_higher_than_4" xml:space="preserve">
+    <value>Site cannot be higher than 4</value>
+  </data>
+  <data name="Telescope_GetSiteName_Site_out_of_range" xml:space="preserve">
+    <value>Site out of range</value>
+  </data>
 </root>

Meade.net.Telescope/Properties/Settings.Designer.cs

@@ -8,14 +8,18 @@
 // </auto-generated>
 //------------------------------------------------------------------------------
 
+using System.CodeDom.Compiler;
+using System.Configuration;
+using System.Runtime.CompilerServices;
+
 namespace ASCOM.Meade.net.Properties {
     
     
-    [global::System.Runtime.CompilerServices.CompilerGeneratedAttribute()]
-    [global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.VisualStudio.Editors.SettingsDesigner.SettingsSingleFileGenerator", "16.0.0.0")]
-    internal sealed partial class Settings : global::System.Configuration.ApplicationSettingsBase {
+    [CompilerGenerated()]
+    [GeneratedCode("Microsoft.VisualStudio.Editors.SettingsDesigner.SettingsSingleFileGenerator", "16.0.0.0")]
+    internal sealed partial class Settings : ApplicationSettingsBase {
         
-        private static Settings defaultInstance = ((Settings)(global::System.Configuration.ApplicationSettingsBase.Synchronized(new Settings())));
+        private static Settings defaultInstance = ((Settings)(Synchronized(new Settings())));
         
         public static Settings Default {
             get {

Meade.net.Telescope/Rates.cs

@@ -1,7 +1,7 @@
-using System.Runtime.InteropServices;
-using ASCOM.DeviceInterface;
-using System.Collections;
+using System.Collections;
+using System.Runtime.InteropServices;
 using System.Threading;
+using ASCOM.DeviceInterface;
 
 namespace ASCOM.Meade.net
 {
@@ -19,17 +19,14 @@ namespace ASCOM.Meade.net
     [ComVisible(true)]
     public class Rate : IRate
     {
-        private double _maximum = 0;
-        private double _minimum = 0;
-
         //
         // Default constructor - Internal prevents public creation
         // of instances. These are values for AxisRates.
         //
         internal Rate(double minimum, double maximum)
         {
-            _maximum = maximum;
-            _minimum = minimum;
+            Maximum = maximum;
+            Minimum = minimum;
         }
 
         #region Implementation of IRate
@@ -39,17 +36,9 @@ namespace ASCOM.Meade.net
             // TODO Add any required object cleanup here
         }
 
-        public double Maximum
-        {
-            get => _maximum;
-            set => _maximum = value;
-        }
+        public double Maximum { get; set; }
 
-        public double Minimum
-        {
-            get => _minimum;
-            set => _minimum = value;
-        }
+        public double Minimum { get; set; }
 
         #endregion
     }
@@ -96,12 +85,12 @@ namespace ASCOM.Meade.net
                     // TODO Initialize this array with any Primary axis rates that your driver may provide
                     // Example: m_Rates = new Rate[] { new Rate(10.5, 30.2), new Rate(54.0, 43.6) }
                     //this.rates = new Rate[0];
-                    _rates = new Rate[] { new Rate(1, 1), new Rate(2, 2), new Rate(3, 3), new Rate(4, 4) };
+                    _rates = new[] { new Rate(1, 1), new Rate(2, 2), new Rate(3, 3), new Rate(4, 4) };
                     break;
                 case TelescopeAxes.axisSecondary:
                     // TODO Initialize this array with any Secondary axis rates that your driver may provide
                     //this.rates = new Rate[0];
-                    _rates = new Rate[] { new Rate(1, 1), new Rate(2, 2), new Rate(3, 3), new Rate(4, 4) };
+                    _rates = new[] { new Rate(1, 1), new Rate(2, 2), new Rate(3, 3), new Rate(4, 4) };
                     break;
                 case TelescopeAxes.axisTertiary:
                     // TODO Initialize this array with any Tertiary axis rates that your driver may provide
@@ -152,7 +141,7 @@ namespace ASCOM.Meade.net
         private readonly DriveRates[] _trackingRates;
 
         // this is used to make the index thread safe
-        private readonly ThreadLocal<int> _pos = new ThreadLocal<int>(() => { return -1; });
+        private readonly ThreadLocal<int> _pos = new ThreadLocal<int>(() => -1);
         private static readonly object LockObj = new object();
 
         //
@@ -176,8 +165,12 @@ namespace ASCOM.Meade.net
 
         public IEnumerator GetEnumerator()
         {
-            _pos.Value = -1;
-            return this as IEnumerator;
+            lock (LockObj)
+            {
+                _pos.Value = -1;
+            }
+
+            return this;
         }
 
         public void Dispose()
@@ -220,7 +213,10 @@ namespace ASCOM.Meade.net
 
         public void Reset()
         {
-            _pos.Value = -1;
+            lock (LockObj)
+            {
+                _pos.Value = -1;
+            }
         }
         #endregion
     }

Meade.net.Telescope/ReadMe.htm

@@ -1,147 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
-<HTML>
-<HEAD>
-	<META HTTP-EQUIV="CONTENT-TYPE" CONTENT="text/html; charset=windows-1252">
-	<TITLE>Untitled Document</TITLE>
-	<META NAME="GENERATOR" CONTENT="OpenOffice.org 3.2  (Win32)">
-	<META NAME="CREATED" CONTENT="0;0">
-	<META NAME="CHANGEDBY" CONTENT="Chris Rowland">
-	<META NAME="CHANGED" CONTENT="20110918;14150500">
-	<STYLE TYPE="text/css">
-	<!--
-		@page { margin: 2cm }
-		P { font-family: "Verdana", "Arial", "Helvetica", sans-serif; font-weight: normal }
-		TD P { font-family: "Verdana", "Arial", "Helvetica", sans-serif; font-weight: normal }
-		H3 { font-family: "Arial", "Helvetica", sans-serif }
-		H2 { font-family: "Arial", "Helvetica", sans-serif }
-		H4 { font-family: "Arial", "Helvetica", sans-serif }
-		TD P.note { background: #33ffff; font-family: "Verdana", "Arial", "Helvetica", sans-serif; font-weight: normal }
-		TD P.underline { font-family: "Verdana", "Arial", "Helvetica", sans-serif; font-weight: normal; text-decoration: underline }
-	-->
-	</STYLE>
-</HEAD>
-<BODY LANG="en-GB" DIR="LTR">
-<TABLE WIDTH=100% BORDER=0 CELLPADDING=4 CELLSPACING=0>
-	<TR>
-		<TD>
-			<H2>ASCOM Telescope Driver (C#)</H2>
-		</TD>
-	</TR>
-</TABLE>
-<P><BR><BR>
-</P>
-<H4>You have just created the skeleton of an ASCOM
-Telescope driver in C#. It produces an in-process
-(assembly) based driver.</H4>
-<HR>
-<P CLASS="note">Prior to developing your first driver, please
-familiarize yourself with the <A HREF="http://ascom-standards.org/developer.html">developer
-information we've provided</A> at the ASCOM Initiative web site
-(internet required). 
-</P>
-<P CLASS="underline">You must do the following in order to complete
-your implementation:</P>
-<OL>
-	<LI><P STYLE="margin-bottom: 0cm">Switch to the Debug configuration
-	and build the template now. It should build without errors. 
-	</P>
-	<LI><P STYLE="margin-bottom: 0cm">Add a test project to the
-	solution. There are templates that can be used to add either a
-	console or a Windows Forms application:</P>
-</OL>
-<UL>
-	<LI><P STYLE="margin-bottom: 0cm">Select the <FONT FACE="Consolas, monospace">ASCOM
-	Test Forms App (CS)</FONT> or <FONT FACE="Consolas, monospace">ASCOM
-	Test Console App (CS)</FONT> template.</P>
-	<LI><P STYLE="margin-bottom: 0cm">Set a name for the test
-	application and click on OK.</P>
-	<LI><P STYLE="margin-bottom: 0cm">In the Wizard: set the same device
-	type and model name as for the driver and select Create to build the
-	test project.</P>
-	<LI><P STYLE="margin-bottom: 0cm">Set the Test Application to Run at
-	Startup.</P>
-	<LI><P STYLE="margin-bottom: 0cm">Click on Debug and the test
-	application should run.  You should be able to select your
-	application in the chooser. Selecting Properties should show the
-	default setup dialog for your driver.</P>
-	<LI><P STYLE="margin-bottom: 0cm">Trying to continue will generate
-	errors because the additional properties have not been implemented.</P>
-</UL>
-<OL START=4>
-	<LI><P STYLE="margin-bottom: 0cm">Go through the Driver.cs file and
-	replace the System.NotImplemented exceptions with code to implement
-	your driver's functionality. See the ASCOM ITelescopeV3
-	spec.  If a property or method is not implemented in your driver the
-	System.NotImplemented exception must be replaced by an
-	ASCOM.PropertyNotImplemented or ASCOM.MethodNotImplemented
-	exception.</P>
-	<LI><P>Customize the Setup Dialog (SetupDialogForm) to provide the
-	settings and other controls for your driver. You can bind settings
-	directly to controls on your dialog form, there's no need to manage
-	settings manually. A custom Settings class takes care of managing
-	your settings behind the scenes. 
-	</P>
-</OL>
-<H3>Notes:</H3>
-<UL>
-	<LI><P STYLE="margin-bottom: 0cm">Successfully building the driver,
-	as well as using <FONT FACE="Lucida Console, Courier New, Courier, monospace">regasm</FONT>
-	on the assembly, registers it for both COM and ASCOM (the Chooser).
-	See the code in the ASCOM Registration region of Driver.vb. 
-	</P>
-	<LI><P STYLE="margin-bottom: 0cm">Doing a Clean for the project, as
-	well doing a <FONT FACE="Lucida Console, Courier New, Courier, monospace">regasm
-	-u</FONT> on the assembly, unregisters it for both COM and ASCOM
-	(the Chooser). 
-	</P>
-	<LI><P>Place a breakpoint in your driver class constructor, then
-	start debugging (go, F5). Your breakpoint will be hit when the test
-	application creates an instance of your driver (after selecting it
-	in the Chooser). You can now single step, examine variables, etc.
-	Please review the test application and make changes and additions to
-	activate various parts of your driver during debugging.</P>
-	<LI><P>The project's Debug configuration is already configured (The
-	test application creates an instance of your driver (after selecting
-	it in the Chooser). You can now single step, examine variables, etc.
-	Please review the test application and feel free to make changes and
-	additions to activate various parts of your driver during debugging.
-		</P>
-</UL>
-<DIV ALIGN=RIGHT>
-	<TABLE WIDTH=100% BORDER=0 CELLPADDING=4 CELLSPACING=0>
-		<TR>
-			<TD>
-				<TABLE WIDTH=100% BORDER=0 CELLPADDING=4 CELLSPACING=0>
-					<TR>
-						<TD>
-							<H3>ASCOM Initiative</H3>
-						</TD>
-						<TD>
-							<IMG SRC="ASCOM.png" NAME="graphics1" ALIGN=RIGHT WIDTH=48 HEIGHT=56 BORDER=0></TD>
-					</TR>
-				</TABLE>
-				<P><BR><BR>
-				</P>
-			</TD>
-		</TR>
-		<TR>
-			<TD>
-				<P>The ASCOM Initiative consists of a group of astronomy software
-				developers and instrument vendors whose goals are to promote the
-				driver/client model and scripting automation. 
-				</P>
-				<P>See the <A HREF="http://ascom-standards.org/" TARGET="browser">ASCOM
-				web site</A> for more information. Please participate in the
-				<A HREF="http://tech.groups.yahoo.com/group/ASCOM-Talk" TARGET="browser">ASCOM-Talk
-				Yahoo Group</A>. 
-				</P>
-			</TD>
-		</TR>
-	</TABLE>
-</DIV>
-<P><BR><BR>
-</P><P>
-<BR><BR>
-</P>
-</BODY>
-</HTML>

Meade.net.Telescope/StringExtensions.cs

@@ -6,5 +6,28 @@ namespace ASCOM.Meade.net
         {
             return int.Parse(str);
         }
+
+        public static double ToDouble(this string str)
+        {
+            return double.Parse(str);
+        }
+
+        public static int Position(this string str, char find, int instance)
+        {
+            var currentInstance = 0;
+            for (var i = 0; i < str.Length; i++)
+            {
+                if (str[i] == find)
+                {
+                    currentInstance++;
+                    if (currentInstance == instance)
+                    {
+                        return i;
+                    }
+                }
+            }
+
+            return -1;
+        }
     }
 }

Meade.net.focuser/Focuser.cs

@@ -1,14 +1,13 @@
 #define Focuser
 
 using System;
-using System.Diagnostics;
-using System.Runtime.InteropServices;
-using ASCOM.Utilities;
-using ASCOM.DeviceInterface;
-using System.Globalization;
 using System.Collections;
+using System.Diagnostics;
 using System.Reflection;
+using System.Runtime.InteropServices;
+using ASCOM.DeviceInterface;
 using ASCOM.Meade.net.Wrapper;
+using ASCOM.Utilities;
 using ASCOM.Utilities.Interfaces;
 
 namespace ASCOM.Meade.net
@@ -29,7 +28,7 @@ namespace ASCOM.Meade.net
     /// </summary>
     [Guid("a32ac647-bf0f-42f9-8ab0-d166fa5884ad")]
     [ProgId("ASCOM.MeadeGeneric.focuser")]
-    [ServedClassName("Meade.net Focuser")]
+    [ServedClassName("Meade Generic")]
     [ClassInterface(ClassInterfaceType.None)]
     public class Focuser : ReferenceCountedObjectBase, IFocuserV3
     {
@@ -38,7 +37,7 @@ namespace ASCOM.Meade.net
         /// The DeviceID is used by ASCOM applications to load the driver at runtime.
         /// </summary>
         //internal static string driverID = "ASCOM.Meade.net.Focuser";
-        private static readonly string DriverId = Marshal.GenerateProgIdForType(MethodBase.GetCurrentMethod().DeclaringType);
+        private static readonly string DriverId = Marshal.GenerateProgIdForType(MethodBase.GetCurrentMethod().DeclaringType ?? throw new System.InvalidOperationException());
         // TODO Change the descriptive string for your driver then remove this line
         /// <summary>
         /// Driver description that displays in the ASCOM Chooser.
@@ -55,7 +54,7 @@ namespace ASCOM.Meade.net
         /// <summary>
         /// Variable to hold the trace logger object (creates a diagnostic log file with information that you specify)
         /// </summary>
-        internal static TraceLogger Tl;
+        private static TraceLogger _tl;
 
         private readonly ISharedResourcesWrapper _sharedResourcesWrapper;
 
@@ -66,22 +65,32 @@ namespace ASCOM.Meade.net
         public Focuser()
         {
             //todo move this out to IOC
-            _utilities = new Util(); //Initialise util object
+            var util = new Util(); //Initialise util object
+            _utilities = util;
             _sharedResourcesWrapper = new SharedResourcesWrapper();
 
             Initialise();
         }
 
+        public Focuser(IUtil util, ISharedResourcesWrapper sharedResourcesWrapper)
+        {
+            _utilities = util;
+            _sharedResourcesWrapper = sharedResourcesWrapper;
+
+            Initialise();
+        }
+
         private void Initialise()
         {
-            Tl = new TraceLogger("", "Meade.net.focusser");
+            //todo move the TraceLogger out to a factory class.
+            _tl = new TraceLogger("", "Meade.Generic.focusser");
 
-            Tl.LogMessage("Focuser", "Starting initialisation");
             ReadProfile(); // Read device configuration from the ASCOM Profile store
 
             IsConnected = false; // Initialise connected to false
 
-            Tl.LogMessage("Focuser", "Completed initialisation");
+            LogMessage("Focuser", "Completed initialisation");
+            LogMessage("Focuser", $"Driver version: {DriverVersion}");
         }
 
 
@@ -99,17 +108,17 @@ namespace ASCOM.Meade.net
         /// </summary>
         public void SetupDialog()
         {
-            Tl.LogMessage("SetupDialog", "Opening setup dialog");
+            _tl.LogMessage("SetupDialog", "Opening setup dialog");
             _sharedResourcesWrapper.SetupDialog();
             ReadProfile();
-            Tl.LogMessage("SetupDialog", "complete");
+            _tl.LogMessage("SetupDialog", "complete");
         }
 
         public ArrayList SupportedActions
         {
             get
             {
-                Tl.LogMessage("SupportedActions Get", "Returning empty arraylist");
+                _tl.LogMessage("SupportedActions Get", "Returning empty arraylist");
                 return new ArrayList();
             }
         }
@@ -117,7 +126,7 @@ namespace ASCOM.Meade.net
         public string Action(string actionName, string actionParameters)
         {
             LogMessage("", "Action {0}, parameters {1} not implemented", actionName, actionParameters);
-            throw new ActionNotImplementedException("Action " + actionName + " is not implemented by this driver");
+            throw new ActionNotImplementedException();
         }
 
         public void CommandBlind(string command, bool raw)
@@ -148,16 +157,15 @@ namespace ASCOM.Meade.net
             // then all communication calls this function
             // you need something to ensure that only one command is in progress at a time
             return _sharedResourcesWrapper.SendString(command);
-
-            throw new MethodNotImplementedException("CommandString");
+            //throw new ASCOM.MethodNotImplementedException("CommandString");
         }
 
         public void Dispose()
         {
             // Clean up the tracelogger and util objects
-            Tl.Enabled = false;
-            Tl.Dispose();
-            Tl = null;
+            _tl.Enabled = false;
+            _tl.Dispose();
+            _tl = null;
         }
 
         public bool Connected
@@ -169,7 +177,7 @@ namespace ASCOM.Meade.net
             }
             set
             {
-                Tl.LogMessage("Connected", "Set {0}", value);
+                _tl.LogMessage("Connected", "Set {0}", value);
                 if (value == IsConnected)
                     return;
 
@@ -177,17 +185,15 @@ namespace ASCOM.Meade.net
                 {
                     try
                     {
-                        _sharedResourcesWrapper.Connect("Serial");
+                        ReadProfile();
+                        _sharedResourcesWrapper.Connect("Serial", DriverId);
                         try
                         {
-                            SelectSite(1);
-                            SetLongFormat(true);
-
                             IsConnected = true;
                         }
                         catch (Exception)
                         {
-                            _sharedResourcesWrapper.Disconnect("Serial");
+                            _sharedResourcesWrapper.Disconnect("Serial", DriverId);
                             throw;
                         }
                     }
@@ -199,49 +205,18 @@ namespace ASCOM.Meade.net
                 else
                 {
                     LogMessage("Connected Set", "Disconnecting from port {0}", _comPort);
-                    _sharedResourcesWrapper.Disconnect("Serial");
+                    _sharedResourcesWrapper.Disconnect("Serial", DriverId);
                     IsConnected = false;
                 }
             }
         }
 
-        private void SetLongFormat(bool setLongFormat)
-        {
-            _sharedResourcesWrapper.Lock(() =>
-            {
-                var result = _sharedResourcesWrapper.SendString(":GZ#");
-                //:GZ# Get telescope azimuth
-                //Returns: DDD*MM#T or DDD*MM’SS#
-                //The current telescope Azimuth depending on the selected precision.
-
-                bool isLongFormat = result.Length > 6;
-
-                if (isLongFormat != setLongFormat)
-                {
-                    _utilities.WaitForMilliseconds(500);
-                    _sharedResourcesWrapper.SendBlind(":U#");
-                    //:U# Toggle between low/hi precision positions
-                    //Low - RA displays and messages HH:MM.T sDD*MM
-                    //High - Dec / Az / El displays and messages HH:MM: SS sDD*MM:SS
-                    //    Returns Nothing
-                }
-            });
-        }
-
-        private void SelectSite(int site)
-        {
-            _sharedResourcesWrapper.SendBlind($":W{site}#");
-            //:W<n>#
-            //Set current site to<n>, an ASCII digit in the range 1..4
-            //Returns: Nothing
-        }
-
         public string Description
         {
             // TODO customise this device description
             get
             {
-                Tl.LogMessage("Description Get", DriverDescription);
+                _tl.LogMessage("Description Get", DriverDescription);
                 return DriverDescription;
             }
         }
@@ -250,10 +225,9 @@ namespace ASCOM.Meade.net
         {
             get
             {
-                Version version = Assembly.GetExecutingAssembly().GetName().Version;
                 // TODO customise this driver description
-                string driverInfo = "Information about the driver itself. Version: " + String.Format(CultureInfo.InvariantCulture, "{0}.{1}", version.Major, version.Minor);
-                Tl.LogMessage("DriverInfo Get", driverInfo);
+                string driverInfo = $"{Description} .net driver. Version: {DriverVersion}";
+                LogMessage("DriverInfo Get", driverInfo);
                 return driverInfo;
             }
         }
@@ -263,8 +237,8 @@ namespace ASCOM.Meade.net
             get
             {
                 Version version = Assembly.GetExecutingAssembly().GetName().Version;
-                string driverVersion = String.Format(CultureInfo.InvariantCulture, "{0}.{1}", version.Major, version.Minor);
-                Tl.LogMessage("DriverVersion Get", driverVersion);
+                string driverVersion = $"{version.Major}.{version.Minor}.{version.Build}.{version.Revision}";
+                LogMessage("DriverVersion Get", driverVersion);
                 return driverVersion;
             }
         }
@@ -285,7 +259,7 @@ namespace ASCOM.Meade.net
             {
                 //string name = "Short driver name - please customise";
                 string name = DriverDescription;
-                Tl.LogMessage("Name Get", name);
+                _tl.LogMessage("Name Get", name);
                 return name;
             }
         }
@@ -298,18 +272,21 @@ namespace ASCOM.Meade.net
         {
             get
             {
-                Tl.LogMessage("Absolute Get", false.ToString());
+                CheckConnected("Absolute Get");
+
+                _tl.LogMessage("Absolute Get", false.ToString());
                 return false; // This is a relative focuser
             }
         }
 
         public void Halt()
         {
-            Tl.LogMessage("Halt", "Halting");
+            _tl.LogMessage("Halt", "Halting");
 
             CheckConnected("Halt");
 
             //A single halt command is sometimes missed by the #909 apm, so let's do it a few times to be safe.
+            //todo make this mockable
             Stopwatch stopwatch = Stopwatch.StartNew();
             while (stopwatch.ElapsedMilliseconds < 1000)
             {
@@ -325,7 +302,7 @@ namespace ASCOM.Meade.net
         {
             get
             {
-                Tl.LogMessage("IsMoving Get", false.ToString());
+                _tl.LogMessage("IsMoving Get", false.ToString());
                 return false; // This focuser always moves instantaneously so no need for IsMoving ever to be True
             }
         }
@@ -334,12 +311,12 @@ namespace ASCOM.Meade.net
         {
             get
             {
-                Tl.LogMessage("Link Get", Connected.ToString());
+                _tl.LogMessage("Link Get", Connected.ToString());
                 return Connected; // Direct function to the connected method, the Link method is just here for backwards compatibility
             }
             set
             {
-                Tl.LogMessage("Link Set", value.ToString());
+                _tl.LogMessage("Link Set", value.ToString());
                 Connected = value; // Direct function to the connected method, the Link method is just here for backwards compatibility
             }
         }
@@ -349,7 +326,7 @@ namespace ASCOM.Meade.net
         {
             get
             {
-                Tl.LogMessage("MaxIncrement Get", _maxIncrement.ToString());
+                _tl.LogMessage("MaxIncrement Get", _maxIncrement.ToString());
                 return _maxIncrement; // Maximum change in one move
             }
         }
@@ -359,14 +336,14 @@ namespace ASCOM.Meade.net
         {
             get
             {
-                Tl.LogMessage("MaxStep Get", _maxStep.ToString());
+                _tl.LogMessage("MaxStep Get", _maxStep.ToString());
                 return _maxStep;
             }
         }
 
         public void Move(int position)
         {
-            Tl.LogMessage("Move", position.ToString());
+            _tl.LogMessage("Move", position.ToString());
             CheckConnected("Move");
 
             //todo implement backlash compensation
@@ -381,16 +358,7 @@ namespace ASCOM.Meade.net
             if (position == 0)
                 return;
 
-            if (position > 0)
-            {
-                //desired move direction is out
-                MoveFocuser(true, Math.Abs(position));
-            }
-            else
-            {
-                //desired move direction is in
-                MoveFocuser(false, Math.Abs(position));
-            }
+            MoveFocuser(position > 0, Math.Abs(position));
         }
 
         private void MoveFocuser(bool directionOut, int steps)
@@ -410,6 +378,7 @@ namespace ASCOM.Meade.net
                 _utilities.WaitForMilliseconds(100);
 
                 //A Single focus command sometimes gets lost on the #909, so sending lots of them solves the issue.
+                //todo make this mockable
                 Stopwatch stopwatch = Stopwatch.StartNew();
                 while (stopwatch.ElapsedMilliseconds < steps)
                 {
@@ -436,7 +405,7 @@ namespace ASCOM.Meade.net
         {
             get
             {
-                Tl.LogMessage("StepSize Get", "Not implemented");
+                _tl.LogMessage("StepSize Get", "Not implemented");
                 throw new PropertyNotImplementedException("StepSize", false);
             }
         }
@@ -445,12 +414,13 @@ namespace ASCOM.Meade.net
         {
             get
             {
-                Tl.LogMessage("TempComp Get", false.ToString());
+                _tl.LogMessage("TempComp Get", false.ToString());
                 return false;
             }
+            // ReSharper disable once ValueParameterNotUsed
             set
             {
-                Tl.LogMessage("TempComp Set", "Not implemented");
+                _tl.LogMessage("TempComp Set", "Not implemented");
                 throw new PropertyNotImplementedException("TempComp", false);
             }
         }
@@ -459,7 +429,7 @@ namespace ASCOM.Meade.net
         {
             get
             {
-                Tl.LogMessage("TempCompAvailable Get", false.ToString());
+                _tl.LogMessage("TempCompAvailable Get", false.ToString());
                 return false; // Temperature compensation is not available in this driver
             }
         }
@@ -468,7 +438,7 @@ namespace ASCOM.Meade.net
         {
             get
             {
-                Tl.LogMessage("Temperature Get", "Not implemented");
+                _tl.LogMessage("Temperature Get", "Not implemented");
                 throw new PropertyNotImplementedException("Temperature", false);
             }
         }
@@ -566,18 +536,21 @@ namespace ASCOM.Meade.net
         {
             if (!IsConnected)
             {
-                throw new NotConnectedException(message);
+                throw new NotConnectedException($"Not connected to focuser when trying to execute: {message}");
             }
         }
 
         /// <summary>
         /// Read the device configuration from the ASCOM Profile store
         /// </summary>
-        internal void ReadProfile()
+        private void ReadProfile()
         {
             var profileProperties = _sharedResourcesWrapper.ReadProfile();
-            Tl.Enabled = profileProperties.TraceLogger;
+            _tl.Enabled = profileProperties.TraceLogger;
             _comPort = profileProperties.ComPort;
+
+            LogMessage("ReadProfile", $"Trace logger enabled: {_tl.Enabled}");
+            LogMessage("ReadProfile", $"Com Port: {_comPort}");
         }
 
         /// <summary>
@@ -586,10 +559,10 @@ namespace ASCOM.Meade.net
         /// <param name="identifier"></param>
         /// <param name="message"></param>
         /// <param name="args"></param>
-        internal static void LogMessage(string identifier, string message, params object[] args)
+        private static void LogMessage(string identifier, string message, params object[] args)
         {
             var msg = string.Format(message, args);
-            Tl.LogMessage(identifier, msg);
+            _tl.LogMessage(identifier, msg);
         }
         #endregion
     }

Meade.net.focuser/Meade.net.focuser.csproj

@@ -66,7 +66,7 @@
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <RegisterForComInterop>true</RegisterForComInterop>
     <DebugType>full</DebugType>
-    <PlatformTarget>x86</PlatformTarget>
+    <PlatformTarget>AnyCPU</PlatformTarget>
     <ErrorReport>prompt</ErrorReport>
     <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
@@ -156,7 +156,6 @@
       <LastGenOutput>Settings.Designer.cs</LastGenOutput>
     </None>
     <Content Include="ASCOM.ico" />
-    <Content Include="ReadMe.htm" />
     <None Include="Resources\ASCOM.bmp" />
   </ItemGroup>
   <ItemGroup>

Meade.net.focuser/Properties/Resources.Designer.cs

@@ -8,10 +8,16 @@
 // </auto-generated>
 //------------------------------------------------------------------------------
 
+using System.CodeDom.Compiler;
+using System.ComponentModel;
+using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
+using System.Drawing;
+using System.Globalization;
+using System.Resources;
+using System.Runtime.CompilerServices;
+
 namespace ASCOM.Meade.net.Properties {
-    using System;
-    
-    
     /// <summary>
     ///   A strongly-typed resource class, for looking up localized strings, etc.
     /// </summary>
@@ -19,27 +25,27 @@ namespace ASCOM.Meade.net.Properties {
     // class via a tool like ResGen or Visual Studio.
     // To add or remove a member, edit your .ResX file then rerun ResGen
     // with the /str option, or rebuild your VS project.
-    [global::System.CodeDom.Compiler.GeneratedCodeAttribute("System.Resources.Tools.StronglyTypedResourceBuilder", "16.0.0.0")]
-    [global::System.Diagnostics.DebuggerNonUserCodeAttribute()]
-    [global::System.Runtime.CompilerServices.CompilerGeneratedAttribute()]
+    [GeneratedCode("System.Resources.Tools.StronglyTypedResourceBuilder", "16.0.0.0")]
+    [DebuggerNonUserCode()]
+    [CompilerGenerated()]
     internal class Resources {
         
-        private static global::System.Resources.ResourceManager resourceMan;
+        private static ResourceManager resourceMan;
         
-        private static global::System.Globalization.CultureInfo resourceCulture;
+        private static CultureInfo resourceCulture;
         
-        [global::System.Diagnostics.CodeAnalysis.SuppressMessageAttribute("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
+        [SuppressMessage("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
         internal Resources() {
         }
         
         /// <summary>
         ///   Returns the cached ResourceManager instance used by this class.
         /// </summary>
-        [global::System.ComponentModel.EditorBrowsableAttribute(global::System.ComponentModel.EditorBrowsableState.Advanced)]
-        internal static global::System.Resources.ResourceManager ResourceManager {
+        [EditorBrowsable(EditorBrowsableState.Advanced)]
+        internal static ResourceManager ResourceManager {
             get {
-                if (object.ReferenceEquals(resourceMan, null)) {
-                    global::System.Resources.ResourceManager temp = new global::System.Resources.ResourceManager("ASCOM.Meade.net.Properties.Resources", typeof(Resources).Assembly);
+                if (ReferenceEquals(resourceMan, null)) {
+                    ResourceManager temp = new ResourceManager("ASCOM.Meade.net.Properties.Resources", typeof(Resources).Assembly);
                     resourceMan = temp;
                 }
                 return resourceMan;
@@ -50,8 +56,8 @@ namespace ASCOM.Meade.net.Properties {
         ///   Overrides the current thread's CurrentUICulture property for all
         ///   resource lookups using this strongly typed resource class.
         /// </summary>
-        [global::System.ComponentModel.EditorBrowsableAttribute(global::System.ComponentModel.EditorBrowsableState.Advanced)]
-        internal static global::System.Globalization.CultureInfo Culture {
+        [EditorBrowsable(EditorBrowsableState.Advanced)]
+        internal static CultureInfo Culture {
             get {
                 return resourceCulture;
             }
@@ -63,20 +69,20 @@ namespace ASCOM.Meade.net.Properties {
         /// <summary>
         ///   Looks up a localized resource of type System.Drawing.Bitmap.
         /// </summary>
-        internal static System.Drawing.Bitmap ASCOM {
+        internal static Bitmap ASCOM {
             get {
                 object obj = ResourceManager.GetObject("ASCOM", resourceCulture);
-                return ((System.Drawing.Bitmap)(obj));
+                return ((Bitmap)(obj));
             }
         }
         
         /// <summary>
         ///   Looks up a localized resource of type System.Drawing.Icon similar to (Icon).
         /// </summary>
-        internal static System.Drawing.Icon DefaultIcon {
+        internal static Icon DefaultIcon {
             get {
                 object obj = ResourceManager.GetObject("DefaultIcon", resourceCulture);
-                return ((System.Drawing.Icon)(obj));
+                return ((Icon)(obj));
             }
         }
     }

Meade.net.focuser/Properties/Settings.Designer.cs

@@ -8,14 +8,18 @@
 // </auto-generated>
 //------------------------------------------------------------------------------
 
+using System.CodeDom.Compiler;
+using System.Configuration;
+using System.Runtime.CompilerServices;
+
 namespace ASCOM.Meade.net.Properties {
     
     
-    [global::System.Runtime.CompilerServices.CompilerGeneratedAttribute()]
-    [global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.VisualStudio.Editors.SettingsDesigner.SettingsSingleFileGenerator", "16.0.0.0")]
-    internal sealed partial class Settings : global::System.Configuration.ApplicationSettingsBase {
+    [CompilerGenerated()]
+    [GeneratedCode("Microsoft.VisualStudio.Editors.SettingsDesigner.SettingsSingleFileGenerator", "16.0.0.0")]
+    internal sealed partial class Settings : ApplicationSettingsBase {
         
-        private static Settings defaultInstance = ((Settings)(global::System.Configuration.ApplicationSettingsBase.Synchronized(new Settings())));
+        private static Settings defaultInstance = ((Settings)(Synchronized(new Settings())));
         
         public static Settings Default {
             get {

Meade.net.focuser/ReadMe.htm

@@ -1,147 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
-<HTML>
-<HEAD>
-	<META HTTP-EQUIV="CONTENT-TYPE" CONTENT="text/html; charset=windows-1252">
-	<TITLE>Untitled Document</TITLE>
-	<META NAME="GENERATOR" CONTENT="OpenOffice.org 3.2  (Win32)">
-	<META NAME="CREATED" CONTENT="0;0">
-	<META NAME="CHANGEDBY" CONTENT="Chris Rowland">
-	<META NAME="CHANGED" CONTENT="20110918;14150500">
-	<STYLE TYPE="text/css">
-	<!--
-		@page { margin: 2cm }
-		P { font-family: "Verdana", "Arial", "Helvetica", sans-serif; font-weight: normal }
-		TD P { font-family: "Verdana", "Arial", "Helvetica", sans-serif; font-weight: normal }
-		H3 { font-family: "Arial", "Helvetica", sans-serif }
-		H2 { font-family: "Arial", "Helvetica", sans-serif }
-		H4 { font-family: "Arial", "Helvetica", sans-serif }
-		TD P.note { background: #33ffff; font-family: "Verdana", "Arial", "Helvetica", sans-serif; font-weight: normal }
-		TD P.underline { font-family: "Verdana", "Arial", "Helvetica", sans-serif; font-weight: normal; text-decoration: underline }
-	-->
-	</STYLE>
-</HEAD>
-<BODY LANG="en-GB" DIR="LTR">
-<TABLE WIDTH=100% BORDER=0 CELLPADDING=4 CELLSPACING=0>
-	<TR>
-		<TD>
-			<H2>ASCOM Focuser Driver (C#)</H2>
-		</TD>
-	</TR>
-</TABLE>
-<P><BR><BR>
-</P>
-<H4>You have just created the skeleton of an ASCOM
-Focuser driver in C#. It produces an in-process
-(assembly) based driver.</H4>
-<HR>
-<P CLASS="note">Prior to developing your first driver, please
-familiarize yourself with the <A HREF="http://ascom-standards.org/developer.html">developer
-information we've provided</A> at the ASCOM Initiative web site
-(internet required). 
-</P>
-<P CLASS="underline">You must do the following in order to complete
-your implementation:</P>
-<OL>
-	<LI><P STYLE="margin-bottom: 0cm">Switch to the Debug configuration
-	and build the template now. It should build without errors. 
-	</P>
-	<LI><P STYLE="margin-bottom: 0cm">Add a test project to the
-	solution. There are templates that can be used to add either a
-	console or a Windows Forms application:</P>
-</OL>
-<UL>
-	<LI><P STYLE="margin-bottom: 0cm">Select the <FONT FACE="Consolas, monospace">ASCOM
-	Test Forms App (CS)</FONT> or <FONT FACE="Consolas, monospace">ASCOM
-	Test Console App (CS)</FONT> template.</P>
-	<LI><P STYLE="margin-bottom: 0cm">Set a name for the test
-	application and click on OK.</P>
-	<LI><P STYLE="margin-bottom: 0cm">In the Wizard: set the same device
-	type and model name as for the driver and select Create to build the
-	test project.</P>
-	<LI><P STYLE="margin-bottom: 0cm">Set the Test Application to Run at
-	Startup.</P>
-	<LI><P STYLE="margin-bottom: 0cm">Click on Debug and the test
-	application should run.  You should be able to select your
-	application in the chooser. Selecting Properties should show the
-	default setup dialog for your driver.</P>
-	<LI><P STYLE="margin-bottom: 0cm">Trying to continue will generate
-	errors because the additional properties have not been implemented.</P>
-</UL>
-<OL START=4>
-	<LI><P STYLE="margin-bottom: 0cm">Go through the Driver.cs file and
-	replace the System.NotImplemented exceptions with code to implement
-	your driver's functionality. See the ASCOM IFocuserV3
-	spec.  If a property or method is not implemented in your driver the
-	System.NotImplemented exception must be replaced by an
-	ASCOM.PropertyNotImplemented or ASCOM.MethodNotImplemented
-	exception.</P>
-	<LI><P>Customize the Setup Dialog (SetupDialogForm) to provide the
-	settings and other controls for your driver. You can bind settings
-	directly to controls on your dialog form, there's no need to manage
-	settings manually. A custom Settings class takes care of managing
-	your settings behind the scenes. 
-	</P>
-</OL>
-<H3>Notes:</H3>
-<UL>
-	<LI><P STYLE="margin-bottom: 0cm">Successfully building the driver,
-	as well as using <FONT FACE="Lucida Console, Courier New, Courier, monospace">regasm</FONT>
-	on the assembly, registers it for both COM and ASCOM (the Chooser).
-	See the code in the ASCOM Registration region of Driver.vb. 
-	</P>
-	<LI><P STYLE="margin-bottom: 0cm">Doing a Clean for the project, as
-	well doing a <FONT FACE="Lucida Console, Courier New, Courier, monospace">regasm
-	-u</FONT> on the assembly, unregisters it for both COM and ASCOM
-	(the Chooser). 
-	</P>
-	<LI><P>Place a breakpoint in your driver class constructor, then
-	start debugging (go, F5). Your breakpoint will be hit when the test
-	application creates an instance of your driver (after selecting it
-	in the Chooser). You can now single step, examine variables, etc.
-	Please review the test application and make changes and additions to
-	activate various parts of your driver during debugging.</P>
-	<LI><P>The project's Debug configuration is already configured (The
-	test application creates an instance of your driver (after selecting
-	it in the Chooser). You can now single step, examine variables, etc.
-	Please review the test application and feel free to make changes and
-	additions to activate various parts of your driver during debugging.
-		</P>
-</UL>
-<DIV ALIGN=RIGHT>
-	<TABLE WIDTH=100% BORDER=0 CELLPADDING=4 CELLSPACING=0>
-		<TR>
-			<TD>
-				<TABLE WIDTH=100% BORDER=0 CELLPADDING=4 CELLSPACING=0>
-					<TR>
-						<TD>
-							<H3>ASCOM Initiative</H3>
-						</TD>
-						<TD>
-							<IMG SRC="ASCOM.png" NAME="graphics1" ALIGN=RIGHT WIDTH=48 HEIGHT=56 BORDER=0></TD>
-					</TR>
-				</TABLE>
-				<P><BR><BR>
-				</P>
-			</TD>
-		</TR>
-		<TR>
-			<TD>
-				<P>The ASCOM Initiative consists of a group of astronomy software
-				developers and instrument vendors whose goals are to promote the
-				driver/client model and scripting automation. 
-				</P>
-				<P>See the <A HREF="http://ascom-standards.org/" TARGET="browser">ASCOM
-				web site</A> for more information. Please participate in the
-				<A HREF="http://tech.groups.yahoo.com/group/ASCOM-Talk" TARGET="browser">ASCOM-Talk
-				Yahoo Group</A>. 
-				</P>
-			</TD>
-		</TR>
-	</TABLE>
-</DIV>
-<P><BR><BR>
-</P><P>
-<BR><BR>
-</P>
-</BODY>
-</HTML>

Meade.net.sln

@@ -23,6 +23,8 @@ Project("{930C7802-8A8C-48F9-8165-68863BCCD9DD}") = "Meade.net.Setup", "Meade.ne
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Meade.net.Telescope.UnitTests", "Meade.net.Telescope.UnitTests\Meade.net.Telescope.UnitTests.csproj", "{B7EEEEFD-5BFF-443D-981C-7B8AB5DFDE33}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Meade.net.Focuser.UnitTests", "Meade.net.Focuser.UnitTests\Meade.net.Focuser.UnitTests.csproj", "{A3991FA7-23C3-405A-96F9-5AB03AC58F30}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -69,21 +71,23 @@ Global
 		{A97E3AEC-F11D-49DA-B259-DE99DA813A86}.Release|x64.Build.0 = Release|Any CPU
 		{A97E3AEC-F11D-49DA-B259-DE99DA813A86}.Release|x86.ActiveCfg = Release|x86
 		{A97E3AEC-F11D-49DA-B259-DE99DA813A86}.Release|x86.Build.0 = Release|x86
-		{D5207217-61C7-4E94-8097-91DBACE57D2A}.Debug|Any CPU.ActiveCfg = Debug|x86
+		{D5207217-61C7-4E94-8097-91DBACE57D2A}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{D5207217-61C7-4E94-8097-91DBACE57D2A}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{D5207217-61C7-4E94-8097-91DBACE57D2A}.Debug|x64.ActiveCfg = Debug|x86
 		{D5207217-61C7-4E94-8097-91DBACE57D2A}.Debug|x64.Build.0 = Debug|x86
 		{D5207217-61C7-4E94-8097-91DBACE57D2A}.Debug|x86.ActiveCfg = Debug|x86
 		{D5207217-61C7-4E94-8097-91DBACE57D2A}.Debug|x86.Build.0 = Debug|x86
-		{D5207217-61C7-4E94-8097-91DBACE57D2A}.Release|Any CPU.ActiveCfg = Release|x86
+		{D5207217-61C7-4E94-8097-91DBACE57D2A}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{D5207217-61C7-4E94-8097-91DBACE57D2A}.Release|x64.ActiveCfg = Release|x86
 		{D5207217-61C7-4E94-8097-91DBACE57D2A}.Release|x86.ActiveCfg = Release|x86
 		{D5207217-61C7-4E94-8097-91DBACE57D2A}.Release|x86.Build.0 = Release|x86
-		{AABC96B8-C462-4B3A-9B5F-2929E3CB7A49}.Debug|Any CPU.ActiveCfg = Debug|x86
+		{AABC96B8-C462-4B3A-9B5F-2929E3CB7A49}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{AABC96B8-C462-4B3A-9B5F-2929E3CB7A49}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{AABC96B8-C462-4B3A-9B5F-2929E3CB7A49}.Debug|x64.ActiveCfg = Debug|x86
 		{AABC96B8-C462-4B3A-9B5F-2929E3CB7A49}.Debug|x64.Build.0 = Debug|x86
 		{AABC96B8-C462-4B3A-9B5F-2929E3CB7A49}.Debug|x86.ActiveCfg = Debug|x86
 		{AABC96B8-C462-4B3A-9B5F-2929E3CB7A49}.Debug|x86.Build.0 = Debug|x86
-		{AABC96B8-C462-4B3A-9B5F-2929E3CB7A49}.Release|Any CPU.ActiveCfg = Release|x86
+		{AABC96B8-C462-4B3A-9B5F-2929E3CB7A49}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{AABC96B8-C462-4B3A-9B5F-2929E3CB7A49}.Release|x64.ActiveCfg = Release|x86
 		{AABC96B8-C462-4B3A-9B5F-2929E3CB7A49}.Release|x86.ActiveCfg = Release|x86
 		{AABC96B8-C462-4B3A-9B5F-2929E3CB7A49}.Release|x86.Build.0 = Release|x86
@@ -99,12 +103,13 @@ Global
 		{AD4959DD-33D7-4C3F-8DB0-7361D8E74A95}.Release|x64.Build.0 = Release|Any CPU
 		{AD4959DD-33D7-4C3F-8DB0-7361D8E74A95}.Release|x86.ActiveCfg = Release|x86
 		{AD4959DD-33D7-4C3F-8DB0-7361D8E74A95}.Release|x86.Build.0 = Release|x86
-		{8EEB5C25-8394-4257-8E57-CDED47CB6F1B}.Debug|Any CPU.ActiveCfg = Debug|x64
-		{8EEB5C25-8394-4257-8E57-CDED47CB6F1B}.Debug|Any CPU.Build.0 = Debug|x64
+		{8EEB5C25-8394-4257-8E57-CDED47CB6F1B}.Debug|Any CPU.ActiveCfg = Debug|x86
+		{8EEB5C25-8394-4257-8E57-CDED47CB6F1B}.Debug|Any CPU.Build.0 = Debug|x86
 		{8EEB5C25-8394-4257-8E57-CDED47CB6F1B}.Debug|x64.ActiveCfg = Debug|x64
 		{8EEB5C25-8394-4257-8E57-CDED47CB6F1B}.Debug|x86.ActiveCfg = Debug|x86
 		{8EEB5C25-8394-4257-8E57-CDED47CB6F1B}.Debug|x86.Build.0 = Debug|x86
 		{8EEB5C25-8394-4257-8E57-CDED47CB6F1B}.Release|Any CPU.ActiveCfg = Release|x86
+		{8EEB5C25-8394-4257-8E57-CDED47CB6F1B}.Release|Any CPU.Build.0 = Release|x86
 		{8EEB5C25-8394-4257-8E57-CDED47CB6F1B}.Release|x64.ActiveCfg = Release|x86
 		{8EEB5C25-8394-4257-8E57-CDED47CB6F1B}.Release|x86.ActiveCfg = Release|x86
 		{8EEB5C25-8394-4257-8E57-CDED47CB6F1B}.Release|x86.Build.0 = Release|x86
@@ -120,6 +125,18 @@ Global
 		{B7EEEEFD-5BFF-443D-981C-7B8AB5DFDE33}.Release|x64.Build.0 = Release|Any CPU
 		{B7EEEEFD-5BFF-443D-981C-7B8AB5DFDE33}.Release|x86.ActiveCfg = Release|x86
 		{B7EEEEFD-5BFF-443D-981C-7B8AB5DFDE33}.Release|x86.Build.0 = Release|x86
+		{A3991FA7-23C3-405A-96F9-5AB03AC58F30}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{A3991FA7-23C3-405A-96F9-5AB03AC58F30}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{A3991FA7-23C3-405A-96F9-5AB03AC58F30}.Debug|x64.ActiveCfg = Debug|Any CPU
+		{A3991FA7-23C3-405A-96F9-5AB03AC58F30}.Debug|x64.Build.0 = Debug|Any CPU
+		{A3991FA7-23C3-405A-96F9-5AB03AC58F30}.Debug|x86.ActiveCfg = Debug|Any CPU
+		{A3991FA7-23C3-405A-96F9-5AB03AC58F30}.Debug|x86.Build.0 = Debug|Any CPU
+		{A3991FA7-23C3-405A-96F9-5AB03AC58F30}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{A3991FA7-23C3-405A-96F9-5AB03AC58F30}.Release|Any CPU.Build.0 = Release|Any CPU
+		{A3991FA7-23C3-405A-96F9-5AB03AC58F30}.Release|x64.ActiveCfg = Release|Any CPU
+		{A3991FA7-23C3-405A-96F9-5AB03AC58F30}.Release|x64.Build.0 = Release|Any CPU
+		{A3991FA7-23C3-405A-96F9-5AB03AC58F30}.Release|x86.ActiveCfg = Release|Any CPU
+		{A3991FA7-23C3-405A-96F9-5AB03AC58F30}.Release|x86.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
@@ -129,6 +146,7 @@ Global
 		{AABC96B8-C462-4B3A-9B5F-2929E3CB7A49} = {BF650D97-AF98-4638-9C55-21311C6D88DA}
 		{AD4959DD-33D7-4C3F-8DB0-7361D8E74A95} = {0958D817-269C-44BE-BEFB-F3E6A409DE91}
 		{B7EEEEFD-5BFF-443D-981C-7B8AB5DFDE33} = {0958D817-269C-44BE-BEFB-F3E6A409DE91}
+		{A3991FA7-23C3-405A-96F9-5AB03AC58F30} = {0958D817-269C-44BE-BEFB-F3E6A409DE91}
 	EndGlobalSection
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {3C0509DC-C7F5-48DC-920D-DCFD9C879BD2}

Meade.net/AssemblyInfo.cs

@@ -0,0 +1,91 @@
+using System;
+using System.Reflection;
+
+namespace ASCOM.Meade.net
+{
+    public class AssemblyInfo
+    {
+        // The assembly information values.
+        //public readonly string Title = string.Empty;
+        //public readonly string Description = string.Empty;
+        //public readonly string Company = string.Empty;
+        public readonly string Product = string.Empty;
+        //public readonly string Copyright = string.Empty;
+        //public readonly string Trademark = string.Empty;
+        public readonly string AssemblyVersion;
+        //public readonly string FileVersion = string.Empty;
+        //public readonly string Guid = string.Empty;
+        //public readonly string NeutralLanguage = string.Empty;
+        //public readonly bool IsComVisible;
+
+        // Return a particular assembly attribute value.
+        private T GetAssemblyAttribute<T>(Assembly assembly)
+            where T : Attribute
+        {
+            // Get attributes of this type.
+            object[] attributes = assembly.GetCustomAttributes(typeof(T), true);
+
+            // If we didn't get anything, return null.
+            if (attributes.Length == 0)
+                return null;
+
+            // Convert the first attribute value into
+            // the desired type and return it.
+            return (T)attributes[0];
+        }
+
+        // Constructors.
+        public AssemblyInfo()
+            : this(Assembly.GetExecutingAssembly())
+        {
+        }
+
+        private AssemblyInfo(Assembly assembly)
+        {
+            // Get values from the assembly.
+            //var titleAttr = GetAssemblyAttribute<AssemblyTitleAttribute>(assembly);
+            //if (titleAttr != null)
+            //    Title = titleAttr.Title;
+
+            //var assemblyAttr = GetAssemblyAttribute<AssemblyDescriptionAttribute>(assembly);
+            //if (assemblyAttr != null)
+            //    Description = assemblyAttr.Description;
+
+            //var companyAttr =GetAssemblyAttribute<AssemblyCompanyAttribute>(assembly);
+            //if (companyAttr != null)
+            //    Company = companyAttr.Company;
+
+            var productAttr = GetAssemblyAttribute<AssemblyProductAttribute>(assembly);
+            if (productAttr != null)
+                Product = productAttr.Product;
+
+            //var copyrightAttr = GetAssemblyAttribute<AssemblyCopyrightAttribute>(assembly);
+            //if (copyrightAttr != null)
+            //    Copyright = copyrightAttr.Copyright;
+
+            //var trademarkAttr = GetAssemblyAttribute<AssemblyTrademarkAttribute>(assembly);
+            //if (trademarkAttr != null)
+            //    Trademark = trademarkAttr.Trademark;
+
+            var version = assembly.GetName().Version;
+            AssemblyVersion = $"{version.Major}.{version.Minor}.{version.Build}.{version.Revision}";
+
+
+            //var fileVersionAttr = GetAssemblyAttribute<AssemblyFileVersionAttribute>(assembly);
+            //if (fileVersionAttr != null) FileVersion =
+            //    fileVersionAttr.Version;
+
+            //var guidAttr = GetAssemblyAttribute<GuidAttribute>(assembly);
+            //if (guidAttr != null)
+            //    Guid = guidAttr.Value;
+
+            //var languageAttr = GetAssemblyAttribute<NeutralResourcesLanguageAttribute>(assembly);
+            //if (languageAttr != null)
+            //    NeutralLanguage = languageAttr.CultureName;
+
+            //var comAttr = GetAssemblyAttribute<ComVisibleAttribute>(assembly);
+            //if (comAttr != null)
+            //    IsComVisible = comAttr.Value;
+        }
+    }
+}

Meade.net/ClassFactory.cs

@@ -1,6 +1,8 @@
 using System;
-using System.Runtime.InteropServices;
 using System.Collections;
+using System.Runtime.InteropServices;
+// ReSharper disable UnusedMember.Local
+// ReSharper disable UnusedMember.Global
 
 namespace ASCOM.Meade.net
 {
@@ -33,8 +35,8 @@ namespace ASCOM.Meade.net
         #region Access to ole32.dll functions for class factories
 
         // Define two common GUID objects for public usage.
-        private static readonly Guid _iidIUnknown = new Guid("{00000000-0000-0000-C000-000000000046}");
-        private static readonly Guid _iidIDispatch = new Guid("{00020400-0000-0000-C000-000000000046}");
+        private static readonly Guid IidIUnknown = new Guid("{00000000-0000-0000-C000-000000000046}");
+        private static readonly Guid IidIDispatch = new Guid("{00020400-0000-0000-C000-000000000046}");
 
         [Flags]
         enum Clsctx : uint
@@ -112,18 +114,17 @@ namespace ASCOM.Meade.net
         private readonly Type _mClassType;
         private Guid _mClassId;
         private readonly ArrayList _mInterfaceTypes;
-        private UInt32 _mLocked = 0;
         private uint _mCookie;
-        private readonly string _mProgid;
+        //private readonly string _mProgid;
 
         public ClassFactory(Type type)
         {
             if (type == null)
-                throw new ArgumentNullException("type");
+                throw new ArgumentNullException(nameof(type));
             _mClassType = type;
 
             //PWGS Get the ProgID from the MetaData
-            _mProgid = Marshal.GenerateProgIdForType(type);
+            //_mProgid = Marshal.GenerateProgIdForType(type);
             _mClassId = Marshal.GenerateGuidForType(type);		// Should be nailed down by [Guid(...)]
             ClassContext = (uint)Clsctx.ClsctxLocalServer;	// Default
             Flags = (uint)Regcls.RegclsMultipleuse |			// Default
@@ -136,7 +137,8 @@ namespace ASCOM.Meade.net
         #endregion
 
         #region Common ClassFactory Methods
-        public uint ClassContext { get; }
+
+        private uint ClassContext { get; }
 
         public Guid ClassId
         {
@@ -144,7 +146,7 @@ namespace ASCOM.Meade.net
             set => _mClassId = value;
         }
 
-        public uint Flags { get; }
+        private uint Flags { get; }
 
         public bool RegisterClassObject()
         {
@@ -157,25 +159,22 @@ namespace ASCOM.Meade.net
                 Flags,
                 out _mCookie
                 );
-            return (i == 0);
+            return i == 0;
         }
 
-        public bool RevokeClassObject()
+        public void RevokeClassObject()
         {
-            int i = CoRevokeClassObject(_mCookie);
-            return (i == 0);
+            CoRevokeClassObject(_mCookie);
         }
 
-        public static bool ResumeClassObjects()
+        public static void ResumeClassObjects()
         {
-            int i = CoResumeClassObjects();
-            return (i == 0);
+            CoResumeClassObjects();
         }
 
-        public static bool SuspendClassObjects()
+        public static void SuspendClassObjects()
         {
-            int i = CoSuspendClassObjects();
-            return (i == 0);
+            CoSuspendClassObjects();
         }
         #endregion
 
@@ -202,12 +201,11 @@ namespace ASCOM.Meade.net
             //
             // Handle requests for IDispatch or IUnknown on the class
             //
-            if (riid == _iidIDispatch)
+            if (riid == IidIDispatch)
             {
                 ppvObject = Marshal.GetIDispatchForObject(Activator.CreateInstance(_mClassType));
-                return;
             }
-            else if (riid == _iidIUnknown)
+            else if (riid == IidIUnknown)
             {
                 ppvObject = Marshal.GetIUnknownForObject(Activator.CreateInstance(_mClassType));
             }

Meade.net/ConnectionInfo.cs

@@ -0,0 +1,8 @@
+namespace ASCOM.Meade.net
+{
+    public class ConnectionInfo
+    {
+        public int Connections { get; set; }
+        public int SameDevice { get; set; }
+    }
+}

Meade.net/GarbageCollection.cs

@@ -9,14 +9,12 @@ namespace ASCOM.Meade.net
     class GarbageCollection
     {
         private bool _mbContinueThread;
-        private bool _mGcWatchStopped;
         private readonly int _miInterval;
         private readonly ManualResetEvent _mEventThreadEnded;
 
         public GarbageCollection(int iInterval)
         {
             _mbContinueThread = true;
-            _mGcWatchStopped = false;
             _miInterval = iInterval;
             _mEventThreadEnded = new ManualResetEvent(false);
         }
@@ -32,7 +30,7 @@ namespace ASCOM.Meade.net
             _mEventThreadEnded.Set();
         }
 
-        protected bool ContinueThread()
+        private bool ContinueThread()
         {
             lock (this)
             {

Meade.net/LocalServer.cs

@@ -12,82 +12,38 @@
 // Modified by Chris Rowland and Peter Simpson to allow use with multiple devices of the same type March 2011
 //
 //
+
 using System;
-using System.IO;
-using System.Windows.Forms;
 using System.Collections;
-using System.Runtime.InteropServices;
+using System.ComponentModel;
+using System.Diagnostics;
+using System.IO;
 using System.Reflection;
+using System.Runtime.InteropServices;
+using System.Security.Principal;
+using System.Threading;
+using System.Windows.Forms;
+using ASCOM.Meade.net.Properties;
 using ASCOM.Utilities;
 using Microsoft.Win32;
-using System.Threading;
-using System.Security.Principal;
-using System.Diagnostics;
 
 namespace ASCOM.Meade.net
 {
     public static class Server
     {
 
+        private const string DriverName = "Meade Generic";
+
         #region Access to kernel32.dll, user32.dll, and ole32.dll functions
-        [Flags]
-        enum Clsctx : uint
-        {
-            ClsctxInprocServer = 0x1,
-            ClsctxInprocHandler = 0x2,
-            ClsctxLocalServer = 0x4,
-            ClsctxInprocServer16 = 0x8,
-            ClsctxRemoteServer = 0x10,
-            ClsctxInprocHandler16 = 0x20,
-            ClsctxReserved1 = 0x40,
-            ClsctxReserved2 = 0x80,
-            ClsctxReserved3 = 0x100,
-            ClsctxReserved4 = 0x200,
-            ClsctxNoCodeDownload = 0x400,
-            ClsctxReserved5 = 0x800,
-            ClsctxNoCustomMarshal = 0x1000,
-            ClsctxEnableCodeDownload = 0x2000,
-            ClsctxNoFailureLog = 0x4000,
-            ClsctxDisableAaa = 0x8000,
-            ClsctxEnableAaa = 0x10000,
-            ClsctxFromDefaultContext = 0x20000,
-            ClsctxInproc = ClsctxInprocServer | ClsctxInprocHandler,
-            ClsctxServer = ClsctxInprocServer | ClsctxLocalServer | ClsctxRemoteServer,
-            ClsctxAll = ClsctxServer | ClsctxInprocHandler
-        }
 
-        [Flags]
-        enum Coinit : uint
-        {
-            /// Initializes the thread for multi-threaded object concurrency.
-            CoinitMultithreaded = 0x0,
-            /// Initializes the thread for apartment-threaded object concurrency. 
-            CoinitApartmentthreaded = 0x2,
-            /// Disables DDE for Ole1 support.
-            CoinitDisableOle1Dde = 0x4,
-            /// Trades memory for speed.
-            CoinitSpeedOverMemory = 0x8
-        }
+        //// CoInitializeEx() can be used to set the apartment model
+        //// of individual threads.
+        //[DllImport("ole32.dll")]
+        //static extern int CoInitializeEx(IntPtr pvReserved, uint dwCoInit);
 
-        [Flags]
-        enum Regcls : uint
-        {
-            RegclsSingleuse = 0,
-            RegclsMultipleuse = 1,
-            RegclsMultiSeparate = 2,
-            RegclsSuspended = 4,
-            RegclsSurrogate = 8
-        }
-
-
-        // CoInitializeEx() can be used to set the apartment model
-        // of individual threads.
-        [DllImport("ole32.dll")]
-        static extern int CoInitializeEx(IntPtr pvReserved, uint dwCoInit);
-
-        // CoUninitialize() is used to uninitialize a COM thread.
-        [DllImport("ole32.dll")]
-        static extern void CoUninitialize();
+        //// CoUninitialize() is used to uninitialize a COM thread.
+        //[DllImport("ole32.dll")]
+        //static extern void CoUninitialize();
 
         // PostThreadMessage() allows us to post a Windows Message to
         // a specific thread (identified by its thread id).
@@ -107,8 +63,8 @@ namespace ASCOM.Meade.net
         #region Private Data
         private static int _objsInUse;                       // Keeps a count on the total number of objects alive.
         private static int _serverLocks;                     // Keeps a lock count on this application.
-        private static FrmMain _sMainForm = null;               // Reference to our main form
-        private static ArrayList _sComObjectAssys;              // Dynamically loaded assemblies containing served COM objects
+        private static FrmMain _sMainForm;               // Reference to our main form
+        //private static ArrayList _sComObjectAssys;              // Dynamically loaded assemblies containing served COM objects
         private static ArrayList _sComObjectTypes;              // Served COM object types
         private static ArrayList _sClassFactories;              // Served COM object class factories
         private static string _sAppId = "{4e68ec46-5ffc-49e7-b298-38a548df0bfd}";	// Our AppId
@@ -116,15 +72,15 @@ namespace ASCOM.Meade.net
         #endregion
 
         // This property returns the main thread's id.
-        public static uint MainThreadId { get; private set; }   // Stores the main thread's thread id.
+        private static uint MainThreadId { get; set; }   // Stores the main thread's thread id.
 
         // Used to tell if started by COM or manually
-        public static bool StartedByCom { get; private set; }   // True if server started by COM (-embedding)
+        private static bool StartedByCom { get; set; }   // True if server started by COM (-embedding)
 
 
         #region Server Lock, Object Counting, and AutoQuit on COM startup
         // Returns the total number of objects alive currently.
-        public static int ObjectsCount
+        private static int ObjectsCount
         {
             get
             {
@@ -136,21 +92,21 @@ namespace ASCOM.Meade.net
         }
 
         // This method performs a thread-safe incrementation of the objects count.
-        public static int CountObject()
+        public static void CountObject()
         {
             // Increment the global count of objects.
-            return Interlocked.Increment(ref _objsInUse);
+            Interlocked.Increment(ref _objsInUse);
         }
 
         // This method performs a thread-safe decrementation the objects count.
-        public static int UncountObject()
+        public static void UncountObject()
         {
             // Decrement the global count of objects.
-            return Interlocked.Decrement(ref _objsInUse);
+            Interlocked.Decrement(ref _objsInUse);
         }
 
         // Returns the current server lock count.
-        public static int ServerLockCount
+        private static int ServerLockCount
         {
             get
             {
@@ -163,18 +119,18 @@ namespace ASCOM.Meade.net
 
         // This method performs a thread-safe incrementation the 
         // server lock count.
-        public static int CountLock()
+        public static void CountLock()
         {
             // Increment the global lock count of this server.
-            return Interlocked.Increment(ref _serverLocks);
+            Interlocked.Increment(ref _serverLocks);
         }
 
         // This method performs a thread-safe decrementation the 
         // server lock count.
-        public static int UncountLock()
+        public static void UncountLock()
         {
             // Decrement the global lock count of this server.
-            return Interlocked.Decrement(ref _serverLocks);
+            Interlocked.Decrement(ref _serverLocks);
         }
 
         // AttemptToTerminateServer() will check to see if the objects count and the server 
@@ -213,7 +169,7 @@ namespace ASCOM.Meade.net
         //
         private static bool LoadComObjectAssemblies()
         {
-            _sComObjectAssys = new ArrayList();
+            //_sComObjectAssys = new ArrayList();
             _sComObjectTypes = new ArrayList();
 
             // put everything into one folder, the same as the server.
@@ -244,7 +200,7 @@ namespace ASCOM.Meade.net
                         {
                             //MessageBox.Show("Adding Type: " + type.Name + " " + type.FullName);
                             _sComObjectTypes.Add(type); //PWGS - much simpler
-                            _sComObjectAssys.Add(so);
+                            //_sComObjectAssys.Add(so);
                         }
                     }
                 }
@@ -252,15 +208,13 @@ namespace ASCOM.Meade.net
                 {
                     // Probably an attempt to load a Win32 DLL (i.e. not a .net assembly)
                     // Just swallow the exception and continue to the next item.
-                    continue;
                 }
                 catch (Exception e)
                 {
-                    MessageBox.Show("Failed to load served COM class assembly " + fi.Name + " - " + e.Message,
-                        "Meade.net", MessageBoxButtons.OK, MessageBoxIcon.Stop);
+                    MessageBox.Show(string.Format(Resources.Server_LoadComObjectAssemblies_Failed_to_load_served_COM_class_assembly__0_____1_, fi.Name, e.Message),
+                        DriverName, MessageBoxButtons.OK, MessageBoxIcon.Stop);
                     return false;
                 }
-
             }
             return true;
         }
@@ -285,22 +239,22 @@ namespace ASCOM.Meade.net
         //
         private static void ElevateSelf(string arg)
         {
-            ProcessStartInfo si = new ProcessStartInfo();
-            si.Arguments = arg;
-            si.WorkingDirectory = Environment.CurrentDirectory;
-            si.FileName = Application.ExecutablePath;
-            si.Verb = "runas";
-            try { Process.Start(si); }
-            catch (System.ComponentModel.Win32Exception)
+            var si = new ProcessStartInfo
             {
-                MessageBox.Show("The Meade.net was not " + (arg == "/register" ? "registered" : "unregistered") +
-                    " because you did not allow it.", "Meade.net", MessageBoxButtons.OK, MessageBoxIcon.Warning);
+                Arguments = arg,
+                WorkingDirectory = Environment.CurrentDirectory,
+                FileName = Application.ExecutablePath,
+                Verb = "runas"
+            };
+            try { Process.Start(si); }
+            catch (Win32Exception)
+            {
+                MessageBox.Show(string.Format(Resources.Server_ElevateSelf_The__0__was_not__1__because_you_did_not_allow_it_, DriverName, (arg == "/register" ? "registered" : "unregistered")), DriverName, MessageBoxButtons.OK, MessageBoxIcon.Warning);
             }
             catch (Exception ex)
             {
-                MessageBox.Show(ex.ToString(), "Meade.net", MessageBoxButtons.OK, MessageBoxIcon.Stop);
+                MessageBox.Show(ex.ToString(), DriverName, MessageBoxButtons.OK, MessageBoxIcon.Stop);
             }
-            return;
         }
 
         //
@@ -348,21 +302,18 @@ namespace ASCOM.Meade.net
                 //
                 // HKCR\APPID\exename.ext
                 //
-                using (RegistryKey key = Registry.ClassesRoot.CreateSubKey(string.Format("APPID\\{0}",
-                            Application.ExecutablePath.Substring(Application.ExecutablePath.LastIndexOf('\\') + 1))))
+                using (RegistryKey key = Registry.ClassesRoot.CreateSubKey(
+                    $"APPID\\{Application.ExecutablePath.Substring(Application.ExecutablePath.LastIndexOf('\\') + 1)}"))
                 {
                     key.SetValue("AppID", _sAppId);
                 }
             }
             catch (Exception ex)
             {
-                MessageBox.Show("Error while registering the server:\n" + ex.ToString(),
-                        "Meade.net", MessageBoxButtons.OK, MessageBoxIcon.Stop);
+                MessageBox.Show(string.Format(Resources.Server_RegisterObjects_, ex),
+                    DriverName, MessageBoxButtons.OK, MessageBoxIcon.Stop);
                 return;
             }
-            finally
-            {
-            }
 
             //
             // For each of the driver assemblies
@@ -380,7 +331,7 @@ namespace ASCOM.Meade.net
                     //PWGS Generate device type from the Class name
                     string deviceType = type.Name;
 
-                    using (RegistryKey key = Registry.ClassesRoot.CreateSubKey(string.Format("CLSID\\{0}", clsid)))
+                    using (RegistryKey key = Registry.ClassesRoot.CreateSubKey($"CLSID\\{clsid}"))
                     {
                         key.SetValue(null, progid);						// Could be assyTitle/Desc??, but .NET components show ProgId here
                         key.SetValue("AppId", _sAppId);
@@ -412,7 +363,7 @@ namespace ASCOM.Meade.net
                     //
                     // ASCOM 
                     //
-                    assy = type.Assembly;
+                    //assy = type.Assembly;
 
                     // Pull the display name from the ServedClassName attribute.
                     attr = Attribute.GetCustomAttribute(type, typeof(ServedClassNameAttribute)); //PWGS Changed to search type for attribute rather than assembly
@@ -425,13 +376,11 @@ namespace ASCOM.Meade.net
                 }
                 catch (Exception ex)
                 {
-                    MessageBox.Show("Error while registering the server:\n" + ex.ToString(),
-                            "Meade.net", MessageBoxButtons.OK, MessageBoxIcon.Stop);
+                    MessageBox.Show(string.Format(Resources.Server_RegisterObjects_, ex),
+                        DriverName, MessageBoxButtons.OK, MessageBoxIcon.Stop);
                     bFail = true;
                 }
-                finally
-                {
-                }
+
                 if (bFail) break;
             }
         }
@@ -453,9 +402,9 @@ namespace ASCOM.Meade.net
             //
             // Local server's DCOM/AppID information
             //
-            Registry.ClassesRoot.DeleteSubKey(string.Format("APPID\\{0}", _sAppId), false);
-            Registry.ClassesRoot.DeleteSubKey(string.Format("APPID\\{0}",
-                    Application.ExecutablePath.Substring(Application.ExecutablePath.LastIndexOf('\\') + 1)), false);
+            Registry.ClassesRoot.DeleteSubKey($"APPID\\{_sAppId}", false);
+            Registry.ClassesRoot.DeleteSubKey(
+                $"APPID\\{Application.ExecutablePath.Substring(Application.ExecutablePath.LastIndexOf('\\') + 1)}", false);
 
             //
             // For each of the driver assemblies
@@ -471,17 +420,17 @@ namespace ASCOM.Meade.net
                 //
                 // HKCR\progid
                 //
-                Registry.ClassesRoot.DeleteSubKey(String.Format("{0}\\CLSID", progid), false);
+                Registry.ClassesRoot.DeleteSubKey($"{progid}\\CLSID", false);
                 Registry.ClassesRoot.DeleteSubKey(progid, false);
                 //
                 // HKCR\CLSID\clsid
                 //
-                Registry.ClassesRoot.DeleteSubKey(String.Format("CLSID\\{0}\\Implemented Categories\\{{62C8FE65-4EBB-45e7-B440-6E39B2CDBF29}}", clsid), false);
-                Registry.ClassesRoot.DeleteSubKey(String.Format("CLSID\\{0}\\Implemented Categories", clsid), false);
-                Registry.ClassesRoot.DeleteSubKey(String.Format("CLSID\\{0}\\ProgId", clsid), false);
-                Registry.ClassesRoot.DeleteSubKey(String.Format("CLSID\\{0}\\LocalServer32", clsid), false);
-                Registry.ClassesRoot.DeleteSubKey(String.Format("CLSID\\{0}\\Programmable", clsid), false);
-                Registry.ClassesRoot.DeleteSubKey(String.Format("CLSID\\{0}", clsid), false);
+                Registry.ClassesRoot.DeleteSubKey($"CLSID\\{clsid}\\Implemented Categories\\{{62C8FE65-4EBB-45e7-B440-6E39B2CDBF29}}", false);
+                Registry.ClassesRoot.DeleteSubKey($"CLSID\\{clsid}\\Implemented Categories", false);
+                Registry.ClassesRoot.DeleteSubKey($"CLSID\\{clsid}\\ProgId", false);
+                Registry.ClassesRoot.DeleteSubKey($"CLSID\\{clsid}\\LocalServer32", false);
+                Registry.ClassesRoot.DeleteSubKey($"CLSID\\{clsid}\\Programmable", false);
+                Registry.ClassesRoot.DeleteSubKey($"CLSID\\{clsid}", false);
                 try
                 {
                     //
@@ -493,7 +442,10 @@ namespace ASCOM.Meade.net
                         p.Unregister(progid);
                     }
                 }
-                catch (Exception) { }
+                catch (Exception)
+                {
+                    // ignored
+                }
             }
         }
         #endregion
@@ -504,7 +456,7 @@ namespace ASCOM.Meade.net
         // that we serve. This requires the class facgtory name to be
         // equal to the served class name + "ClassFactory".
         //
-        private static bool RegisterClassFactories()
+        private static void RegisterClassFactories()
         {
             _sClassFactories = new ArrayList();
             foreach (Type type in _sComObjectTypes)
@@ -513,13 +465,12 @@ namespace ASCOM.Meade.net
                 _sClassFactories.Add(factory);
                 if (!factory.RegisterClassObject())
                 {
-                    MessageBox.Show("Failed to register class factory for " + type.Name,
-                        "Meade.net", MessageBoxButtons.OK, MessageBoxIcon.Stop);
-                    return false;
+                    MessageBox.Show(string.Format(Resources.Server_RegisterClassFactories_Failed_to_register_class_factory_for__0_, type.Name),
+                        DriverName, MessageBoxButtons.OK, MessageBoxIcon.Stop);
+                    return;
                 }
             }
             ClassFactory.ResumeClassObjects();                                  // Served objects now go live
-            return true;
         }
 
         private static void RevokeClassFactories()
@@ -569,8 +520,9 @@ namespace ASCOM.Meade.net
                         break;
 
                     default:
-                        MessageBox.Show("Unknown argument: " + args[0] + "\nValid are : -register, -unregister and -embedding",
-                            "Meade.net", MessageBoxButtons.OK, MessageBoxIcon.Exclamation);
+                        MessageBox.Show(
+                            string.Format(Resources.Server_ProcessArguments_, args[0]),
+                            DriverName, MessageBoxButtons.OK, MessageBoxIcon.Exclamation);
                         break;
                 }
             }
@@ -609,9 +561,11 @@ namespace ASCOM.Meade.net
             RegisterClassFactories();
 
             // Start up the garbage collection thread.
-            GarbageCollection garbageCollector = new GarbageCollection(1000);
-            Thread gcThread = new Thread(new ThreadStart(garbageCollector.GcWatch));
-            gcThread.Name = "Garbage Collection Thread";
+            var garbageCollector = new GarbageCollection(1000);
+            var gcThread = new Thread(garbageCollector.GcWatch)
+            {
+                Name = "Garbage Collection Thread"
+            };
             gcThread.Start();
 
             //

Meade.net/Localization/LocalisationHelper.cs

@@ -1,36 +0,0 @@
-using System.Globalization;
-using System.Threading;
-using System.Resources;
-using System.Reflection;
-
-namespace ASCOM.Meade.net.Localization
-{
-    internal class LocalisationHelper
-    {
-        private const string LocalizationNamespace = "LocalisationTest.Localization.Resources.Localization";
-        private readonly ResourceManager _resourceManager;
-
-        public LocalisationHelper()
-        {
-            _resourceManager = new ResourceManager(LocalizationNamespace, Assembly.GetExecutingAssembly());
-
-            SetLocalisation(CultureInfo.CurrentCulture.Name);
-        }
-
-        internal void SetLocalisation(string name)
-        {
-            var cultureInfo = new CultureInfo(name);
-
-            //CultureInfo.DefaultThreadCurrentCulture = cultureInfo;
-            //CultureInfo.DefaultThreadCurrentUICulture = cultureInfo;
-
-            Thread.CurrentThread.CurrentCulture = cultureInfo;
-            Thread.CurrentThread.CurrentUICulture = cultureInfo;
-        }
-
-        internal string GetString(string key)
-        {
-            return _resourceManager.GetString(key);
-        }
-    }
-}

Meade.net/Meade.net.csproj

@@ -43,6 +43,7 @@
     <PlatformTarget>AnyCPU</PlatformTarget>
     <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
     <Prefer32Bit>true</Prefer32Bit>
+    <AllowUnsafeBlocks>false</AllowUnsafeBlocks>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
@@ -68,7 +69,7 @@
     <OutputPath>..\bin\Debug\</OutputPath>
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <DebugType>full</DebugType>
-    <PlatformTarget>x86</PlatformTarget>
+    <PlatformTarget>AnyCPU</PlatformTarget>
     <ErrorReport>prompt</ErrorReport>
     <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
     <Prefer32Bit>true</Prefer32Bit>
@@ -121,7 +122,9 @@
     <Reference Include="System.Windows.Forms" />
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="AssemblyInfo.cs" />
     <Compile Include="ClassFactory.cs" />
+    <Compile Include="ConnectionInfo.cs" />
     <Compile Include="frmMain.cs">
       <SubType>Form</SubType>
     </Compile>
@@ -129,10 +132,11 @@
       <DependentUpon>frmMain.cs</DependentUpon>
     </Compile>
     <Compile Include="GarbageCollection.cs" />
-    <Compile Include="Localization\LocalisationHelper.cs" />
     <Compile Include="LocalServer.cs" />
     <Compile Include="ProfileProperties.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
+    <Compile Include="TelescopeList.cs" />
+    <Compile Include="Win32Utilities.cs" />
     <Compile Include="Wrapper\SharedResourcesWrapper.cs" />
     <EmbeddedResource Include="frmMain.resx">
       <SubType>Designer</SubType>
@@ -163,7 +167,6 @@
   <ItemGroup>
     <Content Include="ASCOM.ico" />
     <Content Include="ASCOM.png" />
-    <Content Include="ReadMe.htm" />
     <None Include="BootstrapAscomProfileStore.ps1" />
     <None Include="packages.config" />
     <None Include="Resources\ASCOM.bmp" />

Meade.net/ProfileProperties.cs

@@ -5,5 +5,7 @@ namespace ASCOM.Meade.net
         // properies that are part of the profile
         public string ComPort { get; set; }
         public bool TraceLogger { get; set; }
+        public double GuideRateArcSecondsPerSecond { get; set; }
+        public string Precision { get; set; }
     }
 }

Meade.net/Properties/AssemblyInfo.cs

@@ -8,7 +8,7 @@ using System.Runtime.InteropServices;
 [assembly: AssemblyDescription("ASCOM multi-interface server for Meade.net")]
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("cjdawson.com")]
-[assembly: AssemblyProduct("")]
+[assembly: AssemblyProduct("ASCOM Meade Generic")]
 [assembly: AssemblyCopyright("Copyright © 2019 cjdawson.com")]
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
@@ -23,4 +23,4 @@ using System.Runtime.InteropServices;
 [assembly: AssemblyVersion("0.0.0.0")]
 [assembly: AssemblyFileVersion("0.0.0.0")]
 
-[assembly: ComVisibleAttribute(false)]
+[assembly: ComVisible(false)]

Meade.net/Properties/Resources.Designer.cs

@@ -69,5 +69,71 @@ namespace ASCOM.Meade.net.Properties {
                 return ((System.Drawing.Bitmap)(obj));
             }
         }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to The {0} was not {1} because you did not allow it..
+        /// </summary>
+        internal static string Server_ElevateSelf_The__0__was_not__1__because_you_did_not_allow_it_ {
+            get {
+                return ResourceManager.GetString("Server_ElevateSelf_The__0__was_not__1__because_you_did_not_allow_it_", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Failed to load served COM class assembly {0} - {1}.
+        /// </summary>
+        internal static string Server_LoadComObjectAssemblies_Failed_to_load_served_COM_class_assembly__0_____1_ {
+            get {
+                return ResourceManager.GetString("Server_LoadComObjectAssemblies_Failed_to_load_served_COM_class_assembly__0_____1_" +
+                        "", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Unknown argument: {0}
+        ///Valid are : -register, -unregister and -embedding.
+        /// </summary>
+        internal static string Server_ProcessArguments_ {
+            get {
+                return ResourceManager.GetString("Server_ProcessArguments_", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Failed to register class factory for {0}.
+        /// </summary>
+        internal static string Server_RegisterClassFactories_Failed_to_register_class_factory_for__0_ {
+            get {
+                return ResourceManager.GetString("Server_RegisterClassFactories_Failed_to_register_class_factory_for__0_", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Error while registering the server:
+        ///{0}.
+        /// </summary>
+        internal static string Server_RegisterObjects_ {
+            get {
+                return ResourceManager.GetString("Server_RegisterObjects_", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to {0} Settings ({1}).
+        /// </summary>
+        internal static string SetupDialogForm_SetupDialogForm__0__Settings___1__ {
+            get {
+                return ResourceManager.GetString("SetupDialogForm_SetupDialogForm__0__Settings___1__", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to ({0:00.0}% of sidereal rate).
+        /// </summary>
+        internal static string SetupDialogForm_TextBox1_TextChanged___0_00_0___of_sidereal_rate_ {
+            get {
+                return ResourceManager.GetString("SetupDialogForm_TextBox1_TextChanged___0_00_0___of_sidereal_rate_", resourceCulture);
+            }
+        }
     }
 }

Meade.net/Properties/Resources.resx

@@ -121,4 +121,27 @@
   <data name="ASCOM" type="System.Resources.ResXFileRef, System.Windows.Forms">
     <value>..\ASCOM.png;System.Drawing.Bitmap, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a</value>
   </data>
+  <data name="Server_ProcessArguments_" xml:space="preserve">
+    <value>Unknown argument: {0}
+Valid are : -register, -unregister and -embedding</value>
+  </data>
+  <data name="Server_RegisterClassFactories_Failed_to_register_class_factory_for__0_" xml:space="preserve">
+    <value>Failed to register class factory for {0}</value>
+  </data>
+  <data name="Server_RegisterObjects_" xml:space="preserve">
+    <value>Error while registering the server:
+{0}</value>
+  </data>
+  <data name="Server_ElevateSelf_The__0__was_not__1__because_you_did_not_allow_it_" xml:space="preserve">
+    <value>The {0} was not {1} because you did not allow it.</value>
+  </data>
+  <data name="Server_LoadComObjectAssemblies_Failed_to_load_served_COM_class_assembly__0_____1_" xml:space="preserve">
+    <value>Failed to load served COM class assembly {0} - {1}</value>
+  </data>
+  <data name="SetupDialogForm_TextBox1_TextChanged___0_00_0___of_sidereal_rate_" xml:space="preserve">
+    <value>({0:00.0}% of sidereal rate)</value>
+  </data>
+  <data name="SetupDialogForm_SetupDialogForm__0__Settings___1__" xml:space="preserve">
+    <value>{0} Settings ({1})</value>
+  </data>
 </root>

Meade.net/ReadMe.htm

@@ -1,666 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
-<HTML>
-  <HEAD>
-    <META HTTP-EQUIV="CONTENT-TYPE" CONTENT="text/html; charset=windows-1252"/>
-    <TITLE>Untitled Document</TITLE>
-    <META NAME="GENERATOR" CONTENT="OpenOffice.org 3.2  (Win32)"/>
-    <META NAME="CREATED" CONTENT="0;0"/>
-    <META NAME="CHANGEDBY" CONTENT="Chris Rowland"/>
-    <META NAME="CHANGED" CONTENT="20110422;10442800"/>
-    <META NAME="CHANGEDBY" CONTENT="Chris Rowland"/>
-    <STYLE TYPE="text/css">
-      <!--
-		@page { margin: 2cm }
-		P { font-family: "Verdana", "Arial", "Helvetica", sans-serif; font-weight: normal }
-		TD P { font-family: "Verdana", "Arial", "Helvetica", sans-serif; font-weight: normal }
-		H3 { font-family: "Arial", "Helvetica", sans-serif }
-		H2 { font-family: "Arial", "Helvetica", sans-serif }
-		H4 { font-family: "Arial", "Helvetica", sans-serif }
-		PRE { margin-left: 0.18cm; margin-right: 0.18cm; margin-top: 0.18cm; margin-bottom: 0.18cm; background: #ccffff }
-		PRE.western { font-weight: normal }
-		PRE.cjk { font-family: "NSimSun", monospace; font-weight: normal }
-		PRE.ctl { font-weight: normal }
-		EM.underline { text-decoration: underline }
-	-->
-    </STYLE>
-  </HEAD>
-  <BODY LANG="en-GB" DIR="LTR">
-    <TABLE WIDTH="100%" BORDER="0" CELLPADDING="4" CELLSPACING="0" STYLE="page-break-before: always">
-      <TR>
-        <TD>
-          <H2>
-            ASCOM LocalServer (singleton) Host
-          </H2>
-        </TD>
-      </TR>
-    </TABLE>
-    <P>
-      <BR/>
-      <BR/>
-
-    </P>
-    <H4>
-      You have just created a local server (singleton) host for one or
-      more ASCOM driver classes.
-    </H4>
-    <HR/>
-    <P>
-      This project implements an ASCOM host server for one or more
-      driver classes in a single-instance executable. It can be used to
-      serve multiple instances of a single driver class (hub), provide
-      driver services for multiple devices (e.g., Telescope and Focuser) to
-      multiple applications and allow multiple devices of the same type to
-      be connected. In the latter scenario, the multiple driver classes
-      will often share one or more resources such as the serial connection
-      and a microcontroller in the combined device. From the client's
-      perspective, using the drivers served by the local server is exactly
-      the same as if the drivers are loaded into the client's process space
-      (in-proc servers).
-    </P>
-    <P STYLE="margin-left: 0.42cm; margin-right: 0.42cm; border: 1px solid #000000; padding: 0.21cm">
-      <STRONG>
-        <SPAN STYLE="background: #ffee88">NOTE:</SPAN>
-      </STRONG>
-      <SPAN STYLE="background: #ffee88">
-        Unless you are prepared to handle all of the timing issues that arise
-        when multiple clients are accessing the properties and methods of
-        your driver(s), stop now. Just because the local server serializes
-        the calls to your driver(s)' properties and methods does not mean
-        that there will be no timing or concurrency issues.<BR/>
-        &nbsp;<BR/>For
-        example, suppose the hub serves instances of a Telescope driver. One
-        client sets the TargetRightAscension property, then another sets
-        TargetRightAscension to a different value, then the first client sets
-        TargetDeclination, then the first client calls SlewToTarget()
-        followed by the second client calling SlewToTarget(). Besides the
-        first client's slew command sending the scope to the wrong (and
-        possibly dangerous) coordinates, there is the problem of the second
-        client trying to slew a slewing scope. Local server drivers are
-        tricky to get right. There is no such thing as &quot;ignorance is
-        bliss&quot; here.
-
-      </SPAN>
-    </P>
-    <P STYLE="margin-left: 0.42cm; margin-right: 0.42cm; border: 1px solid #000000; padding: 0.21cm">
-      <SPAN STYLE="background: #ffee88">
-        This implementation has changed
-        from what was defined for Platform 5.5 as follows:
-      </SPAN>
-    </P>
-    <P STYLE="margin-left: 0.42cm; margin-right: 0.42cm; border: 1px solid #000000; padding: 0.21cm">
-      <SPAN STYLE="background: #ffee88">
-        The drivers are now installed in
-        the same folder as the local server executable. This makes deployment
-        cleaner because the whole driver can exist in a single folder
-        independently of other drivers.
-      </SPAN>
-    </P>
-    <P STYLE="margin-left: 0.42cm; margin-right: 0.42cm; border: 1px solid #000000; padding: 0.21cm">
-      <SPAN STYLE="background: #ffee88">
-        The ProgId and friendly name as
-        displayed by the Chooser are defined using attributes. This allows
-        driver dlls to be identified clearly and so avoids confusion with
-        other dlls that may be required such as interop dlls.
-      </SPAN>
-    </P>
-    <P STYLE="margin-left: 0.42cm; margin-right: 0.42cm; border: 1px solid #000000; padding: 0.21cm">
-      <SPAN STYLE="background: #ffee88">
-        Some changes have been made that
-        will facilitate generating multiple drivers of the same type.
-      </SPAN>
-    </P>
-    <P STYLE="margin-left: 0.42cm; margin-right: 0.42cm; border: 1px solid #000000; padding: 0.21cm">
-      <SPAN STYLE="background: #ffee88">
-        I've put some additional advice and
-        comments in the notes below <I>in italics.</I>
-      </SPAN>
-    </P>
-    <P>
-      You're probably anxious to get going, but you really should read
-      through the <A HREF="#theory">Theory of Operation</A> and <A HREF="#details">
-        Detailed
-        Use and Deployment
-      </A> below.
-    </P>
-    <P>You must do the following in order to complete your local server:</P>
-    <OL>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">
-          In the local server's project
-          properties, Application tab, change BOTH the AssemblyName and the
-          default assembly name to ASCOM.xxx (e.g., ASCOM.SuperScope). <I>
-            This
-            may be done by default now.
-          </I>
-        </P>
-      </LI>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">
-          Add one or more driver skeleton
-          projects using the in-proc templates. You may use either the C# or
-          VB templates. Project name is not important (not used in ProgID)
-          choose something like TelescopeDriver. You will be changing the
-          substituted project name in these projects below. If you ensure that
-          the LocalServer and all the driver projects have the same NameSpace
-          e.g. ASCOM.SuperScope the renaming in section 6a will not be
-          required.
-        </P>
-      </LI>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">
-          Develop and debug these driver
-          projects as normal in-process assemblies. This will be much simpler
-          because the driver and test code can be debugged in the same
-          process.
-        </P>
-      </LI>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">
-          Build the LocalServer.
-        </P>
-      </LI>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">
-          Set a reference to the local
-          server <STRONG>project</STRONG> in each of the driver skeleton
-          projects.
-        </P>
-      </LI>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">In each skeleton driver project:</P>
-        <OL TYPE="a">
-          <LI>
-            <P STYLE="margin-bottom: 0cm">
-              Do a Find In Files for the
-              project name of the skeleton driver (e.g., TelescopeDriver) and
-              change it to match the project name of your local server (e.g.
-              SuperScope). You don't have to do this in the ReadMe.html file.
-              Everywhere else, however, is IMPORTANT. This sets the correct
-              namespace, progID, etc. If you're a bit more brave, you can use
-              Replace in Files. <I>
-                This may not be needed if the correct
-                namespace and naming conventions have been followed when the
-                drivers and local server were generated.
-              </I>
-            </P>
-          </LI>
-          <LI>
-            <P STYLE="margin-bottom: 0cm">
-              In project properties,
-              Application tab, change the assembly name to
-              ASCOM.<EM CLASS="underline">localserverprojectname</EM>.<EM>drivertype</EM>,
-              (e.g., ASCOM.SuperScope.Telescope).
-            </P>
-          </LI>
-          <LI>
-            <P STYLE="margin-bottom: 0cm">
-              In project properties,
-              Application tab, click Assembly Information...
-            </P>
-            <UL>
-              <LI>
-                <P STYLE="margin-bottom: 0cm">
-                  Assure that Make assembly COM
-                  visible is <STRONG>on</STRONG> (it should already be on).
-                </P>
-              </LI>
-              <LI>
-                <P STYLE="margin-bottom: 0cm">
-                  Edit the Product Name to be the
-                  &quot;friendly name&quot; of your driver as will be shown in the
-                  Chooser. <I>
-                    Not used now, use the ServedClassName attribute
-                    instead.
-                  </I>
-                </P>
-              </LI>
-            </UL>
-          </LI>
-          <LI>
-            <P STYLE="margin-bottom: 0cm">
-              In project properties, Build tab,
-              turn <STRONG>off</STRONG> Register for COM Interop.
-            </P>
-          </LI>
-          <LI>
-            <P>
-              Modify the driver class declaration to inherit from
-              ReferenceCountedObjectBase. Examples:<BR/>C#:
-            </P>
-            <PRE CLASS="western">
-              public class Telescope :
-              ReferenceCountedObjectBase,
-              ITelescope
-            </PRE>
-            <P>
-              VB:
-            </P>
-            <PRE CLASS="western">
-              Public Class Telescope
-              '==================================
-              Inherits ReferenceCountedObjectBase
-              Implements ITelescope
-              '==================================
-            </PRE>
-          </LI>
-          <LI>
-            <P STYLE="margin-bottom: 0cm">
-              In driver.cs/driver.vb, remove
-              the entire ASCOM Registration region
-            </P>
-          </LI>
-          <LI>
-            <P STYLE="margin-bottom: 0cm">
-              In driver.cs/driver.vb, remove
-              the private strings for driver ID and driver description. <I>
-                They
-                may be needed internally, and if so should be set from the
-                associated attributes, ServedClassName for the description and
-                ProgId for the driver Id.
-              </I>
-            </P>
-          </LI>
-          <LI>
-            <P STYLE="margin-bottom: 0cm">
-              Modify the class attributes by
-              adding the ServedClassName and ProgID attributes. The
-              ServedClassName attribute must be the friendly name shown as the
-              device name in the Chooser and the ProgId the progid of the driver
-              e.g. ASCOM.SuperScope.Telescope. The class header should look like
-              this:
-            </P>
-            <P STYLE="margin-bottom: 0cm">C#:</P>
-            <PRE CLASS="western" STYLE="margin-right: 0.16cm">
-              <FONT FACE="Consolas" SIZE="2" STYLE="font-size: 9pt">
-                [<FONT COLOR="#2b91af">Guid</FONT><FONT COLOR="#000000">(</FONT><FONT COLOR="#a31515">&quot;0AE8B38D-10A1-4A8D-A5B7-1B050F74B48B&quot;</FONT><FONT COLOR="#000000">)]  // set by the template</FONT>
-                <FONT COLOR="#000000">[</FONT><FONT COLOR="#2b91af">ProgId</FONT><FONT COLOR="#000000">(</FONT><FONT COLOR="#a31515">&quot;ASCOM.SuperScope.Telescope&quot;</FONT><FONT COLOR="#000000">)]</FONT>
-                <FONT COLOR="#000000">[</FONT><FONT COLOR="#2b91af">ServedClassName</FONT><FONT COLOR="#000000"> (</FONT><FONT COLOR="#a31515">&quot;Super Scope Telescope&quot;</FONT><FONT COLOR="#000000">)]</FONT>
-                <FONT COLOR="#000000">[</FONT><FONT COLOR="#2b91af">ClassInterface</FONT><FONT COLOR="#000000">(</FONT><FONT COLOR="#2b91af">ClassInterfaceType</FONT><FONT COLOR="#000000">.None)]</FONT>
-                <FONT COLOR="#0000ff">public </FONT><FONT COLOR="#0000ff">class </FONT><FONT COLOR="#2b91af">Telescope </FONT><FONT COLOR="#000000">: </FONT><FONT COLOR="#2b91af">ReferenceCountedObjectBase</FONT><FONT COLOR="#000000"> , </FONT><FONT COLOR="#2b91af">ITelescope</FONT>
-              </FONT>
-            </PRE>
-          </LI>
-        </OL>
-      </LI>
-    </OL>
-    <P STYLE="margin-bottom: 0cm">
-      <BR/>
-    </P>
-    <OL>
-      <OL TYPE="a">
-        <P>VB:</P>
-        <PRE CLASS="western">
-          <FONT FACE="Consolas" SIZE="2" STYLE="font-size: 9pt">
-            &lt;Guid(&ldquo;<FONT COLOR="#a31515">0AE8B38D-10A1-4A8D-A5B7-1B050F74B48B</FONT>&rdquo;)&gt;
-            &lt;ProgId(&ldquo;ASCOM.SuperScope.Telescope&rdquo;)&gt;
-            &lt;ServedClassName(&ldquo;Super Scope Telescope&rdquo;)&gt;
-            Public Class Telescope
-            '==================================
-            Inherits ReferenceCountedObjectBase
-            Implements ITelescope
-            '==================================
-          </FONT>
-        </PRE>
-      </OL>
-    </OL>
-    <P STYLE="margin-left: 2.5cm">
-      Add the following line to the driver
-      constructor, this sets the driver ID using the ProgId Attribute:
-    </P>
-    <OL>
-      <OL TYPE="a">
-        <P>C#</P>
-        <PRE CLASS="western">
-          <FONT FACE="Consolas" SIZE="2" STYLE="font-size: 9pt">
-            s_csDriverID = <FONT COLOR="#2b91af">Marshal</FONT><FONT COLOR="#000000">.GenerateProgIdForType(</FONT><FONT COLOR="#0000ff">this</FONT><FONT COLOR="#000000">.GetType());</FONT>
-          </FONT>
-        </PRE>
-        <P>VB:</P>
-        <PRE CLASS="western">
-          <FONT FACE="Consolas" SIZE="2" STYLE="font-size: 9pt">
-            s_csDriverID = <FONT COLOR="#2b91af">Marshal</FONT><FONT COLOR="#000000">.GenerateProgIdForType(</FONT><FONT COLOR="#0000ff">Me</FONT><FONT COLOR="#000000">.GetType())</FONT>
-          </FONT>
-        </PRE>
-      </OL>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">
-          Unless you're writing a
-          single-driver hub, you will have two or more driver types (e.g.
-          Telescope and Focuser) and thus two or more driver assembly projects
-          added. Presumably, these drivers need to share some resources (e.g.
-          a single COM port via Helper.Serial). <U>
-            Put shared resources into
-            the SharedResources class provided
-          </U>. There are some examples that
-          should give a clue, modify and delete these as required.
-        </P>
-      </LI>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">
-          A shared serial port is already
-          provided (see SharedResources.cs) as <FONT FACE="Lucida Console, Courier New, Courier, monospace">SharedResources.SharedSerial</FONT>
-          and it is an ASCOM Helper Serial object. You may wish to define
-          additional shared resources in static member variables with public
-          static accessor properties as is already done for SharedSerial.
-          Unfortunately, if you are a Visual Basic programmer, you will have
-          to make these additions in C#.
-        </P>
-      </LI>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">
-          If you are writing a hub and don't
-          need the serial port, in SharedResources.cs you can remove the
-          public static SharedSerial property, the m_SharedSerial member in
-          the private data region, and the line in main that initializes it.
-          If you don't need any other shared resources for your hub, then you
-          can remove the SharedResources.cs file completely.
-        </P>
-      </LI>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">
-          If you modified the LocalServer,
-          build it again now. This will refresh the stuff that's visible to
-          the drivers.
-        </P>
-      </LI>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">
-          Build the driver skeletons to
-          verify that you got all of the namespace and other variable changes.
-        </P>
-      </LI>
-      <LI>
-        <P>
-          The local server dynamically loads the driver assemblies from
-          the same folder as the local server executable. <BR/>
-          <BR/>During
-          development, you'll need to add a post-build task to each of your
-          driver assembly projects which puts a copy of the driver assembly
-          into the local server executable folder. Here is an example:
-        </P>
-        <PRE CLASS="western">    copy &quot;$(TargetPath)&quot; &quot;$(SolutionDir)\SuperScope\$(OutDir)\$(TargetFileName)&quot;</PRE>
-        <P STYLE="margin-bottom: 0cm">
-          This assumes that the server project is called &ldquo;SuperScope&rdquo;,
-          and handles using the debug or release build.<BR/>
-          Note the quotes for
-          possible path elements with spaces in them. <I>
-            An alternative is to
-            set the build path to the required destination instead of the
-            default path.
-          </I>
-        </P>
-      </LI>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">
-          <I>
-            Make sure the drivers are
-            registered through the local server by running it with the /register
-            parameter, see below for details.
-          </I>
-        </P>
-      </LI>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">
-          <SPAN STYLE="background: #ffff00">IMPORTANT:</SPAN>
-          With a local server based driver (or hub) it is possible for
-          multiple clients to control the device(s). It is up to you to
-          safeguard against abuse. <I>
-            The sort of thing that's needed is to
-            have a counter of the number of connections to a device, the
-            connection is only fully broken when the number of connections is
-            zero. You may also need code to prevent several drivers from talking
-            to the hardware at the same time, the lock pattern is useful for
-            that.
-          </I>
-        </P>
-      </LI>
-      <LI>
-        <P>
-          You may want to add controls and/or status information to the
-          main form frmMain of the local server. Please resist the temptation
-          to turn the local server's main form into a graphical device control
-          panel. Instead, make a separate application that uses the served
-          driver(s). <U>A driver is not a program!</U>
-        </P>
-      </LI>
-    </OL>
-    <H3>Notes</H3>
-    <UL>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">
-          The local server handles all of
-          the registration and unregistration for each of its served driver
-          classes, including the ASCOM Chooser info and the DCOM/AppID info
-          needed for activation from TheSky. By running the server from a
-          command line and giving /register or /unregister as the command line
-          option, it will register or unregister all served classes
-          (respectively). <SPAN STYLE="background: #ffff00">
-            Never use REGASM
-            on the local server executable!
-          </SPAN> <I>
-            This can be done in the
-            Visual Studio IDE by setting the server project to run as startup
-            and setting the command line argument to /register in Debug &ndash;
-            Start Options.
-          </I>
-        </P>
-      </LI>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">
-          When you make the installer for
-          your local server based driver/hub, do not let it register the
-          executable for COM. Instead, have it activate the installed local
-          server with the /register option.
-        </P>
-      </LI>
-      <LI>
-        <P>
-          The ASCOM registration uses the ServedClassName attribute as
-          the friendly name that will show in the chooser and the ProgId
-          attribute as the driver Id.
-        </P>
-      </LI>
-      <LI>
-        <P>
-          The best deployment way is to install all the files in a
-          folder that's a sub folder of the main driver, so the SuperScope
-          driver files will be in the folder ...\ASCOM\Telescope\SuperScope.
-          This can be done in the Inno script by changing the DefaultDirName
-          like this:<BR/>
-            DefaultDirName=&quot;{cf}\ASCOM\Telescope\SuperScope&quot;<BR/>then
-	the files can all be installed with DestDir: {app}; 
-        </P>
-      </LI>
-    </UL>
-    <H3>
-      <A NAME="theory"></A>Theory of Operation
-    </H3>
-    <P>
-      The local server is an executable which can provide multiple
-      instances of multiple drivers to multiple clients. This capability is
-      needed for two applications:
-    </P>
-    <UL>
-      <LI>
-        <P STYLE="margin-bottom: 0cm">
-          A hub, which allows multiple
-          clients to share a single device
-        </P>
-      </LI>
-      <LI>
-        <P>
-          A device which provides multiple services, such as a
-          telescope which has a focuser built-in where both the telescope and
-          focuser are controlled by the same serial connection and different
-          client programs need to control to the focuser and telescope.
-        </P>
-      </LI>
-    </UL>
-    <P>
-      By simply dropping suitably developed driver assemblies into the
-      same folder as the local server executable, the local server will
-      find them and register them for COM and ASCOM and serve any number of
-      instances of the drivers' interfaces to any number of client
-      programs. It does this by locating and loading the driver assemblies,
-      analysing them to detect their classes and interfaces, and
-      implementing a class factory that can create instances of them for
-      clients.
-    </P>
-    <P>
-      A driver is an assembly which contains a class that <EM>implements</EM>
-      one of the ASCOM standard driver interfaces and <EM>inherits</EM> the
-      ReferenceCountedObjectBase class of the local server. Apart from
-      that, driver assemblies are identical to those that are used
-      in-process (DLL-type). The instructions above detail the steps needed
-      to convert an in-process driver into one that can be served by the
-      local server.
-    </P>
-    <P>
-      The name of the local server is important, so we provide it as a
-      <EM>template</EM> from which you can create a local server for your
-      produce. To make this clear, let's assume that your company AlphaTech
-      produces a telescope system which contains a microcontroller that is
-      able to control not only the telescope mount, but also a focuser and
-      a camera rotator. The mount, focuser, and rotator are all controlled
-      via commands sent through a common serial line connecting the
-      computer to the microcontroller, so you need a local server. In
-      ASCOM, then, you probably want your system to appear as
-      AlphaTech.Telescope, AlphaTech.Focuser, and AlphaTech.Rotator. Then
-      you would name the local server AlphaTech. Be sure to give this due
-      consideration before creating the template, the project name is the
-      name of your local server. <I>
-        Is this still correct? I get the
-        impression that ASCOM.AlphaTech.Server would be OK.
-      </I>
-    </P>
-    <P>
-      The fact that driver classes inherit from the local server's
-      ReferenceCountedObjectBase class allows the local server to maintain
-      a reference count on the driver class. If a client creates an
-      instance of a served driver, the local server automatically starts up
-      and provides an instance of the class to the client. Once started the
-      local server can provide additional instances of any of its served
-      driver classes. If the reference count of all served classes drops to
-      zero as a result of clients releasing their instances, the local
-      server will automatically exit.
-    </P>
-    <P>
-      Registration services provided include not only the basic COM
-      class registration, but also DCOM/AppID info needed to use the served
-      classes from outbound connections from Software Bisque's TheSky. It
-      also registers the served classes for the ASCOM Chooser. The
-      &quot;friendly&quot; name of each served driver that appears in the
-      chooser comes from the driver's ServedClassName attribute. This also
-      used to identify a driver so that non driver dlls, such as Interop
-      dlls can be ignored. The COM ProgID for each served driver is
-      specified in the ProgId attribute - ASCOM.<EM>localservername</EM>.<EM>drivertype</EM>,
-      for example, ASCOM.AlphaTech.Telescope, where AlphaTech is the local
-      server name and Telescope is the type of the driver. Unregistering
-      removes all of this information from the system. Specifying the
-      ProgId as an attribute allows multiple driver assemblies to be
-      generated using the same source and namespace. This is used to
-      provide multiple instances of the same driver, each with a different
-      ProgId and so able to be registered separately.
-    </P>
-    <P>
-      Driver DLLs are identified for registering/unregistering because
-      they contain a type with the ServedClassName attribute. Only these
-      will be registered for Com and ASCOM.  This has changed; in Platform
-      5 there was no attribute and the local server attempted to register
-      all dlls. The new behaviour allows support dlls such as interop dlls
-      to be included without them being registered incorrectly.  There was
-      also an interim version where the ServedClassName attribute was on
-      the assembly, not the class.  <I>
-        All these previous versions, and the
-        new drivers will operate together with Platform 6, the changes are
-        local to the individual drivers.
-      </I>
-    </P>
-    <H3>
-      <A NAME="details"></A>Detailed Use and Deployment
-    </H3>
-    <P>
-      Once you have built your local server and the served driver class
-      assemblies, here's how to use it. To register the served classes,
-      activate the local server from a shell command line with the option
-      /register (or /regserver, for VB6 compatibility):
-    </P>
-    <PRE CLASS="western">
-      C:\xxx&gt; <EM>localserver</EM>.exe /register
-    </PRE>
-    <P>
-      To unregister the local server and its drivers, activate the local
-      server from a shell command line with the option /unregister (or
-      /unregserver for VB6 compatibility):
-    </P>
-    <PRE CLASS="western">
-      C:\xxx&gt; <EM>localserver</EM>.exe /unregister
-    </PRE>
-    <P>
-      When the operating system starts the local server in response to a
-      client creating one of it's served driver classes, the command option
-      /embedding is included. The local server's code detects this and sets
-      a variable that you can use.
-    </P>
-    <P STYLE="margin-bottom: 0cm">
-      When deploying a hub or set of drivers
-      with the local server, you'll have to arrange for the local server
-      and the driver assemblies to be placed together in a folder in the
-      ASCOM driver folder. Any support files, such as Interop DLLs can be
-      put in the same fiolder. That's all you need to do, the local server
-      will find them in the same folder as it is located in.
-    </P>
-    <DIV ALIGN="RIGHT">
-      <TABLE WIDTH="100"% BORDER="0" CELLPADDING="4" CELLSPACING="0">
-        <TR>
-          <TD>
-            <TABLE WIDTH="100"% BORDER="0" CELLPADDING="4" CELLSPACING="0">
-              <TR>
-                <TD>
-                  <H3>ASCOM Initiative</H3>
-                </TD>
-                <TD>
-                  <IMG SRC="ASCOM.png" NAME="graphics1" ALIGN="RIGHT" WIDTH="48" HEIGHT="56" BORDER="0"/>
-                </TD>
-              </TR>
-            </TABLE>
-            <P>
-              <BR/>
-              <BR/>
-
-            </P>
-          </TD>
-        </TR>
-        <TR>
-          <TD>
-            <P>
-              The ASCOM Initiative consists of a group of astronomy software
-              developers and instrument vendors whose goals are to promote the
-              driver/client model and scripting automation.
-            </P>
-            <P>
-              See the <A HREF="http://ascom-standards.org/" TARGET="browser">
-                ASCOM
-                web site
-              </A> for more information. Please participate in the
-              <A HREF="http://tech.groups.yahoo.com/group/ASCOM-Talk" TARGET="browser">
-                ASCOM-Talk
-                Yahoo Group
-              </A>.
-            </P>
-          </TD>
-        </TR>
-      </TABLE>
-    </DIV>
-    <P>
-      <BR/>
-      <BR/>
-
-    </P>
-    <P>
-      <BR/>
-      <BR/>
-
-    </P>
-  </BODY>
-</HTML>

Meade.net/SetupDialogForm.cs

@@ -1,16 +1,30 @@
 using System;
 using System.ComponentModel;
+using System.Diagnostics;
+using System.Globalization;
+using System.IO.Ports;
 using System.Runtime.InteropServices;
 using System.Windows.Forms;
+using ASCOM.Meade.net.Properties;
 
 namespace ASCOM.Meade.net
 {
-    [ComVisible(false)]					// Form not registered for COM!
+    [ComVisible(false)] // Form not registered for COM!
     public partial class SetupDialogForm : Form
     {
         public SetupDialogForm()
         {
             InitializeComponent();
+
+            var assemblyInfo = new AssemblyInfo();
+
+            Text = string.Format(Resources.SetupDialogForm_SetupDialogForm__0__Settings___1__, assemblyInfo.Product, assemblyInfo.AssemblyVersion);
+        }
+
+        public sealed override string Text
+        {
+            get => base.Text;
+            set => base.Text = value;
         }
 
         private void cmdCancel_Click(object sender, EventArgs e) // Cancel button event handler
@@ -22,7 +36,7 @@ namespace ASCOM.Meade.net
         {
             try
             {
-                System.Diagnostics.Process.Start("http://ascom-standards.org/");
+                Process.Start("http://ascom-standards.org/");
             }
             catch (Win32Exception noBrowser)
             {
@@ -33,27 +47,40 @@ namespace ASCOM.Meade.net
             {
                 MessageBox.Show(other.Message);
             }
-        }      
+        }
 
         public void SetProfile(ProfileProperties profileProperties)
         {
             chkTrace.Checked = profileProperties.TraceLogger;
             // set the list of com ports to those that are currently available
             comboBoxComPort.Items.Clear();
-            comboBoxComPort.Items.AddRange(System.IO.Ports.SerialPort.GetPortNames());      // use System.IO because it's static
+            comboBoxComPort.Items.AddRange(SerialPort
+                .GetPortNames()); // use System.IO because it's static
             // select the current port if possible
             if (comboBoxComPort.Items.Contains(profileProperties.ComPort))
             {
                 comboBoxComPort.SelectedItem = profileProperties.ComPort;
             }
+
+            txtGuideRate.Text = profileProperties.GuideRateArcSecondsPerSecond.ToString(CultureInfo.CurrentCulture);
+            try
+            {
+                cboPrecision.SelectedItem = profileProperties.Precision;
+            }
+            catch (Exception)
+            {
+                cboPrecision.SelectedItem = "Unchanged";
+            }
         }
 
-        public ProfileProperties GetProfile()
+    public ProfileProperties GetProfile()
         {
             var profileProperties = new ProfileProperties
             {
                 TraceLogger = chkTrace.Checked,
-                ComPort = comboBoxComPort.SelectedItem.ToString()
+                ComPort = comboBoxComPort.SelectedItem.ToString(),
+                GuideRateArcSecondsPerSecond = double.Parse(txtGuideRate.Text.Trim()),
+                Precision = cboPrecision.SelectedItem.ToString()
             };
 
             return profileProperties;
@@ -61,7 +88,56 @@ namespace ASCOM.Meade.net
 
         private void SetupDialogForm_Shown(object sender, EventArgs e)
         {
+            Win32Utilities.BringWindowToFront(Handle);
             Activate();
         }
+
+        private bool _guideRateValid = true;
+
+        private void TextBox1_TextChanged(object sender, EventArgs e)
+        {
+            try
+            {
+                double newGuideRate = double.Parse(txtGuideRate.Text.Trim());
+
+                const double siderealArcSecondsPerSecond = 15.041;
+                var percentOfSideReal = newGuideRate / siderealArcSecondsPerSecond * 100;
+
+                lblPercentOfSiderealRate.Text = string.Format(Resources.SetupDialogForm_TextBox1_TextChanged___0_00_0___of_sidereal_rate_, percentOfSideReal);
+                _guideRateValid = true;
+            }
+            catch (Exception)
+            {
+                //Surpressing this exception as if the value is not valid then it's not useful.
+                _guideRateValid = false;
+            }
+
+            UpdateOkButton();
+        }
+
+        private void UpdateOkButton()
+        {
+            cmdOK.Enabled = _guideRateValid && (comboBoxComPort.SelectedItem != null);
+        }
+
+        private void ComboBoxComPort_SelectedValueChanged(object sender, EventArgs e)
+        {
+            UpdateOkButton();
+        }
+
+        public void SetReadOnlyMode()
+        {
+            foreach (Control control in Controls)
+            {
+                control.Enabled = false;
+            }
+
+            cmdCancel.Enabled = true;
+            //cmdOK.Enabled = false;
+            //comboBoxComPort.Enabled = false;
+            //chkTrace.Enabled = false;
+            //txtGuideRate.Enabled = false;
+            //cboPrecision.Enabled = false;
+        }
     }
 }

Meade.net/SetupDialogForm.designer.cs

@@ -1,3 +1,6 @@
+using System.ComponentModel;
+using System.Windows.Forms;
+
 namespace ASCOM.Meade.net
 {
     partial class SetupDialogForm
@@ -5,7 +8,7 @@ namespace ASCOM.Meade.net
         /// <summary>
         /// Required designer variable.
         /// </summary>
-        private System.ComponentModel.IContainer components = null;
+        private IContainer components = null;
 
         /// <summary>
         /// Clean up any resources being used.
@@ -36,6 +39,12 @@ namespace ASCOM.Meade.net
             this.label2 = new System.Windows.Forms.Label();
             this.chkTrace = new System.Windows.Forms.CheckBox();
             this.comboBoxComPort = new System.Windows.Forms.ComboBox();
+            this.label3 = new System.Windows.Forms.Label();
+            this.txtGuideRate = new System.Windows.Forms.TextBox();
+            this.label4 = new System.Windows.Forms.Label();
+            this.lblPercentOfSiderealRate = new System.Windows.Forms.Label();
+            this.label5 = new System.Windows.Forms.Label();
+            this.cboPrecision = new System.Windows.Forms.ComboBox();
             ((System.ComponentModel.ISupportInitialize)(this.picASCOM)).BeginInit();
             this.SuspendLayout();
             // 
@@ -85,11 +94,55 @@ namespace ASCOM.Meade.net
             this.comboBoxComPort.FormattingEnabled = true;
             resources.ApplyResources(this.comboBoxComPort, "comboBoxComPort");
             this.comboBoxComPort.Name = "comboBoxComPort";
+            this.comboBoxComPort.SelectedValueChanged += new System.EventHandler(this.ComboBoxComPort_SelectedValueChanged);
+            // 
+            // label3
+            // 
+            resources.ApplyResources(this.label3, "label3");
+            this.label3.Name = "label3";
+            // 
+            // txtGuideRate
+            // 
+            resources.ApplyResources(this.txtGuideRate, "txtGuideRate");
+            this.txtGuideRate.Name = "txtGuideRate";
+            this.txtGuideRate.TextChanged += new System.EventHandler(this.TextBox1_TextChanged);
+            // 
+            // label4
+            // 
+            resources.ApplyResources(this.label4, "label4");
+            this.label4.Name = "label4";
+            // 
+            // lblPercentOfSiderealRate
+            // 
+            resources.ApplyResources(this.lblPercentOfSiderealRate, "lblPercentOfSiderealRate");
+            this.lblPercentOfSiderealRate.Name = "lblPercentOfSiderealRate";
+            // 
+            // label5
+            // 
+            resources.ApplyResources(this.label5, "label5");
+            this.label5.Name = "label5";
+            // 
+            // cboPrecision
+            // 
+            this.cboPrecision.DropDownStyle = System.Windows.Forms.ComboBoxStyle.DropDownList;
+            this.cboPrecision.FormattingEnabled = true;
+            this.cboPrecision.Items.AddRange(new object[] {
+            resources.GetString("cboPrecision.Items"),
+            resources.GetString("cboPrecision.Items1"),
+            resources.GetString("cboPrecision.Items2")});
+            resources.ApplyResources(this.cboPrecision, "cboPrecision");
+            this.cboPrecision.Name = "cboPrecision";
             // 
             // SetupDialogForm
             // 
             resources.ApplyResources(this, "$this");
             this.AutoScaleMode = System.Windows.Forms.AutoScaleMode.Font;
+            this.Controls.Add(this.cboPrecision);
+            this.Controls.Add(this.label5);
+            this.Controls.Add(this.lblPercentOfSiderealRate);
+            this.Controls.Add(this.label4);
+            this.Controls.Add(this.txtGuideRate);
+            this.Controls.Add(this.label3);
             this.Controls.Add(this.comboBoxComPort);
             this.Controls.Add(this.chkTrace);
             this.Controls.Add(this.label2);
@@ -102,6 +155,7 @@ namespace ASCOM.Meade.net
             this.MinimizeBox = false;
             this.Name = "SetupDialogForm";
             this.SizeGripStyle = System.Windows.Forms.SizeGripStyle.Hide;
+            this.TopMost = true;
             this.Shown += new System.EventHandler(this.SetupDialogForm_Shown);
             ((System.ComponentModel.ISupportInitialize)(this.picASCOM)).EndInit();
             this.ResumeLayout(false);
@@ -111,12 +165,18 @@ namespace ASCOM.Meade.net
 
         #endregion
 
-        private System.Windows.Forms.Button cmdOK;
-        private System.Windows.Forms.Button cmdCancel;
-        private System.Windows.Forms.Label label1;
-        private System.Windows.Forms.PictureBox picASCOM;
-        private System.Windows.Forms.Label label2;
-        private System.Windows.Forms.CheckBox chkTrace;
-        private System.Windows.Forms.ComboBox comboBoxComPort;
+        private Button cmdOK;
+        private Button cmdCancel;
+        private Label label1;
+        private PictureBox picASCOM;
+        private Label label2;
+        private CheckBox chkTrace;
+        private ComboBox comboBoxComPort;
+        private Label label3;
+        private TextBox txtGuideRate;
+        private Label label4;
+        private Label lblPercentOfSiderealRate;
+        private Label label5;
+        private ComboBox cboPrecision;
     }
 }

Meade.net/SetupDialogForm.resx

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <root>
   <!-- 
     Microsoft ResX Schema 
@@ -123,7 +123,7 @@
   </data>
   <assembly alias="System.Drawing" name="System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" />
   <data name="cmdOK.Location" type="System.Drawing.Point, System.Drawing">
-    <value>281, 112</value>
+    <value>281, 225</value>
   </data>
   <data name="cmdOK.Size" type="System.Drawing.Size, System.Drawing">
     <value>59, 24</value>
@@ -145,13 +145,13 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;cmdOK.ZOrder" xml:space="preserve">
-    <value>6</value>
+    <value>12</value>
   </data>
   <data name="cmdCancel.Anchor" type="System.Windows.Forms.AnchorStyles, System.Windows.Forms">
     <value>Bottom, Right</value>
   </data>
   <data name="cmdCancel.Location" type="System.Drawing.Point, System.Drawing">
-    <value>281, 142</value>
+    <value>281, 255</value>
   </data>
   <data name="cmdCancel.Size" type="System.Drawing.Size, System.Drawing">
     <value>59, 25</value>
@@ -172,13 +172,13 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;cmdCancel.ZOrder" xml:space="preserve">
-    <value>5</value>
+    <value>11</value>
   </data>
   <data name="label1.Location" type="System.Drawing.Point, System.Drawing">
     <value>12, 9</value>
   </data>
   <data name="label1.Size" type="System.Drawing.Size, System.Drawing">
-    <value>123, 31</value>
+    <value>274, 31</value>
   </data>
   <data name="label1.TabIndex" type="System.Int32, mscorlib">
     <value>2</value>
@@ -196,7 +196,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;label1.ZOrder" xml:space="preserve">
-    <value>4</value>
+    <value>10</value>
   </data>
   <data name="picASCOM.Anchor" type="System.Windows.Forms.AnchorStyles, System.Windows.Forms">
     <value>Top, Right</value>
@@ -223,7 +223,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;picASCOM.ZOrder" xml:space="preserve">
-    <value>3</value>
+    <value>9</value>
   </data>
   <data name="label2.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -250,13 +250,13 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;label2.ZOrder" xml:space="preserve">
-    <value>2</value>
+    <value>8</value>
   </data>
   <data name="chkTrace.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
   </data>
   <data name="chkTrace.Location" type="System.Drawing.Point, System.Drawing">
-    <value>77, 118</value>
+    <value>77, 136</value>
   </data>
   <data name="chkTrace.Size" type="System.Drawing.Size, System.Drawing">
     <value>69, 17</value>
@@ -277,7 +277,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;chkTrace.ZOrder" xml:space="preserve">
-    <value>1</value>
+    <value>7</value>
   </data>
   <data name="comboBoxComPort.Location" type="System.Drawing.Point, System.Drawing">
     <value>77, 87</value>
@@ -298,6 +298,168 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;comboBoxComPort.ZOrder" xml:space="preserve">
+    <value>6</value>
+  </data>
+  <data name="label3.AutoSize" type="System.Boolean, mscorlib">
+    <value>True</value>
+  </data>
+  <data name="label3.Location" type="System.Drawing.Point, System.Drawing">
+    <value>10, 162</value>
+  </data>
+  <data name="label3.Size" type="System.Drawing.Size, System.Drawing">
+    <value>61, 13</value>
+  </data>
+  <data name="label3.TabIndex" type="System.Int32, mscorlib">
+    <value>8</value>
+  </data>
+  <data name="label3.Text" xml:space="preserve">
+    <value>Guide Rate</value>
+  </data>
+  <data name="&gt;&gt;label3.Name" xml:space="preserve">
+    <value>label3</value>
+  </data>
+  <data name="&gt;&gt;label3.Type" xml:space="preserve">
+    <value>System.Windows.Forms.Label, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+  </data>
+  <data name="&gt;&gt;label3.Parent" xml:space="preserve">
+    <value>$this</value>
+  </data>
+  <data name="&gt;&gt;label3.ZOrder" xml:space="preserve">
+    <value>5</value>
+  </data>
+  <data name="txtGuideRate.Location" type="System.Drawing.Point, System.Drawing">
+    <value>77, 159</value>
+  </data>
+  <data name="txtGuideRate.Size" type="System.Drawing.Size, System.Drawing">
+    <value>46, 20</value>
+  </data>
+  <data name="txtGuideRate.TabIndex" type="System.Int32, mscorlib">
+    <value>9</value>
+  </data>
+  <data name="txtGuideRate.Text" xml:space="preserve">
+    <value>10.0</value>
+  </data>
+  <data name="&gt;&gt;txtGuideRate.Name" xml:space="preserve">
+    <value>txtGuideRate</value>
+  </data>
+  <data name="&gt;&gt;txtGuideRate.Type" xml:space="preserve">
+    <value>System.Windows.Forms.TextBox, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+  </data>
+  <data name="&gt;&gt;txtGuideRate.Parent" xml:space="preserve">
+    <value>$this</value>
+  </data>
+  <data name="&gt;&gt;txtGuideRate.ZOrder" xml:space="preserve">
+    <value>4</value>
+  </data>
+  <data name="label4.AutoSize" type="System.Boolean, mscorlib">
+    <value>True</value>
+  </data>
+  <data name="label4.Location" type="System.Drawing.Point, System.Drawing">
+    <value>129, 162</value>
+  </data>
+  <data name="label4.Size" type="System.Drawing.Size, System.Drawing">
+    <value>122, 13</value>
+  </data>
+  <data name="label4.TabIndex" type="System.Int32, mscorlib">
+    <value>10</value>
+  </data>
+  <data name="label4.Text" xml:space="preserve">
+    <value>Arc seconds per second</value>
+  </data>
+  <data name="&gt;&gt;label4.Name" xml:space="preserve">
+    <value>label4</value>
+  </data>
+  <data name="&gt;&gt;label4.Type" xml:space="preserve">
+    <value>System.Windows.Forms.Label, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+  </data>
+  <data name="&gt;&gt;label4.Parent" xml:space="preserve">
+    <value>$this</value>
+  </data>
+  <data name="&gt;&gt;label4.ZOrder" xml:space="preserve">
+    <value>3</value>
+  </data>
+  <data name="lblPercentOfSiderealRate.AutoSize" type="System.Boolean, mscorlib">
+    <value>True</value>
+  </data>
+  <data name="lblPercentOfSiderealRate.Location" type="System.Drawing.Point, System.Drawing">
+    <value>129, 175</value>
+  </data>
+  <data name="lblPercentOfSiderealRate.Size" type="System.Drawing.Size, System.Drawing">
+    <value>105, 13</value>
+  </data>
+  <data name="lblPercentOfSiderealRate.TabIndex" type="System.Int32, mscorlib">
+    <value>11</value>
+  </data>
+  <data name="lblPercentOfSiderealRate.Text" xml:space="preserve">
+    <value>(67% of sidereal rate)</value>
+  </data>
+  <data name="&gt;&gt;lblPercentOfSiderealRate.Name" xml:space="preserve">
+    <value>lblPercentOfSiderealRate</value>
+  </data>
+  <data name="&gt;&gt;lblPercentOfSiderealRate.Type" xml:space="preserve">
+    <value>System.Windows.Forms.Label, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+  </data>
+  <data name="&gt;&gt;lblPercentOfSiderealRate.Parent" xml:space="preserve">
+    <value>$this</value>
+  </data>
+  <data name="&gt;&gt;lblPercentOfSiderealRate.ZOrder" xml:space="preserve">
+    <value>2</value>
+  </data>
+  <data name="label5.AutoSize" type="System.Boolean, mscorlib">
+    <value>True</value>
+  </data>
+  <data name="label5.Location" type="System.Drawing.Point, System.Drawing">
+    <value>13, 194</value>
+  </data>
+  <data name="label5.Size" type="System.Drawing.Size, System.Drawing">
+    <value>50, 13</value>
+  </data>
+  <data name="label5.TabIndex" type="System.Int32, mscorlib">
+    <value>12</value>
+  </data>
+  <data name="label5.Text" xml:space="preserve">
+    <value>Precision</value>
+  </data>
+  <data name="&gt;&gt;label5.Name" xml:space="preserve">
+    <value>label5</value>
+  </data>
+  <data name="&gt;&gt;label5.Type" xml:space="preserve">
+    <value>System.Windows.Forms.Label, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+  </data>
+  <data name="&gt;&gt;label5.Parent" xml:space="preserve">
+    <value>$this</value>
+  </data>
+  <data name="&gt;&gt;label5.ZOrder" xml:space="preserve">
+    <value>1</value>
+  </data>
+  <data name="cboPrecision.Items" xml:space="preserve">
+    <value>Unchanged</value>
+  </data>
+  <data name="cboPrecision.Items1" xml:space="preserve">
+    <value>Low</value>
+  </data>
+  <data name="cboPrecision.Items2" xml:space="preserve">
+    <value>High</value>
+  </data>
+  <data name="cboPrecision.Location" type="System.Drawing.Point, System.Drawing">
+    <value>77, 191</value>
+  </data>
+  <data name="cboPrecision.Size" type="System.Drawing.Size, System.Drawing">
+    <value>90, 21</value>
+  </data>
+  <data name="cboPrecision.TabIndex" type="System.Int32, mscorlib">
+    <value>13</value>
+  </data>
+  <data name="&gt;&gt;cboPrecision.Name" xml:space="preserve">
+    <value>cboPrecision</value>
+  </data>
+  <data name="&gt;&gt;cboPrecision.Type" xml:space="preserve">
+    <value>System.Windows.Forms.ComboBox, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+  </data>
+  <data name="&gt;&gt;cboPrecision.Parent" xml:space="preserve">
+    <value>$this</value>
+  </data>
+  <data name="&gt;&gt;cboPrecision.ZOrder" xml:space="preserve">
     <value>0</value>
   </data>
   <metadata name="$this.Localizable" type="System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089">
@@ -307,7 +469,7 @@
     <value>6, 13</value>
   </data>
   <data name="$this.ClientSize" type="System.Drawing.Size, System.Drawing">
-    <value>350, 175</value>
+    <value>350, 288</value>
   </data>
   <data name="$this.StartPosition" type="System.Windows.Forms.FormStartPosition, System.Windows.Forms">
     <value>CenterScreen</value>

Meade.net/SharedResources.cs

@@ -13,8 +13,11 @@
 // Written by:	Bob Denny	29-May-2007
 // Modified by Chris Rowland and Peter Simpson to hamdle multiple hardware devices March 2011
 //
+
 using System;
 using System.Collections.Generic;
+using System.Globalization;
+using System.Windows.Forms;
 using ASCOM.Utilities;
 
 namespace ASCOM.Meade.net
@@ -58,12 +61,7 @@ namespace ASCOM.Meade.net
         /// <summary>
         /// Shared serial port
         /// </summary>
-        public static Serial SharedSerial => _sSharedSerial ?? (_sSharedSerial = new Serial());
-
-        /// <summary>
-        /// number of connections to the shared serial port
-        /// </summary>
-        public static int Connections { get; set; } = 0;
+        private static Serial SharedSerial => _sSharedSerial ?? (_sSharedSerial = new Serial());
 
         public static void SendBlind(string message)
         {
@@ -74,12 +72,6 @@ namespace ASCOM.Meade.net
             }
         }
 
-        public static bool SendBool(string message)
-        {
-            SharedSerial.ClearBuffers();
-            return SendChar(message) == "1";
-        }
-
         /// <summary>
         /// Example of a shared SendMessage method, the lock
         /// prevents different drivers tripping over one another.
@@ -116,37 +108,12 @@ namespace ASCOM.Meade.net
             }
         }
 
-        /// <summary>
-        /// Example of handling connecting to and disconnection from the
-        /// shared serial port.
-        /// Needs error handling
-        /// the port name etc. needs to be set up first, this could be done by the driver
-        /// checking Connected and if it's false setting up the port before setting connected to true.
-        /// It could also be put here.
-        /// </summary>
-        public static bool Connected
+        public static void ReadCharacters(int throwAwayCharacters)
         {
-            set
+            lock (LockObject)
             {
-                lock (LockObject)
-                {
-                    if (value)
-                    {
-                        if (Connections == 0)
-                            SharedSerial.Connected = true;
-                        Connections++;
-                    }
-                    else
-                    {
-                        Connections--;
-                        if (Connections <= 0)
-                        {
-                            SharedSerial.Connected = false;
-                        }
-                    }
-                }
+                SharedSerial.ReceiveCounted(throwAwayCharacters);
             }
-            get => SharedSerial.Connected;
         }
 
         #endregion
@@ -158,6 +125,8 @@ namespace ASCOM.Meade.net
         // Constants used for Profile persistence
         private const string ComPortProfileName = "COM Port";
         private const string TraceStateProfileName = "Trace Level";
+        private const string GuideRateProfileName = "Guide Rate Arc Seconds Per Second";
+        private const string PrecisionProfileName = "Precision";
 
         public static void WriteProfile(ProfileProperties profileProperties)
         {
@@ -168,12 +137,16 @@ namespace ASCOM.Meade.net
                     driverProfile.DeviceType = "Telescope";
                     driverProfile.WriteValue(DriverId, TraceStateProfileName, profileProperties.TraceLogger.ToString());
                     driverProfile.WriteValue(DriverId, ComPortProfileName, profileProperties.ComPort);
+                    driverProfile.WriteValue(DriverId, GuideRateProfileName, profileProperties.GuideRateArcSecondsPerSecond.ToString(CultureInfo.CurrentCulture));
+                    driverProfile.WriteValue(DriverId, PrecisionProfileName, profileProperties.Precision);
                 }
             }
         }
 
         private const string ComPortDefault = "COM1";
         private const string TraceStateDefault = "false";
+        private const string GuideRateProfileNameDefault = "10.077939"; //67% of sidereal rate
+        private const string PrecisionDefault = "Unchanged";
 
         public static ProfileProperties ReadProfile()
         {
@@ -183,10 +156,10 @@ namespace ASCOM.Meade.net
                 using (Profile driverProfile = new Profile())
                 {
                     driverProfile.DeviceType = "Telescope";
-                    profileProperties.ComPort =
-                        driverProfile.GetValue(DriverId, ComPortProfileName, string.Empty, ComPortDefault);
-                    profileProperties.TraceLogger = Convert.ToBoolean(driverProfile.GetValue(DriverId,
-                        TraceStateProfileName, string.Empty, TraceStateDefault));
+                    profileProperties.ComPort = driverProfile.GetValue(DriverId, ComPortProfileName, string.Empty, ComPortDefault);
+                    profileProperties.TraceLogger = Convert.ToBoolean(driverProfile.GetValue(DriverId, TraceStateProfileName, string.Empty, TraceStateDefault));
+                    profileProperties.GuideRateArcSecondsPerSecond = double.Parse(driverProfile.GetValue(DriverId, GuideRateProfileName, string.Empty, GuideRateProfileNameDefault));
+                    profileProperties.Precision = driverProfile.GetValue(DriverId, PrecisionProfileName, string.Empty, PrecisionDefault);
                 }
 
                 return profileProperties;
@@ -199,22 +172,19 @@ namespace ASCOM.Meade.net
 
         public static void SetupDialog()
         {
-            // consider only showing the setup dialog if not connected
-            // or call a different dialog if connected
-            if (Connections > 0)
-            {
-                System.Windows.Forms.MessageBox.Show("Already connected, please disconnect before altering settings");
-                return;
-            }
-
             var profileProperties = ReadProfile();
 
             using (SetupDialogForm f = new SetupDialogForm())
             {
                 f.SetProfile(profileProperties);
-                
+
+                if (IsConnected())
+                {
+                    f.SetReadOnlyMode();
+                }
+
                 var result = f.ShowDialog();
-                if (result == System.Windows.Forms.DialogResult.OK)
+                if (result == DialogResult.OK)
                 {
                     profileProperties = f.GetProfile();
 
@@ -244,24 +214,32 @@ namespace ASCOM.Meade.net
         /// The Key is the connection number that identifies the device, it could be the COM port name,
         /// USB ID or IP Address, the Value is the DeviceHardware class
         /// </summary>
-        private static readonly Dictionary<string, DeviceHardware> _connectedDevices = new Dictionary<string, DeviceHardware>();
+        private static readonly Dictionary<string, DeviceHardware> ConnectedDevices = new Dictionary<string, DeviceHardware>();
+
+        private static readonly Dictionary<string, DeviceHardware> ConnectedDeviceIds = new Dictionary<string, DeviceHardware>();
+
 
         /// <summary>
         /// This is called in the driver Connect(true) property,
         /// it add the device id to the list of devices if it's not there and increments the device count.
         /// </summary>
         /// <param name="deviceId"></param>
-        public static void Connect(string deviceId)
+        /// <param name="driverId"></param>
+        public static ConnectionInfo Connect(string deviceId, string driverId)
         {
             lock (LockObject)
             {
-                if (!_connectedDevices.ContainsKey(deviceId))
-                    _connectedDevices.Add(deviceId, new DeviceHardware());
-                _connectedDevices[deviceId].Count++; // increment the value
+                if (!ConnectedDevices.ContainsKey(deviceId))
+                    ConnectedDevices.Add(deviceId, new DeviceHardware());
+                ConnectedDevices[deviceId].Count++; // increment the value
+
+                if (!ConnectedDeviceIds.ContainsKey(driverId))
+                    ConnectedDeviceIds.Add(driverId, new DeviceHardware());
+                ConnectedDeviceIds[driverId].Count++; // increment the value
 
                 if (deviceId == "Serial")
                 {
-                    if (_connectedDevices[deviceId].Count == 1)
+                    if (ConnectedDevices[deviceId].Count == 1)
                     {
                         var profileProperties = ReadProfile();
                         SharedSerial.PortName = profileProperties.ComPort;
@@ -278,34 +256,48 @@ namespace ASCOM.Meade.net
                         FirmwareVersion = SendString(":GVN#");
                     }
                 }
+
+                return new ConnectionInfo
+                {
+                    Connections = ConnectedDevices[deviceId].Count,
+                    SameDevice = ConnectedDeviceIds[driverId].Count
+                };
             }
         }
 
-        public static void Disconnect(string deviceId)
+        public static void Disconnect(string deviceId, string driverId)
         {
             lock (LockObject)
             {
-                if (_connectedDevices.ContainsKey(deviceId))
+                if (ConnectedDevices.ContainsKey(deviceId))
                 {
-                    _connectedDevices[deviceId].Count--;
-                    if (_connectedDevices[deviceId].Count <= 0)
+                    ConnectedDevices[deviceId].Count--;
+                    if (ConnectedDevices[deviceId].Count <= 0)
                     {
-                        _connectedDevices.Remove(deviceId);
+                        ConnectedDevices.Remove(deviceId);
                         if (deviceId == "Serial")
                         {
                             SharedSerial.Connected = false;
                         }
                     }
                 }
+
+                if (ConnectedDeviceIds.ContainsKey(driverId))
+                {
+                    ConnectedDeviceIds[driverId].Count--;
+                }
             }
         }
 
-        public static bool IsConnected(string deviceId)
+        private static bool IsConnected()
         {
-            if (_connectedDevices.ContainsKey(deviceId))
-                return (_connectedDevices[deviceId].Count > 0);
-            else
-                return false;
+            foreach (var device in ConnectedDevices)
+            {
+                if (device.Value.Count > 0)
+                    return true;
+            }
+
+            return false;
         }
 
         #endregion
@@ -330,46 +322,14 @@ namespace ASCOM.Meade.net
         /// Skeleton of a hardware class, all this does is hold a count of the connections,
         /// in reality extra code will be needed to handle the hardware in some way
         /// </summary>
-        public class DeviceHardware
+        private class DeviceHardware
         {
-            private int _count;
-
-            internal int Count
-            {
-                set => _count = value;
-                get => _count;
-            }
+            internal int Count { set; get; }
 
             internal DeviceHardware()
             {
                 Count = 0;
             }
         }
-
-        //#region ServedClassName attribute
-        ///// <summary>
-        ///// This is only needed if the driver is targeted at  platform 5.5, it is included with Platform 6
-        ///// </summary>
-        //[global::System.AttributeUsage(AttributeTargets.Class, Inherited = false, AllowMultiple = false)]
-        //public sealed class ServedClassNameAttribute : Attribute
-        //{
-        //    // See the attribute guidelines at 
-        //    //  http://go.microsoft.com/fwlink/?LinkId=85236
-
-        //    /// <summary>
-        //    /// Gets or sets the 'friendly name' of the served class, as registered with the ASCOM Chooser.
-        //    /// </summary>
-        //    /// <value>The 'friendly name' of the served class.</value>
-        //    public string DisplayName { get; private set; }
-        //    /// <summary>
-        //    /// Initializes a new instance of the <see cref="ServedClassNameAttribute"/> class.
-        //    /// </summary>
-        //    /// <param name="servedClassName">The 'friendly name' of the served class.</param>
-        //    public ServedClassNameAttribute(string servedClassName)
-        //    {
-        //        DisplayName = servedClassName;
-        //    }
-        //}
-        //#endregion
     }
 }

Meade.net/TelescopeList.cs

@@ -0,0 +1,33 @@
+namespace ASCOM.Meade.net
+{
+    public static class TelescopeList
+    {
+        #region Autostar 497/Audiostar
+
+        public static readonly string Autostar497 = "Autostar";
+
+        //Autostar/Audiostar firmware revisions
+        // ReSharper disable once InconsistentNaming
+        public static readonly string Autostar497_30Ee = "30Ee";
+        // ReSharper disable once InconsistentNaming
+        public static readonly string Autostar497_31Ee = "31Ee";
+        // ReSharper disable once InconsistentNaming
+        public static readonly string Autostar497_43Eg = "43Eg";
+
+        #endregion
+
+        #region LX200GPS
+
+        // ReSharper disable once InconsistentNaming
+        public static readonly string LX200GPS = "LX2001";
+
+        // ReSharper disable once InconsistentNaming
+        public static readonly string LX200GPS_42G = "4.2G";
+        #endregion
+
+        #region LX200EMC
+        // ReSharper disable once InconsistentNaming
+        public static readonly string LX200CLASSIC = ":GVP"; //GVP command is not supported!
+        #endregion
+    }
+}

Meade.net/Win32Utilities.cs

@@ -0,0 +1,148 @@
+using System;
+using System.Runtime.InteropServices;
+using System.Text;
+// ReSharper disable UnusedMember.Global
+
+namespace ASCOM.Meade.net
+{
+    internal static class Win32Utilities
+    {
+        //Win32 API calls necesary to raise an unowned processs main window
+
+        [DllImport("user32.dll")]
+
+        private static extern bool SetForegroundWindow(IntPtr hWnd);
+
+        [DllImport("user32.dll")]
+        private static extern bool ShowWindowAsync(IntPtr hWnd, int nCmdShow);
+
+        [DllImport("user32.dll")]
+        private static extern bool IsIconic(IntPtr hWnd);
+
+        [DllImport("user32.dll", SetLastError = true)]
+        private static extern bool SystemParametersInfo(uint uiAction, uint uiParam, IntPtr pvParam, uint fWinIni);
+
+        [DllImport("user32.dll", SetLastError = true)]
+        private static extern uint GetWindowThreadProcessId(IntPtr hWnd, IntPtr lpdwProcessId);
+
+        [DllImport("user32.dll")]
+        private static extern IntPtr GetForegroundWindow();
+
+        [DllImport("user32.dll")]
+        private static extern bool AttachThreadInput(uint idAttach, uint idAttachTo, bool fAttach);
+
+        [DllImport("user32.dll")]
+        static extern bool BringWindowToTop(IntPtr hWnd);
+
+        [DllImport("user32.dll")]
+        // ReSharper disable once UnusedMember.Local
+        private static extern int GetWindowText(IntPtr hWnd, StringBuilder lpString, Int32 nMaxCount);
+
+        [DllImport("user32.dll")]
+        // ReSharper disable once UnusedMember.Local
+        private static extern int GetWindowThreadProcessId(IntPtr hWnd, ref Int32 lpdwProcessId);
+
+        [DllImport("User32.dll")]
+        public static extern IntPtr GetParent(IntPtr hWnd);
+
+        // ReSharper disable once InconsistentNaming
+        // ReSharper disable once UnusedMember.Local
+        private const int SW_HIDE = 0;
+        // ReSharper disable once InconsistentNaming
+        // ReSharper disable once UnusedMember.Local
+        // ReSharper disable once IdentifierTypo
+        private const int SW_SHOWNORMAL = 1;
+        // ReSharper disable once InconsistentNaming
+        // ReSharper disable once UnusedMember.Local
+        private const int SW_NORMAL = 1;
+        // ReSharper disable once InconsistentNaming
+        // ReSharper disable once UnusedMember.Local
+        // ReSharper disable once IdentifierTypo
+        private const int SW_SHOWMINIMIZED = 2;
+        // ReSharper disable once InconsistentNaming
+        // ReSharper disable once UnusedMember.Local
+        // ReSharper disable once IdentifierTypo
+        private const int SW_SHOWMAXIMIZED = 3;
+        // ReSharper disable once InconsistentNaming
+        // ReSharper disable once UnusedMember.Local
+        private const int SW_MAXIMIZE = 3;
+        // ReSharper disable once InconsistentNaming
+        // ReSharper disable once UnusedMember.Local
+        // ReSharper disable once IdentifierTypo
+        private const int SW_SHOWNOACTIVATE = 4;
+        // ReSharper disable once InconsistentNaming
+        private const int SW_SHOW = 5;
+        // ReSharper disable once InconsistentNaming
+        // ReSharper disable once UnusedMember.Local
+        private const int SW_MINIMIZE = 6;
+        // ReSharper disable once InconsistentNaming
+        // ReSharper disable once UnusedMember.Local
+        // ReSharper disable once IdentifierTypo
+        private const int SW_SHOWMINNOACTIVE = 7;
+        // ReSharper disable once InconsistentNaming
+        // ReSharper disable once UnusedMember.Local
+        // ReSharper disable once IdentifierTypo
+        private const int SW_SHOWNA = 8;
+        // ReSharper disable once InconsistentNaming
+        private const int SW_RESTORE = 9;
+        // ReSharper disable once InconsistentNaming
+        // ReSharper disable once UnusedMember.Local
+        // ReSharper disable once IdentifierTypo
+        private const int SW_SHOWDEFAULT = 10;
+        // ReSharper disable once InconsistentNaming
+        // ReSharper disable once UnusedMember.Local
+        private const int SW_MAX = 10;
+
+        // ReSharper disable once InconsistentNaming
+        // ReSharper disable once IdentifierTypo
+        private const uint SPI_GETFOREGROUNDLOCKTIMEOUT = 0x2000;
+        // ReSharper disable once InconsistentNaming
+        // ReSharper disable once IdentifierTypo
+        private const uint SPI_SETFOREGROUNDLOCKTIMEOUT = 0x2001;
+
+        // ReSharper disable once InconsistentNaming
+        // ReSharper disable once IdentifierTypo
+        private const int SPIF_SENDCHANGE = 0x2;
+
+
+        public static void BringWindowToFront(IntPtr hWnd)
+        {
+            if (IsIconic(hWnd))
+                ShowWindowAsync(hWnd, SW_RESTORE);
+
+            ShowWindowAsync(hWnd, SW_SHOW);
+
+            SetForegroundWindow(hWnd);
+
+            // Code from Karl E. Peterson, www.mvps.org/vb/sample.htm
+            // Converted to Delphi by Ray Lischner
+            // Published in The Delphi Magazine 55, page 16
+            // Converted to C# by Kevin Gale
+            IntPtr foregroundWindow = GetForegroundWindow();
+            IntPtr dummy = IntPtr.Zero;
+
+            uint foregroundThreadId = GetWindowThreadProcessId(foregroundWindow, dummy);
+
+            uint thisThreadId = GetWindowThreadProcessId(hWnd, dummy);
+
+            if (AttachThreadInput(thisThreadId, foregroundThreadId, true))
+            {
+                BringWindowToTop(hWnd); // IE 5.5 related hack
+                SetForegroundWindow(hWnd);
+                AttachThreadInput(thisThreadId, foregroundThreadId, false);
+            }
+
+            if (GetForegroundWindow() != hWnd)
+            {
+                // Code by Daniel P. Stasinski
+                // Converted to C# by Kevin Gale
+                IntPtr timeout = IntPtr.Zero;
+                SystemParametersInfo(SPI_GETFOREGROUNDLOCKTIMEOUT, 0, timeout, 0);
+                SystemParametersInfo(SPI_SETFOREGROUNDLOCKTIMEOUT, 0, dummy, SPIF_SENDCHANGE);
+                BringWindowToTop(hWnd); // IE 5.5 related hack
+                SetForegroundWindow(hWnd);
+                SystemParametersInfo(SPI_SETFOREGROUNDLOCKTIMEOUT, 0, timeout, SPIF_SENDCHANGE);
+            }
+        }
+    }
+}

Meade.net/Wrapper/SharedResourcesWrapper.cs

@@ -4,13 +4,8 @@ namespace ASCOM.Meade.net.Wrapper
 {
     public interface ISharedResourcesWrapper
     {
-        string Autostar497 { get; }
-        string Autostar49731Ee { get; }
-
-        string Autostar49743Eg { get;}
-
-        void Connect(string deviceId);
-        void Disconnect(string deviceId);
+        ConnectionInfo Connect(string deviceId, string driverId);
+        void Disconnect(string deviceId, string driverId);
 
         string ProductName { get; }
 
@@ -28,27 +23,20 @@ namespace ASCOM.Meade.net.Wrapper
         ProfileProperties ReadProfile();
 
         void SetupDialog();
+        void WriteProfile(ProfileProperties profileProperties);
+        void ReadCharacters(int throwAwayCharacters);
     }
 
     public class SharedResourcesWrapper : ISharedResourcesWrapper
     {
-        #region AutostarProducts
-
-        public string Autostar497 => "Autostar";
-
-        public string Autostar49731Ee => "31Ee";
-        public string Autostar49743Eg => "43Eg";
-
-        #endregion
-
-        public void Connect(string deviceId)
+        public ConnectionInfo Connect(string deviceId, string driverId)
         {
-            SharedResources.Connect( deviceId);
+            return SharedResources.Connect(deviceId, driverId);
         }
 
-        public void Disconnect(string deviceId)
+        public void Disconnect(string deviceId, string driverId)
         {
-            SharedResources.Disconnect(deviceId);
+            SharedResources.Disconnect(deviceId, driverId);
         }
 
         public string ProductName => SharedResources.ProductName;
@@ -85,6 +73,11 @@ namespace ASCOM.Meade.net.Wrapper
             return SharedResources.ReadTerminated();
         }
 
+        public void ReadCharacters(int throwAwayCharacters)
+        {
+            SharedResources.ReadCharacters(throwAwayCharacters);
+        }
+
         public ProfileProperties ReadProfile()
         {
             return SharedResources.ReadProfile();
@@ -94,5 +87,10 @@ namespace ASCOM.Meade.net.Wrapper
         {
             SharedResources.SetupDialog();
         }
+
+        public void WriteProfile(ProfileProperties profileProperties)
+        {
+            SharedResources.WriteProfile(profileProperties);
+        }
     }
 }

Meade.net/frmMain.Designer.cs

@@ -1,4 +1,5 @@
-using System;
+using System.ComponentModel;
+using System.Windows.Forms;
 
 namespace ASCOM.Meade.net
 {
@@ -7,7 +8,7 @@ namespace ASCOM.Meade.net
         /// <summary>
         /// Required designer variable.
         /// </summary>
-        private System.ComponentModel.IContainer components = null;
+        private IContainer components = null;
 
         /// <summary>
         /// Clean up any resources being used.
@@ -56,7 +57,7 @@ namespace ASCOM.Meade.net
 
         #endregion
 
-        private System.Windows.Forms.Label label1;
+        private Label label1;
 
     }
 }

Meade.net/frmMain.cs

@@ -4,8 +4,6 @@ namespace ASCOM.Meade.net
 {
     public partial class FrmMain : Form
     {
-        delegate void SetTextCallback(string text);
-
         public FrmMain()
         {
             InitializeComponent();

Meade.net/frmMain.resx

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <root>
   <!-- 
     Microsoft ResX Schema 

TelescopeTestConsole/Program.cs

@@ -9,6 +9,7 @@
 #define UseChooser
 
 using System;
+using ASCOM.DriverAccess;
 
 namespace ASCOM.Meade.net
 {
@@ -19,11 +20,11 @@ namespace ASCOM.Meade.net
             // Uncomment the code that's required
 #if UseChooser
             // choose the device
-            string id = DriverAccess.Telescope.Choose("ASCOM.MeadeGeneric.Telescope");
+            string id = Telescope.Choose("ASCOM.MeadeGeneric.Telescope");
             if (string.IsNullOrEmpty(id))
                 return;
             // create this device
-            DriverAccess.Telescope device = new DriverAccess.Telescope(id);
+            Telescope device = new Telescope(id);
 #else
             // this can be replaced by this code, it avoids the chooser and creates the driver class directly.
             ASCOM.DriverAccess.Telescope device = new ASCOM.DriverAccess.Telescope("ASCOM.Meade.net.Telescope");

TelescopeTestConsole/TelescopeTestConsole.csproj

@@ -36,6 +36,25 @@
     <WarningLevel>4</WarningLevel>
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|AnyCPU'">
+    <DebugSymbols>true</DebugSymbols>
+    <OutputPath>bin\Debug\</OutputPath>
+    <DefineConstants>DEBUG;TRACE</DefineConstants>
+    <DebugType>full</DebugType>
+    <PlatformTarget>AnyCPU</PlatformTarget>
+    <ErrorReport>prompt</ErrorReport>
+    <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
+    <Prefer32Bit>true</Prefer32Bit>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|AnyCPU'">
+    <OutputPath>bin\Release\</OutputPath>
+    <DefineConstants>TRACE</DefineConstants>
+    <Optimize>true</Optimize>
+    <DebugType>pdbonly</DebugType>
+    <PlatformTarget>AnyCPU</PlatformTarget>
+    <ErrorReport>prompt</ErrorReport>
+    <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
+  </PropertyGroup>
   <ItemGroup>
     <Reference Include="ASCOM.DeviceInterfaces, Version=6.0.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL" />
     <Reference Include="ASCOM.DriverAccess, Version=6.0.0.0, Culture=neutral, PublicKeyToken=565de7938946fba7, processorArchitecture=MSIL" />