Redesigned the Altitude and Azimuth readings to use the Right Ascension and Declination co-ordinates and perform the transformation using the date and site details from the scope. This will correct the problem of the Altitude reading from the handset being incorrect.

2019-05-18 23:50:55 +01:00
parent cf5a6c72fe
commit cf28ecc7c2
9 changed files with 506 additions and 19 deletions
@@ -0,0 +1,83 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <Import Project="..\packages\NUnit.3.12.0\build\NUnit.props" Condition="Exists('..\packages\NUnit.3.12.0\build\NUnit.props')" />
+  <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
+  <PropertyGroup>
+    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
+    <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
+    <ProjectGuid>{AD4959DD-33D7-4C3F-8DB0-7361D8E74A95}</ProjectGuid>
+    <OutputType>Library</OutputType>
+    <AppDesignerFolder>Properties</AppDesignerFolder>
+    <RootNamespace>AstroMath.UnitTests</RootNamespace>
+    <AssemblyName>AstroMath.UnitTests</AssemblyName>
+    <TargetFrameworkVersion>v4.7.2</TargetFrameworkVersion>
+    <FileAlignment>512</FileAlignment>
+    <Deterministic>true</Deterministic>
+    <NuGetPackageImportStamp>
+    </NuGetPackageImportStamp>
+  </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
+    <DebugSymbols>true</DebugSymbols>
+    <DebugType>full</DebugType>
+    <Optimize>false</Optimize>
+    <OutputPath>bin\Debug\</OutputPath>
+    <DefineConstants>DEBUG;TRACE</DefineConstants>
+    <ErrorReport>prompt</ErrorReport>
+    <WarningLevel>4</WarningLevel>
+    <PlatformTarget>x86</PlatformTarget>
+  </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
+    <DebugType>pdbonly</DebugType>
+    <Optimize>true</Optimize>
+    <OutputPath>bin\Release\</OutputPath>
+    <DefineConstants>TRACE</DefineConstants>
+    <ErrorReport>prompt</ErrorReport>
+    <WarningLevel>4</WarningLevel>
+  </PropertyGroup>
+  <ItemGroup>
+    <Reference Include="Castle.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=407dd0808d44fbdc, processorArchitecture=MSIL">
+      <HintPath>..\packages\Castle.Core.4.3.1\lib\net45\Castle.Core.dll</HintPath>
+    </Reference>
+    <Reference Include="Moq, Version=4.10.0.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
+      <HintPath>..\packages\Moq.4.10.1\lib\net45\Moq.dll</HintPath>
+    </Reference>
+    <Reference Include="nunit.framework, Version=3.12.0.0, Culture=neutral, PublicKeyToken=2638cd05610744eb, processorArchitecture=MSIL">
+      <HintPath>..\packages\NUnit.3.12.0\lib\net45\nunit.framework.dll</HintPath>
+    </Reference>
+    <Reference Include="System" />
+    <Reference Include="System.Configuration" />
+    <Reference Include="System.Core" />
+    <Reference Include="System.Runtime.CompilerServices.Unsafe, Version=4.0.4.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
+      <HintPath>..\packages\System.Runtime.CompilerServices.Unsafe.4.5.0\lib\netstandard2.0\System.Runtime.CompilerServices.Unsafe.dll</HintPath>
+    </Reference>
+    <Reference Include="System.Threading.Tasks.Extensions, Version=4.2.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL">
+      <HintPath>..\packages\System.Threading.Tasks.Extensions.4.5.1\lib\netstandard2.0\System.Threading.Tasks.Extensions.dll</HintPath>
+    </Reference>
+    <Reference Include="System.Xml.Linq" />
+    <Reference Include="System.Data.DataSetExtensions" />
+    <Reference Include="Microsoft.CSharp" />
+    <Reference Include="System.Data" />
+    <Reference Include="System.Net.Http" />
+    <Reference Include="System.Xml" />
+  </ItemGroup>
+  <ItemGroup>
+    <Compile Include="AstroMathsUnitTests.cs" />
+    <Compile Include="Properties\AssemblyInfo.cs" />
+  </ItemGroup>
+  <ItemGroup>
+    <ProjectReference Include="..\Meade.net.Telescope\Meade.net.Telescope.csproj">
+      <Project>{64308775-bd4a-469c-bcab-3ed830b811af}</Project>
+      <Name>Meade.net.Telescope</Name>
+    </ProjectReference>
+  </ItemGroup>
+  <ItemGroup>
+    <None Include="packages.config" />
+  </ItemGroup>
+  <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
+  <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
+    <PropertyGroup>
+      <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
+    </PropertyGroup>
+    <Error Condition="!Exists('..\packages\NUnit.3.12.0\build\NUnit.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\NUnit.3.12.0\build\NUnit.props'))" />
+  </Target>
+</Project>
@@ -0,0 +1,149 @@
+using System;
+using ASCOM.Meade.net;
+using NUnit.Framework;
+
+namespace AstroMath.UnitTests
+{
+    [TestFixture]
+    public class AstroMathsUnitTests
+    {
+        private AstroMaths _astroMath;
+
+        [SetUp]
+        public void Setup()
+        {
+            _astroMath = new AstroMaths();
+        }
+
+        [Test]
+        public void DegreesToRadians()
+        {
+            var radians = _astroMath.DegreesToRadians(90);
+            Assert.That(radians, Is.EqualTo(1.5707963267948966));
+        }
+
+        [Test]
+        public void RadiansToDegrees()
+        {
+            var degrees = _astroMath.RadiansToDegrees(1.5707963267948966);
+            Assert.That(degrees, Is.EqualTo(90));
+        }
+
+
+        [Test]
+        public void DateTimeToDecimalHours_book()
+        {
+            DateTime dateTime = new DateTime(2019, 05, 18, 18, 31, 27, DateTimeKind.Utc);
+            var decimalHours = _astroMath.DateTimeToDecimalHours(dateTime);
+
+            Assert.That(decimalHours, Is.EqualTo(18.524166666666666));
+        }
+
+        [Test]
+        public void DateTimeToDecimalHours()
+        {
+            DateTime dateTime = new DateTime(2019, 05, 18, 22, 26, 15, DateTimeKind.Utc);
+            var decimalHours = _astroMath.DateTimeToDecimalHours(dateTime);
+
+            Assert.That(decimalHours, Is.EqualTo(22.4375));
+        }
+
+        [Test]
+        public void UTtoGST_book()
+        {
+            DateTime dateTime = new DateTime(1980, 04, 22, 14, 36, 51, 670, DateTimeKind.Utc);
+            double gst = _astroMath.UTtoGST(dateTime);
+
+            Assert.That(gst, Is.EqualTo(4.667932706211154));
+        }
+
+        [Test]
+        public void UTtoGST()
+        {
+            DateTime dateTime = new DateTime(2019, 05, 18, 22, 26, 15, DateTimeKind.Utc);
+            double gst = _astroMath.UTtoGST(dateTime);
+
+            Assert.That(gst, Is.EqualTo(14.191879687876451));
+        }
+
+        [Test]
+        public void GSTtoLST_book()
+        {
+            double gst = 4.668119;
+            var longitude = -64;
+            var lst = _astroMath.GSTtoLST(gst, longitude);
+            Assert.That(lst, Is.EqualTo(0.4014523333333333));
+        }
+
+        [Test]
+        public void GSTtoLST()
+        {
+            double gst = 14.257589512545053;
+            var longitude = -1.7833333333333332;
+            var lst = _astroMath.GSTtoLST(gst, longitude);
+            Assert.That(lst, Is.EqualTo(14.138700623656163));
+        }
+
+        [Test]
+        public void RightAscensionToHourAngle_book()
+        {
+            DateTime dateTime = new DateTime(1980, 04, 22, 18, 36, 51,670, DateTimeKind.Utc);
+            var longitude = -64;
+            var rightAscension = 18.539166666666667;//18:32'21"
+
+            //var declination = 30.0019444444444
+            var hourAngle = _astroMath.RightAscensionToHourAngle(dateTime, longitude, rightAscension);
+            Assert.That(hourAngle, Is.EqualTo(9.8730510088778161));
+        }
+
+        [Test]
+        public void RightAscensionToHourAngle()
+        {
+            DateTime dateTime = new DateTime(2019, 05, 18, 22, 26, 15, DateTimeKind.Utc);
+            var longitude = -1.7833333333333332;
+            var rightAscension = 4.15361111111111;
+
+            var hourAngle = _astroMath.RightAscensionToHourAngle(dateTime, longitude, rightAscension);
+            Assert.That(hourAngle, Is.EqualTo(9.9193796878764502));
+        }
+
+
+        [Test]
+        public void ConvertEqToHoz_book()
+        {
+            DateTime dateTime = new DateTime(2019, 05, 18, 22, 26, 15, DateTimeKind.Utc);
+            var longitude = -1.7833333333333332;
+            var latitude = 52.0;
+
+            EquatorialCoordinates equatorialCoordinates = new EquatorialCoordinates();
+            equatorialCoordinates.RightAscension = 5.862222222222222;//5 51' 44"
+            equatorialCoordinates.Declination = 23.21944444444444;//23 13' 10"
+
+            //var hourAngle = _astroMath.RightAscensionToHourAngle(dateTime, longitude, equatorialCoordinates.RightAscension);
+            var hourAngle = 5.682222;
+
+            var altAz = _astroMath.ConvertEqToHoz(hourAngle, latitude, equatorialCoordinates);
+
+            Assert.That(altAz.Altitude, Is.EqualTo(20.958562421092779));
+            Assert.That(altAz.Azimuth, Is.EqualTo(281.2728706962269));
+        }
+
+        [Test]
+        public void ConvertEqToHoz()
+        {
+            DateTime dateTime = new DateTime(2019, 05, 18, 22, 26, 15, DateTimeKind.Utc);
+            var longitude = -1.7833333333333332;
+            var latitude = 52.0;
+            EquatorialCoordinates equatorialCoordinates = new EquatorialCoordinates();
+            equatorialCoordinates.RightAscension = 4.15361111111111;
+            equatorialCoordinates.Declination = 30.0019444444444;
+
+            var hourAngle = _astroMath.RightAscensionToHourAngle(dateTime, longitude, equatorialCoordinates.RightAscension);
+            var altaz = _astroMath.ConvertEqToHoz(hourAngle, latitude, equatorialCoordinates);
+
+            Assert.That(altaz.Altitude, Is.EqualTo(-3.5534402923925872));
+            Assert.That(altaz.Azimuth, Is.EqualTo(333.2819484462679));
+        }
+
+    }
+}
@@ -0,0 +1,36 @@
+using System.Reflection;
+using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
+
+// General Information about an assembly is controlled through the following
+// set of attributes. Change these attribute values to modify the information
+// associated with an assembly.
+[assembly: AssemblyTitle("AstroMath.UnitTests")]
+[assembly: AssemblyDescription("")]
+[assembly: AssemblyConfiguration("")]
+[assembly: AssemblyCompany("")]
+[assembly: AssemblyProduct("AstroMath.UnitTests")]
+[assembly: AssemblyCopyright("Copyright ©  2019")]
+[assembly: AssemblyTrademark("")]
+[assembly: AssemblyCulture("")]
+
+// Setting ComVisible to false makes the types in this assembly not visible
+// to COM components.  If you need to access a type in this assembly from
+// COM, set the ComVisible attribute to true on that type.
+[assembly: ComVisible(false)]
+
+// The following GUID is for the ID of the typelib if this project is exposed to COM
+[assembly: Guid("ad4959dd-33d7-4c3f-8db0-7361d8e74a95")]
+
+// Version information for an assembly consists of the following four values:
+//
+//      Major Version
+//      Minor Version
+//      Build Number
+//      Revision
+//
+// You can specify all the values or you can default the Build and Revision Numbers
+// by using the '*' as shown below:
+// [assembly: AssemblyVersion("1.0.*")]
+[assembly: AssemblyVersion("1.0.0.0")]
+[assembly: AssemblyFileVersion("1.0.0.0")]
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="Castle.Core" version="4.3.1" targetFramework="net472" />
+  <package id="Moq" version="4.10.1" targetFramework="net472" />
+  <package id="NUnit" version="3.12.0" targetFramework="net472" />
+  <package id="System.Runtime.CompilerServices.Unsafe" version="4.5.0" targetFramework="net472" />
+  <package id="System.Threading.Tasks.Extensions" version="4.5.1" targetFramework="net472" />
+</packages>