Astronomy/MeadeGeneric
1
0
Fork 0
Code Pull Requests Wiki Activity

code inspections

Browse Source
This commit is contained in:
Colin Dawson
2019-09-29 22:24:58 +01:00
parent 07bf72a8c3
commit 19f831695d
1 changed files with 38 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Meade.net/AssemblyInfo.cs
+38 -38
View File
@@ -8,17 +8,17 @@ namespace ASCOM.Meade.net
public class AssemblyInfo public class AssemblyInfo
{ {
// The assembly information values. // The assembly information values.
public string Title = string.Empty; //public readonly string Title = string.Empty;
public string Description = string.Empty; //public readonly string Description = string.Empty;
public string Company = string.Empty; //public readonly string Company = string.Empty;
public string Product = string.Empty; public readonly string Product = string.Empty;
public string Copyright = string.Empty; //public readonly string Copyright = string.Empty;
public string Trademark = string.Empty; //public readonly string Trademark = string.Empty;
public string AssemblyVersion; public readonly string AssemblyVersion;
public string FileVersion = string.Empty; //public readonly string FileVersion = string.Empty;
public string Guid = string.Empty; //public readonly string Guid = string.Empty;
public string NeutralLanguage = string.Empty; //public readonly string NeutralLanguage = string.Empty;
public bool IsComVisible; //public readonly bool IsComVisible;
// Return a particular assembly attribute value. // Return a particular assembly attribute value.
public static T GetAssemblyAttribute<T>(Assembly assembly) public static T GetAssemblyAttribute<T>(Assembly assembly)
@@ -45,49 +45,49 @@ namespace ASCOM.Meade.net
public AssemblyInfo(Assembly assembly) public AssemblyInfo(Assembly assembly)
{ {
// Get values from the assembly. // Get values from the assembly.
var titleAttr = GetAssemblyAttribute<AssemblyTitleAttribute>(assembly); //var titleAttr = GetAssemblyAttribute<AssemblyTitleAttribute>(assembly);
if (titleAttr != null) //if (titleAttr != null)
Title = titleAttr.Title; // Title = titleAttr.Title;
var assemblyAttr = GetAssemblyAttribute<AssemblyDescriptionAttribute>(assembly); //var assemblyAttr = GetAssemblyAttribute<AssemblyDescriptionAttribute>(assembly);
if (assemblyAttr != null) //if (assemblyAttr != null)
Description = assemblyAttr.Description; // Description = assemblyAttr.Description;
var companyAttr =GetAssemblyAttribute<AssemblyCompanyAttribute>(assembly); //var companyAttr =GetAssemblyAttribute<AssemblyCompanyAttribute>(assembly);
if (companyAttr != null) //if (companyAttr != null)
Company = companyAttr.Company; // Company = companyAttr.Company;
var productAttr = GetAssemblyAttribute<AssemblyProductAttribute>(assembly); var productAttr = GetAssemblyAttribute<AssemblyProductAttribute>(assembly);
if (productAttr != null) if (productAttr != null)
Product = productAttr.Product; Product = productAttr.Product;
var copyrightAttr = GetAssemblyAttribute<AssemblyCopyrightAttribute>(assembly); //var copyrightAttr = GetAssemblyAttribute<AssemblyCopyrightAttribute>(assembly);
if (copyrightAttr != null) //if (copyrightAttr != null)
Copyright = copyrightAttr.Copyright; // Copyright = copyrightAttr.Copyright;
var trademarkAttr = GetAssemblyAttribute<AssemblyTrademarkAttribute>(assembly); //var trademarkAttr = GetAssemblyAttribute<AssemblyTrademarkAttribute>(assembly);
if (trademarkAttr != null) //if (trademarkAttr != null)
Trademark = trademarkAttr.Trademark; // Trademark = trademarkAttr.Trademark;
var version = assembly.GetName().Version; var version = assembly.GetName().Version;
AssemblyVersion = $"{version.Major}.{version.Minor}.{version.Build}.{version.Revision}"; AssemblyVersion = $"{version.Major}.{version.Minor}.{version.Build}.{version.Revision}";
var fileVersionAttr = GetAssemblyAttribute<AssemblyFileVersionAttribute>(assembly); //var fileVersionAttr = GetAssemblyAttribute<AssemblyFileVersionAttribute>(assembly);
if (fileVersionAttr != null) FileVersion = //if (fileVersionAttr != null) FileVersion =
fileVersionAttr.Version; // fileVersionAttr.Version;
var guidAttr = GetAssemblyAttribute<GuidAttribute>(assembly); //var guidAttr = GetAssemblyAttribute<GuidAttribute>(assembly);
if (guidAttr != null) //if (guidAttr != null)
Guid = guidAttr.Value; // Guid = guidAttr.Value;
var languageAttr = GetAssemblyAttribute<NeutralResourcesLanguageAttribute>(assembly); //var languageAttr = GetAssemblyAttribute<NeutralResourcesLanguageAttribute>(assembly);
if (languageAttr != null) //if (languageAttr != null)
NeutralLanguage = languageAttr.CultureName; // NeutralLanguage = languageAttr.CultureName;
var comAttr = GetAssemblyAttribute<ComVisibleAttribute>(assembly); //var comAttr = GetAssemblyAttribute<ComVisibleAttribute>(assembly);
if (comAttr != null) //if (comAttr != null)
IsComVisible = comAttr.Value; // IsComVisible = comAttr.Value;
} }
} }
} }