From 19f831695de375ec12deed8bc0c8fc75557f4ff2 Mon Sep 17 00:00:00 2001 From: Colin Date: Sun, 29 Sep 2019 22:24:58 +0100 Subject: [PATCH] code inspections --- Meade.net/AssemblyInfo.cs | 76 +++++++++++++++++++-------------------- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/Meade.net/AssemblyInfo.cs b/Meade.net/AssemblyInfo.cs index 74aba9f..01c86bf 100644 --- a/Meade.net/AssemblyInfo.cs +++ b/Meade.net/AssemblyInfo.cs @@ -8,17 +8,17 @@ namespace ASCOM.Meade.net public class AssemblyInfo { // The assembly information values. - public string Title = string.Empty; - public string Description = string.Empty; - public string Company = string.Empty; - public string Product = string.Empty; - public string Copyright = string.Empty; - public string Trademark = string.Empty; - public string AssemblyVersion; - public string FileVersion = string.Empty; - public string Guid = string.Empty; - public string NeutralLanguage = string.Empty; - public bool IsComVisible; + //public readonly string Title = string.Empty; + //public readonly string Description = string.Empty; + //public readonly string Company = string.Empty; + public readonly string Product = string.Empty; + //public readonly string Copyright = string.Empty; + //public readonly string Trademark = string.Empty; + public readonly string AssemblyVersion; + //public readonly string FileVersion = string.Empty; + //public readonly string Guid = string.Empty; + //public readonly string NeutralLanguage = string.Empty; + //public readonly bool IsComVisible; // Return a particular assembly attribute value. public static T GetAssemblyAttribute(Assembly assembly) @@ -45,49 +45,49 @@ namespace ASCOM.Meade.net public AssemblyInfo(Assembly assembly) { // Get values from the assembly. - var titleAttr = GetAssemblyAttribute(assembly); - if (titleAttr != null) - Title = titleAttr.Title; + //var titleAttr = GetAssemblyAttribute(assembly); + //if (titleAttr != null) + // Title = titleAttr.Title; - var assemblyAttr = GetAssemblyAttribute(assembly); - if (assemblyAttr != null) - Description = assemblyAttr.Description; + //var assemblyAttr = GetAssemblyAttribute(assembly); + //if (assemblyAttr != null) + // Description = assemblyAttr.Description; - var companyAttr =GetAssemblyAttribute(assembly); - if (companyAttr != null) - Company = companyAttr.Company; + //var companyAttr =GetAssemblyAttribute(assembly); + //if (companyAttr != null) + // Company = companyAttr.Company; var productAttr = GetAssemblyAttribute(assembly); if (productAttr != null) Product = productAttr.Product; - var copyrightAttr = GetAssemblyAttribute(assembly); - if (copyrightAttr != null) - Copyright = copyrightAttr.Copyright; + //var copyrightAttr = GetAssemblyAttribute(assembly); + //if (copyrightAttr != null) + // Copyright = copyrightAttr.Copyright; - var trademarkAttr = GetAssemblyAttribute(assembly); - if (trademarkAttr != null) - Trademark = trademarkAttr.Trademark; + //var trademarkAttr = GetAssemblyAttribute(assembly); + //if (trademarkAttr != null) + // Trademark = trademarkAttr.Trademark; var version = assembly.GetName().Version; AssemblyVersion = $"{version.Major}.{version.Minor}.{version.Build}.{version.Revision}"; - var fileVersionAttr = GetAssemblyAttribute(assembly); - if (fileVersionAttr != null) FileVersion = - fileVersionAttr.Version; + //var fileVersionAttr = GetAssemblyAttribute(assembly); + //if (fileVersionAttr != null) FileVersion = + // fileVersionAttr.Version; - var guidAttr = GetAssemblyAttribute(assembly); - if (guidAttr != null) - Guid = guidAttr.Value; + //var guidAttr = GetAssemblyAttribute(assembly); + //if (guidAttr != null) + // Guid = guidAttr.Value; - var languageAttr = GetAssemblyAttribute(assembly); - if (languageAttr != null) - NeutralLanguage = languageAttr.CultureName; + //var languageAttr = GetAssemblyAttribute(assembly); + //if (languageAttr != null) + // NeutralLanguage = languageAttr.CultureName; - var comAttr = GetAssemblyAttribute(assembly); - if (comAttr != null) - IsComVisible = comAttr.Value; + //var comAttr = GetAssemblyAttribute(assembly); + //if (comAttr != null) + // IsComVisible = comAttr.Value; } } }