From e9d41a24121163af85906559a87df4d2f7ceb90b Mon Sep 17 00:00:00 2001 From: Colin Date: Tue, 23 Jul 2019 10:32:18 +0100 Subject: [PATCH] Moved the code that reports the driver version to the end of the initialisation. --- Meade.net.Telescope.UnitTests/TelescopeUnitTests.cs | 2 +- Meade.net.Telescope/Telescope.cs | 4 +--- Meade.net.focuser/Focuser.cs | 4 +--- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/Meade.net.Telescope.UnitTests/TelescopeUnitTests.cs b/Meade.net.Telescope.UnitTests/TelescopeUnitTests.cs index 198673b..32645d3 100644 --- a/Meade.net.Telescope.UnitTests/TelescopeUnitTests.cs +++ b/Meade.net.Telescope.UnitTests/TelescopeUnitTests.cs @@ -201,7 +201,7 @@ namespace Meade.net.Telescope.UnitTests [TestCase("1", ":SMHome#", "Home")] [TestCase("2", ":SNClub#", "Club")] - [TestCase("3", ":SOGPS#", "GPS")] + [TestCase("3", ":SOGPS Site#", "GPS Site")] [TestCase("4", ":SPParents#", "Parents")] public void Action_Site_SetName_WhenCallingWithValidValues_ThenSelectsCorrectSite(string site, string telescopeCommand, string siteName) { diff --git a/Meade.net.Telescope/Telescope.cs b/Meade.net.Telescope/Telescope.cs index 6fac6ed..600ef4e 100644 --- a/Meade.net.Telescope/Telescope.cs +++ b/Meade.net.Telescope/Telescope.cs @@ -105,14 +105,12 @@ namespace ASCOM.Meade.net { //todo move the TraceLogger out to a factory class. _tl = new TraceLogger("", "Meade.Generic.Telescope"); - LogMessage("Telescope", "Starting initialisation"); - LogMessage("Telescope", $"Driver version: {DriverVersion}"); - ReadProfile(); // Read device configuration from the ASCOM Profile store IsConnected = false; // Initialise connected to false LogMessage("Telescope", "Completed initialisation"); + LogMessage("Telescope", $"Driver version: {DriverVersion}"); } diff --git a/Meade.net.focuser/Focuser.cs b/Meade.net.focuser/Focuser.cs index eb3eae2..2e80def 100644 --- a/Meade.net.focuser/Focuser.cs +++ b/Meade.net.focuser/Focuser.cs @@ -77,14 +77,12 @@ namespace ASCOM.Meade.net //todo move the TraceLogger out to a factory class. Tl = new TraceLogger("", "Meade.Generic.focusser"); - LogMessage("Focuser", "Starting initialisation"); - LogMessage("Focuser", $"Driver version: {DriverVersion}"); - ReadProfile(); // Read device configuration from the ASCOM Profile store IsConnected = false; // Initialise connected to false LogMessage("Focuser", "Completed initialisation"); + LogMessage("Focuser", $"Driver version: {DriverVersion}"); }