Added support for SlewSettleTime

Meade.net.Telescope.UnitTests/TelescopeUnitTests.cs

@@ -1633,25 +1633,55 @@ namespace Meade.net.Telescope.UnitTests
         }
 
         [Test]
-        public void SlewSettleTime_Get_ThenThrowsException()
+        public void SlewSettleTime_Get_WhenNotConnected_ThenThrowsException()
         {
-            var excpetion = Assert.Throws<PropertyNotImplementedException>(() =>
+            var exception = Assert.Throws<NotConnectedException>(() =>
             {
                 var result = _telescope.SlewSettleTime;
                 Assert.Fail($"{result} should not have returned");
             });
-
+            Assert.That(exception.Message, Is.EqualTo("Not connected to telescope when trying to execute: SlewSettleTime Get"));
-            Assert.That(excpetion.Property, Is.EqualTo("SlewSettleTime"));
-            Assert.That(excpetion.AccessorSet, Is.False);
         }
 
         [Test]
-        public void SlewSettleTime_Set_ThenThrowsException()
+        public void SlewSettleTime_Set_WhenNotConnected_ThenThrowsException()
         {
-            var excpetion = Assert.Throws<PropertyNotImplementedException>(() => { _telescope.SlewSettleTime = 0; });
+            var exception = Assert.Throws<NotConnectedException>(() =>
+            {
+                _telescope.SlewSettleTime = 13;
+                Assert.Fail($"should not have returned");
+            });
+            Assert.That(exception.Message, Is.EqualTo("Not connected to telescope when trying to execute: SlewSettleTime Set"));
+        }
 
-            Assert.That(excpetion.Property, Is.EqualTo("SlewSettleTime"));
+        [TestCase(5)]
-            Assert.That(excpetion.AccessorSet, Is.True);
+        [TestCase(10)]
+        [TestCase(2)]
+        public void SlewSettleTime_Get_ReturnsExpectedValue(short settleTime)
+        {
+            _profileProperties.SettleTime = settleTime;
+
+            ConnectTelescope();
+
+            var result = _telescope.SlewSettleTime;
+
+            Assert.That(result, Is.EqualTo(settleTime));
+        }
+
+        [TestCase(8)]
+        [TestCase(12)]
+        [TestCase(3)]
+        public void SlewSettleTime_Set_ThenReturnsNewSettleTime(short settleTime)
+        {
+            _profileProperties.SettleTime = 0;
+
+            ConnectTelescope();
+
+            _telescope.SlewSettleTime = settleTime;
+
+            var result = _telescope.SlewSettleTime;
+
+            Assert.That(result, Is.EqualTo(settleTime));
         }
 
         [Test]

Meade.net.Telescope/Telescope.cs

@@ -1774,14 +1774,16 @@ namespace ASCOM.Meade.net
         {
             get
             {
-                LogMessage("SlewSettleTime Get", "Not implemented");
+                CheckConnected("SlewSettleTime Get");
-                throw new PropertyNotImplementedException("SlewSettleTime", false);
+                LogMessage("SlewSettleTime Get", $"{SettleTime} Seconds");
+                return SettleTime;
             }
             // ReSharper disable once ValueParameterNotUsed
             set
             {
-                LogMessage("SlewSettleTime Set", "Not implemented");
+                CheckConnected("SlewSettleTime Set");
-                throw new PropertyNotImplementedException("SlewSettleTime", true);
+                LogMessage("SlewSettleTime Set", $"Setting from {SettleTime} to {value}");
+                SettleTime = value;
             }
         }
 

Meade.net/MeadeTelescopeBase.cs

@@ -27,6 +27,7 @@ namespace ASCOM.Meade.net
         protected string Precision;
         protected string GuidingStyle;
         protected double SiteElevation;
+        protected short SettleTime;
 
         protected readonly ISharedResourcesWrapper SharedResourcesWrapper;
 
@@ -67,6 +68,7 @@ namespace ASCOM.Meade.net
             Precision = profileProperties.Precision;
             GuidingStyle = profileProperties.GuidingStyle.ToLower();
             SiteElevation = profileProperties.SiteElevation;
+            SettleTime = profileProperties.SettleTime;
 
             LogMessage("ReadProfile", $"Trace logger enabled: {Tl.Enabled}");
             LogMessage("ReadProfile", $"Com Port: {ComPort}");
@@ -76,6 +78,7 @@ namespace ASCOM.Meade.net
             LogMessage("ReadProfile", $"Precision: {Precision}");
             LogMessage("ReadProfile", $"Guiding Style: {GuidingStyle}");
             LogMessage("ReadProfile", $"Site Elevation: {SiteElevation}");
+            LogMessage("ReadProfile", $"Settle Time after slew: {SettleTime}");
         }
 
         /// <summary>

Meade.net/ProfileProperties.cs

@@ -13,5 +13,6 @@ namespace ASCOM.Meade.net
         public bool DynamicBreaking { get; set; }
         public bool RtsDtrEnabled { get; set; }
         public double SiteElevation { get; set; }
+        public short SettleTime { get; set; }
     }
 }

Meade.net/SetupDialogForm.cs

@@ -88,6 +88,7 @@ namespace ASCOM.Meade.net
 
             cbxReverseDirection.Checked = profileProperties.ReverseFocusDirection;
             cbxDynamicBreaking.Checked = profileProperties.DynamicBreaking;
+            nudSettleTime.Value = profileProperties.SettleTime;
         }
 
     public ProfileProperties GetProfile()
@@ -103,8 +104,9 @@ namespace ASCOM.Meade.net
                 BacklashCompensation = int.Parse(txtBacklashSteps.Text),
                 ReverseFocusDirection = cbxReverseDirection.Checked,
                 DynamicBreaking = cbxDynamicBreaking.Checked,
-                SiteElevation = double.Parse(txtElevation.Text)
+                SiteElevation = double.Parse(txtElevation.Text),
-            };
+                SettleTime = Convert.ToInt16(nudSettleTime.Value)
+        };
 
             return profileProperties;
         }

Meade.net/SetupDialogForm.designer.cs

@@ -61,7 +61,11 @@ namespace ASCOM.Meade.net
             this.label12 = new System.Windows.Forms.Label();
             this.txtElevation = new System.Windows.Forms.TextBox();
             this.label13 = new System.Windows.Forms.Label();
+            this.label14 = new System.Windows.Forms.Label();
+            this.nudSettleTime = new System.Windows.Forms.NumericUpDown();
+            this.label15 = new System.Windows.Forms.Label();
             ((System.ComponentModel.ISupportInitialize)(this.picASCOM)).BeginInit();
+            ((System.ComponentModel.ISupportInitialize)(this.nudSettleTime)).BeginInit();
             this.SuspendLayout();
             // 
             // cmdOK
@@ -231,10 +235,33 @@ namespace ASCOM.Meade.net
             resources.ApplyResources(this.label13, "label13");
             this.label13.Name = "label13";
             // 
+            // label14
+            // 
+            resources.ApplyResources(this.label14, "label14");
+            this.label14.Name = "label14";
+            // 
+            // nudSettleTime
+            // 
+            resources.ApplyResources(this.nudSettleTime, "nudSettleTime");
+            this.nudSettleTime.Maximum = new decimal(new int[] {
+            32767,
+            0,
+            0,
+            0});
+            this.nudSettleTime.Name = "nudSettleTime";
+            // 
+            // label15
+            // 
+            resources.ApplyResources(this.label15, "label15");
+            this.label15.Name = "label15";
+            // 
             // SetupDialogForm
             // 
             resources.ApplyResources(this, "$this");
             this.AutoScaleMode = System.Windows.Forms.AutoScaleMode.Font;
+            this.Controls.Add(this.label15);
+            this.Controls.Add(this.nudSettleTime);
+            this.Controls.Add(this.label14);
             this.Controls.Add(this.label13);
             this.Controls.Add(this.txtElevation);
             this.Controls.Add(this.label12);
@@ -270,6 +297,7 @@ namespace ASCOM.Meade.net
             this.TopMost = true;
             this.Shown += new System.EventHandler(this.SetupDialogForm_Shown);
             ((System.ComponentModel.ISupportInitialize)(this.picASCOM)).EndInit();
+            ((System.ComponentModel.ISupportInitialize)(this.nudSettleTime)).EndInit();
             this.ResumeLayout(false);
             this.PerformLayout();
 
@@ -305,5 +333,8 @@ namespace ASCOM.Meade.net
         private Label label12;
         private TextBox txtElevation;
         private Label label13;
+        private Label label14;
+        private NumericUpDown nudSettleTime;
+        private Label label15;
     }
 }

Meade.net/SetupDialogForm.resx

@@ -145,7 +145,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;cmdOK.ZOrder" xml:space="preserve">
-    <value>26</value>
+    <value>29</value>
   </data>
   <data name="cmdCancel.Anchor" type="System.Windows.Forms.AnchorStyles, System.Windows.Forms">
     <value>Bottom, Right</value>
@@ -172,7 +172,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;cmdCancel.ZOrder" xml:space="preserve">
-    <value>25</value>
+    <value>28</value>
   </data>
   <data name="label1.Location" type="System.Drawing.Point, System.Drawing">
     <value>12, 9</value>
@@ -196,7 +196,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;label1.ZOrder" xml:space="preserve">
-    <value>24</value>
+    <value>27</value>
   </data>
   <data name="picASCOM.Anchor" type="System.Windows.Forms.AnchorStyles, System.Windows.Forms">
     <value>Top, Right</value>
@@ -223,7 +223,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;picASCOM.ZOrder" xml:space="preserve">
-    <value>23</value>
+    <value>26</value>
   </data>
   <data name="label2.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -250,7 +250,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;label2.ZOrder" xml:space="preserve">
-    <value>22</value>
+    <value>25</value>
   </data>
   <data name="chkTrace.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -277,7 +277,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;chkTrace.ZOrder" xml:space="preserve">
-    <value>21</value>
+    <value>24</value>
   </data>
   <data name="comboBoxComPort.Location" type="System.Drawing.Point, System.Drawing">
     <value>97, 87</value>
@@ -298,7 +298,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;comboBoxComPort.ZOrder" xml:space="preserve">
-    <value>20</value>
+    <value>23</value>
   </data>
   <data name="label3.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -325,7 +325,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;label3.ZOrder" xml:space="preserve">
-    <value>19</value>
+    <value>22</value>
   </data>
   <data name="txtGuideRate.Location" type="System.Drawing.Point, System.Drawing">
     <value>97, 275</value>
@@ -349,7 +349,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;txtGuideRate.ZOrder" xml:space="preserve">
-    <value>18</value>
+    <value>21</value>
   </data>
   <data name="label4.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -376,7 +376,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;label4.ZOrder" xml:space="preserve">
-    <value>17</value>
+    <value>20</value>
   </data>
   <data name="lblPercentOfSiderealRate.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -403,7 +403,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;lblPercentOfSiderealRate.ZOrder" xml:space="preserve">
-    <value>16</value>
+    <value>19</value>
   </data>
   <data name="label5.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -430,7 +430,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;label5.ZOrder" xml:space="preserve">
-    <value>15</value>
+    <value>18</value>
   </data>
   <data name="cboPrecision.Items" xml:space="preserve">
     <value>Unchanged</value>
@@ -460,7 +460,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;cboPrecision.ZOrder" xml:space="preserve">
-    <value>14</value>
+    <value>17</value>
   </data>
   <data name="label6.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -490,7 +490,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;label6.ZOrder" xml:space="preserve">
-    <value>13</value>
+    <value>16</value>
   </data>
   <data name="cboGuidingStyle.Items" xml:space="preserve">
     <value>Auto</value>
@@ -520,7 +520,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;cboGuidingStyle.ZOrder" xml:space="preserve">
-    <value>12</value>
+    <value>15</value>
   </data>
   <data name="label7.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -550,7 +550,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;label7.ZOrder" xml:space="preserve">
-    <value>11</value>
+    <value>14</value>
   </data>
   <data name="label8.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -583,7 +583,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;label8.ZOrder" xml:space="preserve">
-    <value>10</value>
+    <value>13</value>
   </data>
   <data name="txtBacklashSteps.Location" type="System.Drawing.Point, System.Drawing">
     <value>97, 411</value>
@@ -607,7 +607,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;txtBacklashSteps.ZOrder" xml:space="preserve">
-    <value>8</value>
+    <value>11</value>
   </data>
   <data name="label9.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -637,7 +637,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;label9.ZOrder" xml:space="preserve">
-    <value>9</value>
+    <value>12</value>
   </data>
   <data name="label10.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -667,7 +667,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;label10.ZOrder" xml:space="preserve">
-    <value>7</value>
+    <value>10</value>
   </data>
   <data name="label11.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -700,7 +700,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;label11.ZOrder" xml:space="preserve">
-    <value>6</value>
+    <value>9</value>
   </data>
   <data name="cbxReverseDirection.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -727,7 +727,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;cbxReverseDirection.ZOrder" xml:space="preserve">
-    <value>5</value>
+    <value>8</value>
   </data>
   <data name="cbxDynamicBreaking.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -754,7 +754,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;cbxDynamicBreaking.ZOrder" xml:space="preserve">
-    <value>4</value>
+    <value>7</value>
   </data>
   <metadata name="toolTip1.TrayLocation" type="System.Drawing.Point, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
     <value>17, 17</value>
@@ -790,7 +790,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;cbxRtsDtr.ZOrder" xml:space="preserve">
-    <value>3</value>
+    <value>6</value>
   </data>
   <metadata name="toolTip1.TrayLocation" type="System.Drawing.Point, System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
     <value>17, 17</value>
@@ -820,7 +820,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;label12.ZOrder" xml:space="preserve">
-    <value>2</value>
+    <value>5</value>
   </data>
   <data name="txtElevation.Location" type="System.Drawing.Point, System.Drawing">
     <value>97, 202</value>
@@ -841,7 +841,7 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;txtElevation.ZOrder" xml:space="preserve">
-    <value>1</value>
+    <value>4</value>
   </data>
   <data name="label13.AutoSize" type="System.Boolean, mscorlib">
     <value>True</value>
@@ -868,6 +868,81 @@
     <value>$this</value>
   </data>
   <data name="&gt;&gt;label13.ZOrder" xml:space="preserve">
+    <value>3</value>
+  </data>
+  <data name="label14.AutoSize" type="System.Boolean, mscorlib">
+    <value>True</value>
+  </data>
+  <data name="label14.Location" type="System.Drawing.Point, System.Drawing">
+    <value>12, 236</value>
+  </data>
+  <data name="label14.Size" type="System.Drawing.Size, System.Drawing">
+    <value>56, 13</value>
+  </data>
+  <data name="label14.TabIndex" type="System.Int32, mscorlib">
+    <value>25</value>
+  </data>
+  <data name="label14.Text" xml:space="preserve">
+    <value>Settle time</value>
+  </data>
+  <data name="&gt;&gt;label14.Name" xml:space="preserve">
+    <value>label14</value>
+  </data>
+  <data name="&gt;&gt;label14.Type" xml:space="preserve">
+    <value>System.Windows.Forms.Label, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+  </data>
+  <data name="&gt;&gt;label14.Parent" xml:space="preserve">
+    <value>$this</value>
+  </data>
+  <data name="&gt;&gt;label14.ZOrder" xml:space="preserve">
+    <value>2</value>
+  </data>
+  <data name="nudSettleTime.Location" type="System.Drawing.Point, System.Drawing">
+    <value>97, 234</value>
+  </data>
+  <data name="nudSettleTime.Size" type="System.Drawing.Size, System.Drawing">
+    <value>120, 20</value>
+  </data>
+  <data name="nudSettleTime.TabIndex" type="System.Int32, mscorlib">
+    <value>26</value>
+  </data>
+  <data name="&gt;&gt;nudSettleTime.Name" xml:space="preserve">
+    <value>nudSettleTime</value>
+  </data>
+  <data name="&gt;&gt;nudSettleTime.Type" xml:space="preserve">
+    <value>System.Windows.Forms.NumericUpDown, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+  </data>
+  <data name="&gt;&gt;nudSettleTime.Parent" xml:space="preserve">
+    <value>$this</value>
+  </data>
+  <data name="&gt;&gt;nudSettleTime.ZOrder" xml:space="preserve">
+    <value>1</value>
+  </data>
+  <data name="label15.AutoSize" type="System.Boolean, mscorlib">
+    <value>True</value>
+  </data>
+  <data name="label15.Location" type="System.Drawing.Point, System.Drawing">
+    <value>223, 236</value>
+  </data>
+  <data name="label15.Size" type="System.Drawing.Size, System.Drawing">
+    <value>47, 13</value>
+  </data>
+  <data name="label15.TabIndex" type="System.Int32, mscorlib">
+    <value>27</value>
+  </data>
+  <data name="label15.Text" xml:space="preserve">
+    <value>seconds</value>
+  </data>
+  <data name="&gt;&gt;label15.Name" xml:space="preserve">
+    <value>label15</value>
+  </data>
+  <data name="&gt;&gt;label15.Type" xml:space="preserve">
+    <value>System.Windows.Forms.Label, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+  </data>
+  <data name="&gt;&gt;label15.Parent" xml:space="preserve">
+    <value>$this</value>
+  </data>
+  <data name="&gt;&gt;label15.ZOrder" xml:space="preserve">
     <value>0</value>
   </data>
   <metadata name="$this.Localizable" type="System.Boolean, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089">

Meade.net/SharedResources.cs

@@ -146,6 +146,7 @@ namespace ASCOM.Meade.net
         private const string ReverseFocusDirectionName = "Reverse Focuser Direction";
         private const string DynamicBreakingName = "Dynamic Breaking";
         private const string SiteElevationName = "Site Elevation";
+        private const string SettleTimeName = "Settle Time";
 
         public static void WriteProfile(ProfileProperties profileProperties)
         {
@@ -164,6 +165,7 @@ namespace ASCOM.Meade.net
                     driverProfile.WriteValue(DriverId, ReverseFocusDirectionName, profileProperties.ReverseFocusDirection.ToString());
                     driverProfile.WriteValue(DriverId, DynamicBreakingName, profileProperties.DynamicBreaking.ToString());
                     driverProfile.WriteValue(DriverId, SiteElevationName, profileProperties.SiteElevation.ToString());
+                    driverProfile.WriteValue(DriverId, SettleTimeName, profileProperties.SettleTime.ToString());
                 }
             }
         }
@@ -178,6 +180,7 @@ namespace ASCOM.Meade.net
         private const string ReverseFocuserDiectionDefault = "true";
         private const string DynamicBreakingDefault = "true";
         private const string SiteElevationDefault = "0";
+        private const string SettleTimeDefault = "2";
 
         public static ProfileProperties ReadProfile()
         {
@@ -197,6 +200,7 @@ namespace ASCOM.Meade.net
                     profileProperties.ReverseFocusDirection = Convert.ToBoolean(driverProfile.GetValue(DriverId, ReverseFocusDirectionName, string.Empty, ReverseFocuserDiectionDefault));
                     profileProperties.DynamicBreaking = Convert.ToBoolean(driverProfile.GetValue(DriverId, DynamicBreakingName, string.Empty, DynamicBreakingDefault));
                     profileProperties.SiteElevation = Convert.ToInt32(driverProfile.GetValue(DriverId, SiteElevationName, string.Empty, SiteElevationDefault));
+                    profileProperties.SettleTime = Convert.ToInt16(driverProfile.GetValue(DriverId, SettleTimeName, string.Empty, SettleTimeDefault));
                 }
 
                 return profileProperties;