From cdf1066e4e09e67dbda6800d973df119b77fabc9 Mon Sep 17 00:00:00 2001 From: Colin Date: Tue, 2 Mar 2021 12:54:47 +0000 Subject: [PATCH] Fixed a few more code inspections --- Meade.net.Telescope/Telescope.cs | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/Meade.net.Telescope/Telescope.cs b/Meade.net.Telescope/Telescope.cs index 167d64a..d0ebdd7 100644 --- a/Meade.net.Telescope/Telescope.cs +++ b/Meade.net.Telescope/Telescope.cs @@ -2048,6 +2048,7 @@ namespace ASCOM.Meade.net { if (string.IsNullOrEmpty(result)) { + // ReSharper disable once RedundantAssignment isSlewing = false; return isSlewing; } @@ -2167,8 +2168,7 @@ namespace ASCOM.Meade.net if (value < -90) throw new InvalidValueException("Declination cannot be less than -90."); - var dms = ""; - dms = IsLongFormat ? + var dms = IsLongFormat ? _utilities.DegreesToDMS(value, "*", ":", ":", _digitsDe) : _utilities.DegreesToDM(value, "*", "", _digitsDe); @@ -2223,12 +2223,9 @@ namespace ASCOM.Meade.net if (value >= 24) throw new InvalidValueException("Right ascension value cannot be greater than 23:59:59"); - var hms = ""; - if(IsLongFormat) - hms = _utilities.HoursToHMS(value, ":", ":", ":", _digitsRa); - else - //meade protocol defines H:MM.T format - hms = _utilities.HoursToHM(value, ":", "", _digitsRa).Replace(',','.'); + var hms = IsLongFormat ? + _utilities.HoursToHMS(value, ":", ":", ":", _digitsRa) : + _utilities.HoursToHM(value, ":", "", _digitsRa).Replace(',','.'); var command = $":Sr{hms}#"; LogMessage("TargetRightAscension Set", $"{command}");