From 7905da9651ebb01da34e87488f243219dd3fa575 Mon Sep 17 00:00:00 2001
From: Colin <me@cjdawson.com>
Date: Sun, 29 Sep 2019 20:22:42 +0100
Subject: [PATCH] Code inspections

---
 Meade.net/Properties/Resources.Designer.cs | 28 ++++++++++++++++++++++
 Meade.net/Properties/Resources.resx        |  9 +++++++
 Meade.net/SetupDialogForm.cs               |  5 ++--
 Meade.net/SharedResources.cs               |  3 ++-
 4 files changed, 42 insertions(+), 3 deletions(-)

diff --git a/Meade.net/Properties/Resources.Designer.cs b/Meade.net/Properties/Resources.Designer.cs
index 29dff78..e6ab0a3 100644
--- a/Meade.net/Properties/Resources.Designer.cs
+++ b/Meade.net/Properties/Resources.Designer.cs
@@ -117,5 +117,33 @@ namespace ASCOM.Meade.net.Properties {
                 return ResourceManager.GetString("Server_RegisterObjects_", resourceCulture);
             }
         }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to {0} Settings ({1}).
+        /// </summary>
+        internal static string SetupDialogForm_SetupDialogForm__0__Settings___1__ {
+            get {
+                return ResourceManager.GetString("SetupDialogForm_SetupDialogForm__0__Settings___1__", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to ({0:00.0}% of sidereal rate).
+        /// </summary>
+        internal static string SetupDialogForm_TextBox1_TextChanged___0_00_0___of_sidereal_rate_ {
+            get {
+                return ResourceManager.GetString("SetupDialogForm_TextBox1_TextChanged___0_00_0___of_sidereal_rate_", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Already connected, please disconnect before altering settings.
+        /// </summary>
+        internal static string SharedResources_SetupDialog_Already_connected__please_disconnect_before_altering_settings {
+            get {
+                return ResourceManager.GetString("SharedResources_SetupDialog_Already_connected__please_disconnect_before_altering_" +
+                        "settings", resourceCulture);
+            }
+        }
     }
 }
diff --git a/Meade.net/Properties/Resources.resx b/Meade.net/Properties/Resources.resx
index eeb7461..705bb79 100644
--- a/Meade.net/Properties/Resources.resx
+++ b/Meade.net/Properties/Resources.resx
@@ -138,4 +138,13 @@ Valid are : -register, -unregister and -embedding</value>
   <data name="Server_LoadComObjectAssemblies_Failed_to_load_served_COM_class_assembly__0_____1_" xml:space="preserve">
     <value>Failed to load served COM class assembly {0} - {1}</value>
   </data>
+  <data name="SharedResources_SetupDialog_Already_connected__please_disconnect_before_altering_settings" xml:space="preserve">
+    <value>Already connected, please disconnect before altering settings</value>
+  </data>
+  <data name="SetupDialogForm_TextBox1_TextChanged___0_00_0___of_sidereal_rate_" xml:space="preserve">
+    <value>({0:00.0}% of sidereal rate)</value>
+  </data>
+  <data name="SetupDialogForm_SetupDialogForm__0__Settings___1__" xml:space="preserve">
+    <value>{0} Settings ({1})</value>
+  </data>
 </root>
\ No newline at end of file
diff --git a/Meade.net/SetupDialogForm.cs b/Meade.net/SetupDialogForm.cs
index e1bb086..4067b83 100644
--- a/Meade.net/SetupDialogForm.cs
+++ b/Meade.net/SetupDialogForm.cs
@@ -5,6 +5,7 @@ using System.Globalization;
 using System.IO.Ports;
 using System.Runtime.InteropServices;
 using System.Windows.Forms;
+using ASCOM.Meade.net.Properties;
 
 namespace ASCOM.Meade.net
 {
@@ -17,7 +18,7 @@ namespace ASCOM.Meade.net
 
             var assemblyInfo = new AssemblyInfo();
 
-            Text = $"{assemblyInfo.Product} Settings ({assemblyInfo.AssemblyVersion})";
+            Text = string.Format(Resources.SetupDialogForm_SetupDialogForm__0__Settings___1__, assemblyInfo.Product, assemblyInfo.AssemblyVersion);
         }
 
         public sealed override string Text
@@ -102,7 +103,7 @@ namespace ASCOM.Meade.net
                 const double siderealArcSecondsPerSecond = 15.041;
                 var percentOfSideReal = newGuideRate / siderealArcSecondsPerSecond * 100;
 
-                lblPercentOfSiderealRate.Text = $"({percentOfSideReal:00.0}% of sidereal rate)";
+                lblPercentOfSiderealRate.Text = string.Format(Resources.SetupDialogForm_TextBox1_TextChanged___0_00_0___of_sidereal_rate_, percentOfSideReal);
                 _guideRateValid = true;
             }
             catch (Exception)
diff --git a/Meade.net/SharedResources.cs b/Meade.net/SharedResources.cs
index cff60d6..05bece9 100644
--- a/Meade.net/SharedResources.cs
+++ b/Meade.net/SharedResources.cs
@@ -18,6 +18,7 @@ using System;
 using System.Collections.Generic;
 using System.Globalization;
 using System.Windows.Forms;
+using ASCOM.Meade.net.Properties;
 using ASCOM.Utilities;
 
 namespace ASCOM.Meade.net
@@ -220,7 +221,7 @@ namespace ASCOM.Meade.net
             // or call a different dialog if connected
             if (Connections > 0)
             {
-                MessageBox.Show("Already connected, please disconnect before altering settings");
+                MessageBox.Show(Resources.SharedResources_SetupDialog_Already_connected__please_disconnect_before_altering_settings);
                 return;
             }