Astronomy/MeadeGeneric
1
0
Fork 0
Code Pull Requests Wiki Activity

Fixed issue with slew to RA/Dec not applying negative declinations properly.

Browse Source
This commit is contained in:
Colin Dawson
2019-07-07 14:52:06 +01:00
parent 621b7dc2da
commit 71bc7fd49a
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Meade.net.Telescope/Telescope.cs
+14 -2
View File
@@ -190,6 +190,9 @@ namespace ASCOM.Meade.net
case "mode": case "mode":
SharedResources.SendBlind(":EK9#"); SharedResources.SendBlind(":EK9#");
break; break;
case "longMode":
SharedResources.SendBlind(":EK11#");
break;
case "goto": case "goto":
SharedResources.SendBlind(":EK24#"); SharedResources.SendBlind(":EK24#");
break; break;
@@ -1448,16 +1451,20 @@ namespace ASCOM.Meade.net
{ {
case "0": case "0":
//We're slewing everything should be working just fine. //We're slewing everything should be working just fine.
tl.LogMessage("DoSlewAsync", "Slewing to target");
break; break;
case "1": case "1":
//Below Horizon //Below Horizon
string belowHorizonMessage = SharedResources.ReadTerminated(); string belowHorizonMessage = SharedResources.ReadTerminated();
tl.LogMessage("DoSlewAsync", $"Slew failed \"{belowHorizonMessage}\"");
throw new ASCOM.InvalidOperationException(belowHorizonMessage); throw new ASCOM.InvalidOperationException(belowHorizonMessage);
case "2": case "2":
//Below Horizon //Below Horizon
string belowMinimumElevationMessage = SharedResources.ReadTerminated(); string belowMinimumElevationMessage = SharedResources.ReadTerminated();
tl.LogMessage("DoSlewAsync", $"Slew failed \"{belowMinimumElevationMessage}\"");
throw new ASCOM.InvalidOperationException(belowMinimumElevationMessage); throw new ASCOM.InvalidOperationException(belowMinimumElevationMessage);
default: default:
tl.LogMessage("DoSlewAsync", $"Slew failed - unknown response \"{response}\"");
throw new ASCOM.DriverException("This error should not happen"); throw new ASCOM.DriverException("This error should not happen");
} }
@@ -1492,6 +1499,8 @@ namespace ASCOM.Meade.net
{ {
utilities.WaitForMilliseconds(200); //be responsive to AbortSlew(); utilities.WaitForMilliseconds(200); //be responsive to AbortSlew();
} }
tl.LogMessage("SlewToCoordinates", $"Slewing completed new coordinates Ra={RightAscension}, Dec={Declination}");
} }
public void SlewToCoordinatesAsync(double rightAscension, double declination) public void SlewToCoordinatesAsync(double rightAscension, double declination)
@@ -1631,9 +1640,12 @@ namespace ASCOM.Meade.net
CheckConnected("TargetDeclination Set"); CheckConnected("TargetDeclination Set");
var dms = utilities.DegreesToDMS(value, "*", ":", ":", 2); var dms = utilities.DegreesToDMS(value, "*", ":", ":", 2);
var s = value < 0 ? '-' : '+'; var s = value < 0 ? string.Empty : "+";
var result = SharedResources.SendChar($":Sd{s}{dms}#"); var command = $":Sd{s}{dms}#";
tl.LogMessage("TargetDeclination Set", $"{command}");
var result = SharedResources.SendChar(command);
//:SdsDD*MM# //:SdsDD*MM#
//Set target object declination to sDD*MM or sDD*MM:SS depending on the current precision setting //Set target object declination to sDD*MM or sDD*MM:SS depending on the current precision setting
//Returns: //Returns: