From 6dff32505e3d8ca4582e74defc30c108602d1ef1 Mon Sep 17 00:00:00 2001
From: Sebastian Godelet <sebastian.godelet@outlook.com>
Date: Wed, 23 Jun 2021 11:07:23 +1000
Subject: [PATCH] Clarify thread-safe value test intention

---
 Meade.net.UnitTests/ThreadSafeBoolTests.cs    |  6 +++---
 .../ThreadSafeDateTimeTests.cs                |  9 +++------
 Meade.net.UnitTests/ThreadSafeEnumTests.cs    | 19 +++++++------------
 .../ThreadSafeNullableDoubleTests.cs          |  6 +++---
 4 files changed, 16 insertions(+), 24 deletions(-)

diff --git a/Meade.net.UnitTests/ThreadSafeBoolTests.cs b/Meade.net.UnitTests/ThreadSafeBoolTests.cs
index a757fd8..adeee40 100644
--- a/Meade.net.UnitTests/ThreadSafeBoolTests.cs
+++ b/Meade.net.UnitTests/ThreadSafeBoolTests.cs
@@ -7,7 +7,7 @@ namespace Meade.net.UnitTests
     {
         [TestCase(false)]
         [TestCase(true)]
-        public void WhenConvertedValueIsSame(bool value)
+        public void When_Assigned_ThenValueIsSame(bool value)
         {
             // given
             ThreadSafeBool sut = value;
@@ -23,10 +23,10 @@ namespace Meade.net.UnitTests
         [TestCase(false, true)]
         [TestCase(true, false)]
         [TestCase(true, true)]
-        public void WhenSetValueIsChanged(bool value, bool setValue)
+        public void When_SetValue_ThenValueIsUpdated(bool initialValue, bool setValue)
         {
             // given
-            ThreadSafeBool sut = value;
+            ThreadSafeBool sut = initialValue;
 
             // when
             sut.Set(setValue);
diff --git a/Meade.net.UnitTests/ThreadSafeDateTimeTests.cs b/Meade.net.UnitTests/ThreadSafeDateTimeTests.cs
index 5fd619c..e20e46a 100644
--- a/Meade.net.UnitTests/ThreadSafeDateTimeTests.cs
+++ b/Meade.net.UnitTests/ThreadSafeDateTimeTests.cs
@@ -3,16 +3,13 @@ using NUnit.Framework;
 using System;
 using System.Collections.Generic;
 using System.Globalization;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace Meade.net.UnitTests
 {
     public class ThreadSafeDateTimeTests
     {
         [TestCaseSource(nameof(DateTimeSource))]
-        public void WhenConvertedValueIsSame(DateTime value)
+        public void When_Assigned_ThenValueIsSame(DateTime value)
         {
             // given
             ThreadSafeDateTime sut = value;
@@ -25,10 +22,10 @@ namespace Meade.net.UnitTests
         }
 
         [TestCaseSource(nameof(DateTimeSetSource))]
-        public void WhenSetValueIsChanged(DateTime value, DateTime setValue)
+        public void When_SetValue_ThenValueIsUpdated(DateTime initialValue, DateTime setValue)
         {
             // given
-            ThreadSafeDateTime sut = value;
+            ThreadSafeDateTime sut = initialValue;
 
             // when
             sut.Set(setValue);
diff --git a/Meade.net.UnitTests/ThreadSafeEnumTests.cs b/Meade.net.UnitTests/ThreadSafeEnumTests.cs
index 5157cd7..f542eed 100644
--- a/Meade.net.UnitTests/ThreadSafeEnumTests.cs
+++ b/Meade.net.UnitTests/ThreadSafeEnumTests.cs
@@ -1,11 +1,6 @@
 using ASCOM.DeviceInterface;
 using ASCOM.Meade.net;
 using NUnit.Framework;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace Meade.net.UnitTests
 {
@@ -14,7 +9,7 @@ namespace Meade.net.UnitTests
         [TestCase(PierSide.pierUnknown)]
         [TestCase(PierSide.pierEast)]
         [TestCase(PierSide.pierWest)]
-        public void WhenConvertedValueIsSame(PierSide value)
+        public void When_Assigned_ThenValueIsSame(PierSide value)
         {
             // given
             ThreadSafeEnum<PierSide> sut = value;
@@ -27,18 +22,18 @@ namespace Meade.net.UnitTests
         }
 
         [TestCase(PierSide.pierUnknown, PierSide.pierUnknown)]
-        [TestCase(PierSide.pierUnknown, PierSide.pierUnknown)]
-        [TestCase(PierSide.pierUnknown, PierSide.pierUnknown)]
+        [TestCase(PierSide.pierUnknown, PierSide.pierEast)]
+        [TestCase(PierSide.pierUnknown, PierSide.pierWest)]
         [TestCase(PierSide.pierEast, PierSide.pierUnknown)]
-        [TestCase(PierSide.pierEast, PierSide.pierWest)]
         [TestCase(PierSide.pierEast, PierSide.pierEast)]
+        [TestCase(PierSide.pierEast, PierSide.pierWest)]
         [TestCase(PierSide.pierWest, PierSide.pierUnknown)]
-        [TestCase(PierSide.pierWest, PierSide.pierWest)]
         [TestCase(PierSide.pierWest, PierSide.pierEast)]
-        public void WhenSetValueIsChanged(PierSide value, PierSide setValue)
+        [TestCase(PierSide.pierWest, PierSide.pierWest)]
+        public void When_SetValue_ThenValueIsUpdated(PierSide initialValue, PierSide setValue)
         {
             // given
-            ThreadSafeEnum<PierSide> sut = value;
+            ThreadSafeEnum<PierSide> sut = initialValue;
 
             // when
             sut.Set(setValue);
diff --git a/Meade.net.UnitTests/ThreadSafeNullableDoubleTests.cs b/Meade.net.UnitTests/ThreadSafeNullableDoubleTests.cs
index 3537f4e..ea7bd78 100644
--- a/Meade.net.UnitTests/ThreadSafeNullableDoubleTests.cs
+++ b/Meade.net.UnitTests/ThreadSafeNullableDoubleTests.cs
@@ -9,7 +9,7 @@ namespace Meade.net.UnitTests
         [TestCase(-12.34d)]
         [TestCase(0d)]
         [TestCase(null)]
-        public void WhenConvertedValueIsSame(double? value)
+        public void When_Assigned_ThenValueIsSame(double? value)
         {
             // given
             ThreadSafeNullableDouble sut = value;
@@ -29,10 +29,10 @@ namespace Meade.net.UnitTests
         [TestCase(-12.34d, null)]
         [TestCase(0d, null)]
         [TestCase(null, null)]
-        public void WhenSetValueIsChanged(double? value, double? setValue)
+        public void When_SetValue_ThenValueIsUpdated(double? initialValue, double? setValue)
         {
             // given
-            ThreadSafeNullableDouble sut = value;
+            ThreadSafeNullableDouble sut = initialValue;
 
             // when
             sut.Set(setValue);