Fixed the defect when one instance of the driver gets parked, the info is shared to the other instances.

Meade.net.Telescope.UnitTests/TelescopeUnitTests.cs

@@ -48,9 +48,15 @@ namespace Meade.net.Telescope.UnitTests
 
         private TestProperties _testProperties;
 
+        private bool _isParked;
+        private ParkedPosition _parkedPosition;
+
         [SetUp]
         public void Setup()
         {
+            _isParked = false;
+            _parkedPosition = null;
+
             _testProperties = new TestProperties();
 
             _profileProperties = new ProfileProperties
@@ -118,6 +124,14 @@ namespace Meade.net.Telescope.UnitTests
             _sharedResourcesWrapperMock.Setup(x => x.ProductName).Returns(() => productName);
             _sharedResourcesWrapperMock.Setup(x => x.FirmwareVersion).Returns(() => firmwareVersion);
 
+            _sharedResourcesWrapperMock.Setup(x => x.SetParked(It.IsAny<bool>(), It.IsAny<ParkedPosition>())).Callback<bool,ParkedPosition>((isParked, parkedPostion) => {
+                _isParked = isParked;
+                _parkedPosition = parkedPostion;
+            });
+
+            _sharedResourcesWrapperMock.SetupGet(x => x.IsParked).Returns(() => _isParked);
+            _sharedResourcesWrapperMock.SetupGet(x => x.ParkedPosition).Returns(() => _parkedPosition);
+
             _astroMathsMock
                 .Setup(x => x.ConvertHozToEq(It.IsAny<DateTime>(), It.IsAny<double>(), It.IsAny<double>(),
                     It.IsAny<HorizonCoordinates>())).Returns(() => new EquatorialCoordinates { Declination = _testProperties.declination, RightAscension = _testProperties.rightAscension });

Meade.net.Telescope/Meade.net.Telescope.csproj

@@ -127,7 +127,6 @@
     <Compile Include="ComparisonResult.cs" />
     <Compile Include="DoubleExtensions.cs" />
     <Compile Include="IClock.cs" />
-    <Compile Include="ParkedPosition.cs" />
     <Compile Include="StringExtensions.cs" />
     <Compile Include="Telescope.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />

Meade.net.Telescope/Telescope.cs

@@ -45,12 +45,15 @@ namespace ASCOM.Meade.net
         /// The DeviceID is used by ASCOM applications to load the driver at runtime.
         /// </summary>
         //internal static string driverID = "ASCOM.Meade.net.Telescope";
-        private static readonly string DriverId = Marshal.GenerateProgIdForType(MethodBase.GetCurrentMethod().DeclaringType ?? throw new System.InvalidOperationException());
+        private static readonly string DriverId =
+            Marshal.GenerateProgIdForType(MethodBase.GetCurrentMethod().DeclaringType ??
+                                          throw new System.InvalidOperationException());
 
         /// <summary>
         /// Private variable to hold an ASCOM Utilities object
         /// </summary>
         private readonly IUtil _utilities;
+
         private readonly IUtilExtra _utilitiesExtra;
 
         /// <summary>
@@ -74,8 +77,6 @@ namespace ASCOM.Meade.net
 
         private short _settleTime;
         
-        private ParkedPosition _parkedPosition;
-
         /// <summary>
         /// Initializes a new instance of the <see cref="Meade.net"/> class.
         /// Must be public for COM registration.
@@ -123,7 +124,9 @@ namespace ASCOM.Meade.net
             sb.AppendLine();
         }
 
-        public Telescope( IUtil util, IUtilExtra utilExtra, IAstroUtils astroUtilities, ISharedResourcesWrapper sharedResourcesWrapper, IAstroMaths astroMaths, IClock clock) : base(sharedResourcesWrapper)
+        public Telescope(IUtil util, IUtilExtra utilExtra, IAstroUtils astroUtilities,
+            ISharedResourcesWrapper sharedResourcesWrapper, IAstroMaths astroMaths, IClock clock) : base(
+            sharedResourcesWrapper)
         {
             _clock = clock;
             _utilities = util; //Initialise util object
@@ -282,6 +285,7 @@ namespace ASCOM.Meade.net
                                         $"Site {actionParameters} not allowed, must be between 1 and 4");
 
                             }
+
                             break;
                         case "getname":
                             switch (parames[1])
@@ -316,6 +320,7 @@ namespace ASCOM.Meade.net
                                         $"Site {actionParameters} not allowed, must be between 1 and 4");
 
                             }
+
                             break;
                         default:
                             throw new InvalidValueException(
@@ -398,7 +403,8 @@ namespace ASCOM.Meade.net
                         var connectionInfo = SharedResourcesWrapper.Connect("Serial", DriverId, Tl);
                         try
                         {
-                            LogMessage("Connected Set", $"Connected to port {ComPort}. Product: {SharedResourcesWrapper.ProductName} Version:{SharedResourcesWrapper.FirmwareVersion}");
+                            LogMessage("Connected Set",
+                                $"Connected to port {ComPort}. Product: {SharedResourcesWrapper.ProductName} Version:{SharedResourcesWrapper.FirmwareVersion}");
 
                             _userNewerPulseGuiding = IsNewPulseGuidingSupported();
                             _targetDeclination = InvalidParameter;
@@ -430,19 +436,23 @@ namespace ASCOM.Meade.net
                                 {
                                     if (SharedResourcesWrapper.ProductName == TelescopeList.LX200GPS)
                                     {
-                                        LogMessage("Connected Set", $"LX200GPS Detecting if daylight savings message on screen: {SendDateTime}");
+                                        LogMessage("Connected Set",
+                                            $"LX200GPS Detecting if daylight savings message on screen: {SendDateTime}");
                                         var displayText = Action("Handbox", "readdisplay");
                                         LogMessage("Connected Set", $"Current Handset display: {displayText}");
                                         if (displayText.Contains("Daylight"))
                                         {
-                                            LogMessage("Connected Set", $"LX200GPS Setting Date time and bypassing settings screens: {SendDateTime}");
+                                            LogMessage("Connected Set",
+                                                $"LX200GPS Setting Date time and bypassing settings screens: {SendDateTime}");
                                             BypassHandboxEntryForAutostarII();
                                         }
                                         else
                                         {
-                                            LogMessage("Connected Set", $"LX200GPS Sending current date and time: {SendDateTime}");
+                                            LogMessage("Connected Set",
+                                                $"LX200GPS Sending current date and time: {SendDateTime}");
                                             SendCurrentDateTime("Connect");
-                                            LogMessage("Connected Set", $"LX200GPS Attempting manual bypass of prompts: {SendDateTime}");
+                                            LogMessage("Connected Set",
+                                                $"LX200GPS Attempting manual bypass of prompts: {SendDateTime}");
                                             ApplySkipAutoStarPrompts("Connect");
                                         }
 
@@ -457,11 +467,13 @@ namespace ASCOM.Meade.net
                             }
                             else
                             {
-                                LogMessage("Connected Set", $"Skipping first connection telescope adjustments (current connections: {connectionInfo.SameDevice})");
+                                LogMessage("Connected Set",
+                                    $"Skipping first connection telescope adjustments (current connections: {connectionInfo.SameDevice})");
                             }
 
                             var raAndDec = GetTelescopeRaAndDec();
-                            LogMessage("Connected Set", $"Connected OK.  Current RA = {_utilitiesExtra.HoursToHMS(raAndDec.RightAscension)} Dec = {_utilitiesExtra.DegreesToDMS(raAndDec.Declination)}");
+                            LogMessage("Connected Set",
+                                $"Connected OK.  Current RA = {_utilitiesExtra.HoursToHMS(raAndDec.RightAscension)} Dec = {_utilitiesExtra.DegreesToDMS(raAndDec.Declination)}");
                         }
                         catch (Exception)
                         {
@@ -573,6 +585,7 @@ namespace ASCOM.Meade.net
             {
                 return false;
             }
+
             return true;
         }
 
@@ -582,6 +595,7 @@ namespace ASCOM.Meade.net
             {
                 return true;
             }
+
             return false;
         }
 
@@ -807,7 +821,8 @@ namespace ASCOM.Meade.net
                     //1 - Valid
                     break;
                 default:
-                    throw new ArgumentOutOfRangeException(nameof(site), site, Resources.Telescope_GetSiteName_Site_out_of_range);
+                    throw new ArgumentOutOfRangeException(nameof(site), site,
+                        Resources.Telescope_GetSiteName_Site_out_of_range);
             }
 
             var result = SharedResourcesWrapper.SendChar(command);
@@ -844,7 +859,8 @@ namespace ASCOM.Meade.net
                 //Returns: <string>#
                 //A ‘#’ terminated string with the name of the requested site.
                 default:
-                    throw new ArgumentOutOfRangeException(nameof(site), site, Resources.Telescope_GetSiteName_Site_out_of_range);
+                    throw new ArgumentOutOfRangeException(nameof(site), site,
+                        Resources.Telescope_GetSiteName_Site_out_of_range);
             }
         }
 
@@ -994,6 +1010,8 @@ namespace ASCOM.Meade.net
                 {
                     try
                     {
+                        CheckParked();
+
                         //firmware bug in 44Eg, :GA# is returning the dec, not the altitude!
                         var result = SharedResourcesWrapper.SendString("GA");
                         //:GA# Get Telescope Altitude
@@ -1006,13 +1024,11 @@ namespace ASCOM.Meade.net
                     }
                     catch (ParkedException)
                     {
-                        switch (ParkedBehaviour)
+                        var parkedPosition = SharedResourcesWrapper.ParkedPosition;
-                        {
+                        if (parkedPosition != null)
-                            case ParkedBehaviour.NoCoordinates:
+                            return parkedPosition.Altitude;
+
                         throw;
-                            default:
-                                return _parkedPosition.Altitude;
-                        }
                     }
                 }
 
@@ -1032,9 +1048,11 @@ namespace ASCOM.Meade.net
                 EquatorialCoordinates = GetTelescopeRaAndDec()
             });
 
-            double hourAngle = _astroMaths.RightAscensionToHourAngle(altitudeData.UtcDateTime, altitudeData.SiteLongitude,
+            double hourAngle = _astroMaths.RightAscensionToHourAngle(altitudeData.UtcDateTime,
+                altitudeData.SiteLongitude,
                 altitudeData.EquatorialCoordinates.RightAscension);
-            var altAz = _astroMaths.ConvertEqToHoz(hourAngle, altitudeData.SiteLatitude, altitudeData.EquatorialCoordinates);
+            var altAz = _astroMaths.ConvertEqToHoz(hourAngle, altitudeData.SiteLatitude,
+                altitudeData.EquatorialCoordinates);
             return altAz;
         }
 
@@ -1074,16 +1092,14 @@ namespace ASCOM.Meade.net
             }
         }
         
-        private bool _atPark;
-
         public bool AtPark
         {
             get
             {
-                LogMessage("AtPark", "Get - " + _atPark);
+                var atPark = SharedResourcesWrapper.IsParked;
-                return _atPark;
+                LogMessage("AtPark", "Get - " + atPark);
+                return atPark;
             }
-            private set => _atPark = value;
         }
 
         public IAxisRates AxisRates(TelescopeAxes axis)
@@ -1102,6 +1118,8 @@ namespace ASCOM.Meade.net
                 {
                     try
                     {
+                        CheckParked();
+
                         var result = SharedResourcesWrapper.SendString("GZ");
                         //:GZ# Get telescope azimuth
                         //Returns: DDD*MM#T or DDD*MM’SS#
@@ -1114,13 +1132,11 @@ namespace ASCOM.Meade.net
                     }
                     catch (ParkedException)
                     {
-                        switch (ParkedBehaviour)
+                        var parkedPosition = SharedResourcesWrapper.ParkedPosition;
-                        {
+                        if (parkedPosition != null)
-                            case ParkedBehaviour.NoCoordinates:
+                            return parkedPosition.Azimuth;
+
                         throw;
-                            default:
-                                return _parkedPosition.Azimuth;
-                        }
                     }
                 }
 
@@ -1317,13 +1333,11 @@ namespace ASCOM.Meade.net
                 }
                 catch (ParkedException)
                 {
-                    switch (ParkedBehaviour)
+                    var parkedPosition = SharedResourcesWrapper.ParkedPosition;
-                    {
+                    if (parkedPosition != null)
-                        case ParkedBehaviour.NoCoordinates:
+                        return parkedPosition.Declination;
+
                     throw;
-                        default:
-                            return _parkedPosition.Declination;
-                    }
                 }
             }
         }
@@ -1585,10 +1599,11 @@ namespace ASCOM.Meade.net
             if (AtPark)
                 return;
 
+            ParkedPosition parkedPosition;
             switch (ParkedBehaviour)
             {
                 case ParkedBehaviour.LastGoodPosition:
-                    _parkedPosition = new ParkedPosition
+                    parkedPosition = new ParkedPosition
                     {
                         Altitude = Altitude,
                         Azimuth = Azimuth,
@@ -1602,7 +1617,7 @@ namespace ASCOM.Meade.net
                     var longitude = SiteLongitude;
                     var raDec = _astroMaths.ConvertHozToEq(utcDateTime, latitude, longitude, ParkedAltAz);
 
-                    _parkedPosition = new ParkedPosition
+                    parkedPosition = new ParkedPosition
                     {
                         Altitude = ParkedAltAz.Altitude,
                         Azimuth = ParkedAltAz.Azimuth,
@@ -1610,12 +1625,13 @@ namespace ASCOM.Meade.net
                         Declination = raDec.Declination
                     };
                     break;
+                default:
+                    parkedPosition = null;
+                    break;
             }
 
             //Setting park to true before sending the park command as the Autostar and Audiostar stop serial communications once the park command has been issued.
-            AtPark = true;
+            SharedResourcesWrapper.SetParked(true, parkedPosition);
-
-
             SharedResourcesWrapper.SendBlind("hP");
             //:hP# Autostar, Autostar II and LX 16”Slew to Park Position
             //Returns: Nothing
@@ -1764,13 +1780,11 @@ namespace ASCOM.Meade.net
                 }
                 catch (ParkedException)
                 {
-                    switch (ParkedBehaviour)
+                    var parkedPosition = SharedResourcesWrapper.ParkedPosition;
-                    {
+                    if (parkedPosition != null)
-                        case ParkedBehaviour.NoCoordinates:
+                        return parkedPosition.RightAscension;
+
                         throw;
-                        default:
-                            return _parkedPosition.RightAscension;
-                    }
                 }
                 
             }
@@ -2698,7 +2712,7 @@ namespace ASCOM.Meade.net
 
             BypassHandboxEntryForAutostarII();
 
-            AtPark = false;
+            SharedResourcesWrapper.SetParked(false, null);
         }
 
         private bool BypassHandboxEntryForAutostarII()

Meade.net/Meade.net.csproj

@@ -141,6 +141,7 @@
     <Compile Include="LocalServer.cs" />
     <Compile Include="MeadeTelescopeBase.cs" />
     <Compile Include="ParkedBehaviour.cs" />
+    <Compile Include="ParkedPosition.cs" />
     <Compile Include="ProfileFactory.cs" />
     <Compile Include="ProfileProperties.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />

Meade.net/SharedResources.cs

@@ -493,5 +493,15 @@ namespace ASCOM.Meade.net
                 Count = 0;
             }
         }
+        
+        public static void SetParked(bool atPark, ParkedPosition parkedPosition)
+        {
+            IsParked = atPark;
+            ParkedPosition = parkedPosition;
+        }
+
+        public static bool IsParked { get; private set; }
+
+        public static ParkedPosition ParkedPosition { get; private set; }
     }
 }

Meade.net/Wrapper/SharedResourcesWrapper.cs

@@ -27,6 +27,10 @@ namespace ASCOM.Meade.net.Wrapper
         void SetupDialog();
         void WriteProfile(ProfileProperties profileProperties);
         void ReadCharacters(int throwAwayCharacters);
+
+        void SetParked(bool atPark, ParkedPosition parkedPosition);
+        bool IsParked { get; }
+        ParkedPosition ParkedPosition { get; }
     }
 
     public class SharedResourcesWrapper : ISharedResourcesWrapper
@@ -99,5 +103,14 @@ namespace ASCOM.Meade.net.Wrapper
         {
             SharedResources.WriteProfile(profileProperties);
         }
+
+        public void SetParked(bool atPark, ParkedPosition parkedPosition)
+        {
+            SharedResources.SetParked(atPark, parkedPosition);
+        }
+
+        public bool IsParked => SharedResources.IsParked;
+
+        public ParkedPosition ParkedPosition => SharedResources.ParkedPosition;
     }
 }