Merged in develop (pull request #4)

Develop

* Removed unwanted files

* Adding git ignore file

* Started working on getting the basic communications with the scope working.
    Working on routines to get and set the date and time in the handbox.

* Switched the serial port over to using the .net frameworks serial port.
    Extracted the serial port into it's own class and created a simpler command processing mechanism.

* Implemented AbortSlew and did some code tidy up.

* Forced all code to 64-bit only, will make this 32/64 bit before release.
    Fixed issue in the SerialProcessor when setting the time, makes sure that there's no chance of thread stealing when pulling out the junk messages
    Added ConformanceResult.txt to show the progress of the driver development

* Added code for the site latitude
    and started work on the longitude.

* Added unit tests for reading and writing the utcDate.
    Fixed a couple of defects in the code that was setting the utcDate.

* Corrected Longitude value range

* Added support for UTC offset.

* Pulse guiding support added

* Added SiteLatitude unit tests

* Added unit tests for SiteLongitude

* Added unit tests for the new Pulse guide implementation.

* Added support for AlignmentMode

* Added support for AtPark and Park

* Added support for parking the scope
    Added support for reading the scope Azimuth

* Added support for reading Declination

* Added 5 second timeout for the serial port.
    Fixed problem with the GW command not working on the Autostar 497.

* Fixed broken unit test

* Added support for altitude

* Tidying up resharper warinings

* Implemented RightAscension
    TargetRightAscension
    TargetDec
    SlewToCoord
    and SlewToCoordAsync

* Sorted out the target RA and Dec exceptions to be compliant with ascom.

* Implemented SlewToAltAz and SlewToAltAzAsync

* Implemented SyncToTarget functionality

* Implemented slew to target

* Added support for MoveAxis

* Added support for tracking rate

* Added IFocuserV3 to the driver and made sure that it's registered for ASCOM as a focuser as well.

* Fixed issue with Target RA and Dec loosing precision

* Telescope driver now passes the Ascom conformance.

* Upgraded driver version to 0.1

* Added explicit locks around all sequences of commands.

* Basic implementation of the IFocusserV3

* Focuser passes validation, this makes the code V0.2

Approved-by: Colin Dawson <me@cjdawson.com>

ASCOM.MeadeAutostar497.Focuser.Validation.txt

@@ -0,0 +1,68 @@
+Conform Report Hash (V1): 55AB333E4394ADF3F35929567EAB46A092F3574DF38E1F00BF586967B7EE826AA2D92647409F699E62954B07AF3389CEA7DB7FAAFFE04E05BE358A744E95A624
+
+ 
+ConformanceCheck ASCOM Device Conformance Checker Version 6.4.63.0, Build time: 18/12/2018 08:58:34
+ConformanceCheck Running on: ASCOM Platform 6.4 SP1 6.4.1.2695
+ 
+ConformanceCheck Driver ProgID: ASCOM.MeadeAutostar497.Telescope
+ 
+Error handling 
+Error number for "Not Implemented" is: 80040400
+Error number for "Invalid Value 1" is: 80040404
+Error number for "Value Not Set 1" is: 80040402
+Error number for "Value Not Set 2" is: 80040403
+Error messages will not be interpreted to infer state.
+ 
+00:21:34.375 Driver Access Checks              OK       
+00:21:35.008 AccessChecks                      OK       Successfully created driver using late binding
+00:21:35.253 AccessChecks                      OK       Successfully connected using late binding
+00:21:35.257 AccessChecks                      INFO     The driver is a .NET object
+00:21:35.260 AccessChecks                      INFO     The AssemblyQualifiedName is: ASCOM.MeadeAutostar497.Telescope, ASCOM.MeadeAutostar497.Telescope, Version=
+00:21:35.265 AccessChecks                      INFO     The driver implements interface: ASCOM.DeviceInterface.ITelescopeV3
+00:21:35.269 AccessChecks                      INFO     The driver implements interface: ASCOM.DeviceInterface.IFocuserV3
+00:21:35.992 AccessChecks                      INFO     Device does not expose IFocuser interface
+00:21:36.147 AccessChecks                      INFO     Device does not expose IFocuserV2 interface
+00:21:36.479 AccessChecks                      INFO     Device exposes IFocuserV3 interface
+00:21:36.692 AccessChecks                      OK       Successfully created driver using driver access toolkit
+00:21:36.895 AccessChecks                      OK       Successfully connected using driver access toolkit
+00:21:36.958 AccessChecks                      OK       Successfully disconnected using driver access toolkit
+ 
+Conform is using ASCOM.DriverAccess.Focuser to get a Focuser object
+00:21:37.078 ConformanceCheck                  OK       Driver instance created successfully
+00:21:37.311 ConformanceCheck                  OK       Connected OK
+ 
+Common Driver Methods 
+00:21:37.348 InterfaceVersion                  OK       3
+00:21:37.374 Connected                         OK       True
+00:21:37.401 Description                       OK       Meade Autostar 497 .net
+00:21:37.428 DriverInfo                        OK       Information about the driver itself. Version: 0.2
+00:21:37.457 DriverVersion                     OK       0.2
+00:21:37.485 Name                              OK       Meade Autostar 497 .net
+00:21:37.511 CommandXXX                        INFO     Tests skipped
+00:21:37.515 Action                            INFO     Conform cannot test the Action method
+00:21:37.521 SupportedActions                  OK       Driver returned an empty action list
+ 
+Properties 
+00:21:37.626 Absolute                          OK       False
+00:21:37.631 IsMoving                          OK       False
+00:21:37.637 MaxStep                           OK       7000
+00:21:37.642 MaxIncrement                      OK       7000
+00:21:37.820 Position                          OK       Position must not be implemented for a relative focuser and a PropertyNotImplementedException exception was generated as expected
+00:21:37.988 StepSize                          OK       Optional member threw a PropertyNotImplementedException exception.
+00:21:37.993 TempCompAvailable                 OK       False
+00:21:37.999 TempComp Read                     OK       False
+00:21:38.167 TempComp Write                    OK       Temperature compensation is not available and a PropertyNotImplementedException exception was generated as expected
+00:21:38.504 Temperature                       OK       Optional member threw a PropertyNotImplementedException exception.
+ 
+Methods 
+00:21:38.544 Halt                              OK       Focuser halted OK
+00:21:38.552 Move - TempComp False                      Moving by: 700
+00:21:39.264 Move - TempComp False                      Asynchronous move found
+00:21:39.270 Move - TempComp False             OK       Relative move OK
+00:21:39.278 Move - TempComp False             INFO     Returning to original position: 0
+ 
+Conformance test complete 
+ 
+No errors, warnings or issues found: your driver passes ASCOM validation!! 
+ 
+Driver Hash Value: DBF36156F87DA91F130E0AABEFE80B250D62C2DB689AD8B44243AE0D9322245CF15AAE2E663962402E87B6B1A15440A6DDB46562EFB9527E3596096319C2AC85

MeadeAutostar497/AscomClasses/Telescope.cs

@@ -949,22 +949,22 @@ namespace ASCOM.MeadeAutostar497
 
         #region IFocuser Implementation
 
-        private int focuserPosition = 0; // Class level variable to hold the current focuser position
-        private const int focuserSteps = 10000;
+        //private int focuserPosition = 0; // Class level variable to hold the current focuser position
+        //private const int focuserSteps = 10000;
 
         public bool Absolute
         {
             get
             {
-                tl.LogMessage("Absolute Get", true.ToString());
-                return true; // This is an absolute focuser
+                tl.LogMessage("Absolute Get", false.ToString());
+                return false; // This is an absolute focuser
             }
         }
 
         public void Halt()
         {
-            tl.LogMessage("Halt", "Not implemented");
-            throw new ASCOM.MethodNotImplementedException("Halt");
+            tl.LogMessage("Halt", "Halting");
+            _telescopeController.FocuserHalt();
         }
 
         public bool IsMoving
@@ -994,8 +994,9 @@ namespace ASCOM.MeadeAutostar497
         {
             get
             {
-                tl.LogMessage("MaxIncrement Get", focuserSteps.ToString());
-                return focuserSteps; // Maximum change in one move
+                var maxIncrement = _telescopeController.FocuserMaxIncrement;
+                tl.LogMessage("MaxIncrement Get", maxIncrement.ToString());
+                return maxIncrement; // Maximum change in one move
             }
         }
 
@@ -1003,22 +1004,25 @@ namespace ASCOM.MeadeAutostar497
         {
             get
             {
-                tl.LogMessage("MaxStep Get", focuserSteps.ToString());
-                return focuserSteps; // Maximum extent of the focuser, so position range is 0 to 10,000
+                var maxStep = _telescopeController.FocuserMaxStep;
+                tl.LogMessage("MaxStep Get", maxStep.ToString());
+                return maxStep;
             }
         }
 
         public void Move(int Position)
         {
             tl.LogMessage("Move", Position.ToString());
-            focuserPosition = Position; // Set the focuser position
+            _telescopeController.FocuserMove(Position);
+            //focuserPosition = Position; // Set the focuser position
         }
 
         public int Position
         {
             get
             {
-                return focuserPosition; // Return the focuser position
+                throw new ASCOM.PropertyNotImplementedException("Position", false);
+                //return focuserPosition; // Return the focuser position
             }
         }
 

MeadeAutostar497/Controller/FirmwareVersion.cs

@@ -0,0 +1,34 @@
+namespace ASCOM.MeadeAutostar497.Controller
+{
+    enum FirmwareVersion
+    {
+        autostar497_30eb,
+        autostar497_30ed,
+        autostar497_30ee,
+        autostar497_31ee,
+        autostar497_32ea,
+        //PEC added for Polar mounted scopes
+
+        autostar497_32ee,
+        autostar497_32eh,
+        //Some serial strings fixed.
+
+        autostar497_32ei,
+        autostar497_33ef,
+        //Some serial strings fixed.
+
+        autostar497_33el,
+        autostar497_40eb,
+        autostar497_40ee,
+        autostar497_40ef,
+        autostar497_41ec,
+        autostar497_42ed,
+        //Get serial command for daylight savings (:GH# returns 0 for disabled 1 for enabled)
+        //Set serial command for daylight savings (:SH0# disables, :SH1# enables)
+
+        autostar497_43ea,
+        autostar497_43ed,
+        autostar497_43eg
+        //Added :GW#, :AL#, :AA#, & :AP#
+    }
+}

MeadeAutostar497/Controller/ITelescopeController.cs

@@ -21,6 +21,8 @@ namespace ASCOM.MeadeAutostar497.Controller
         double TargetRightAscension { get; set; }
         double TargetDeclination { get; set; }
         DriveRates TrackingRate { get; }
+        int FocuserMaxIncrement { get; set; }
+        int FocuserMaxStep { get; set; }
         void AbortSlew();
         void PulseGuide(GuideDirections direction, int duration);
         void Park();
@@ -32,5 +34,7 @@ namespace ASCOM.MeadeAutostar497.Controller
         void SlewToTarget();
         void SlewToTargetAsync();
         void MoveAxis(TelescopeAxes axis, double rate);
+        void FocuserHalt();
+        void FocuserMove(int position);
     }
 }

MeadeAutostar497/Controller/TelescopeController.cs

@@ -97,6 +97,7 @@ namespace ASCOM.MeadeAutostar497.Controller
                         SerialPort.Open();
 
                         TestConnectionActive();
+                        SetFocuserSpeedFastest();
                     }
                     catch (Exception)
                     {
@@ -520,6 +521,10 @@ namespace ASCOM.MeadeAutostar497.Controller
             }
         }
 
+        public int FocuserMaxIncrement { get; set; } = 7000;
+
+        public int FocuserMaxStep { get; set; } = 7000;
+
         public double Altitude {
             get
             {
@@ -561,6 +566,9 @@ namespace ASCOM.MeadeAutostar497.Controller
                 Thread.Sleep(duration); //todo figure out if this is really needed
             }
             else
+            {
+                SerialPort.Lock();
+                try
                 {
                     _serialPort.Command(":RG#"); //Make sure we are at guide rate
                     _serialPort.Command($":M{d}#");
@@ -571,6 +579,11 @@ namespace ASCOM.MeadeAutostar497.Controller
                     Thread.Sleep(200);
                     _serialPort.Command($":Q{d}#");
                 }
+                finally
+                {
+                    SerialPort.Unlock();
+                }
+            }
         }
 
         public void Park()
@@ -593,12 +606,20 @@ namespace ASCOM.MeadeAutostar497.Controller
         }
 
         public void SlewToCoordinatesAsync(double rightAscension, double declination)
+        {
+            SerialPort.Lock();
+            try
             {
                 TargetRightAscension = rightAscension;
                 TargetDeclination = declination;
 
                 DoSlewAsync(true);
             }
+            finally
+            {
+                SerialPort.Unlock();
+            }
+        }
 
         public void SlewToAltAz(double azimuth, double altitude)
         {
@@ -662,12 +683,20 @@ namespace ASCOM.MeadeAutostar497.Controller
         }
 
         public void SlewToAltAzAsync(double azimuth, double altitude)
+        {
+            SerialPort.Lock();
+            try
             {
                 TargetAltitude = altitude;
                 TargetAzimuth = azimuth;
 
                 DoSlewAsync(false);
             }
+            finally
+            {
+                SerialPort.Unlock();
+            }
+        }
 
         public void SyncToTarget()
         {
@@ -706,7 +735,11 @@ namespace ASCOM.MeadeAutostar497.Controller
 
         private bool _movingPrimary;
         private bool _movingSecondary;
+
         public void MoveAxis(TelescopeAxes axis, double rate)
+        {
+            SerialPort.Lock();
+            try
             {
                 var absrate = Math.Abs(rate);
 
@@ -767,6 +800,7 @@ namespace ASCOM.MeadeAutostar497.Controller
                             //Returns: Nothing
                             _movingPrimary = true;
                         }
+
                         break;
                     case TelescopeAxes.axisSecondary:
                         if (rate == 0)
@@ -799,9 +833,92 @@ namespace ASCOM.MeadeAutostar497.Controller
                         throw new ASCOM.MethodNotImplementedException("Can not move this axis.");
                 }
             }
+            finally
+            {
+                SerialPort.Unlock();
+            }
+        }
+
+        public void FocuserHalt()
+        {
+            SerialPort.Command(":FQ#");
+            //:FQ# Halt Focuser Motion
+            //Returns: Nothing
+        }
+
+        public void FocuserMove(int newPosition)
+        {
+            //todo implement backlash compensation
+            //todo implement direction reverse
+            //todo implement dynamic braking
+
+            if (newPosition < -FocuserMaxIncrement || newPosition > FocuserMaxIncrement)
+            {
+                throw new ASCOM.InvalidValueException($"position out of range {-FocuserMaxIncrement} < {newPosition} < {FocuserMaxIncrement}");
+            }
+
+            if (newPosition == 0)
+                return;
+
+            if (newPosition > 0)
+            {
+                //desired move direction is out
+                MoveFocuser(true, Math.Abs(newPosition));
+            }
+            else
+            {
+                //desired move direction is in
+                MoveFocuser(false, Math.Abs(newPosition));
+            }
+        }
+
+        private void MoveFocuser(bool directionOut, int steps)
+        {
+            SerialPort.Command(directionOut ? ":F+#" : ":F-#");
+            //:F+# Start Focuser moving inward (toward objective)
+            //Returns: None
+
+            //:F-# Start Focuser moving outward (away from objective)
+            //Returns: None
+
+            Util.WaitForMilliseconds(steps);
+
+            FocuserHalt();
+        }
+
+        private void SetFocuserSpeedFastest()
+        {
+            SerialPort.Command(":FF#");
+            //:FF# Set Focus speed to fastest setting
+            //Returns: Nothing
+        }
+
+        private void SetFocuserSpeedSlowest()
+        {
+            SerialPort.Command(":FS#");
+            //:FS# Set Focus speed to slowest setting
+            //Returns: Nothing
+        }
+
+        private void SetFocuserSpeed( int speed)
+        {
+            if (speed < 1)
+                throw new ArgumentOutOfRangeException("speed is too low");
+
+            if (speed > 4)
+                throw new ArgumentOutOfRangeException("speed is too high");
+
+            SerialPort.Command($":F{speed}#");
+            //:F<n># Autostar, Autostar II – set focuser speed to <n> where <n> is an ASCII digit 1..4
+            //Returns: Nothing
+            //All others – Not Supported
+        }
 
         //todo remove the polar parameter and split method into two.
         private void DoSlewAsync( bool polar) 
+        {
+            SerialPort.Lock();
+            try
             {
                 switch (polar)
                 {
@@ -830,6 +947,7 @@ namespace ASCOM.MeadeAutostar497.Controller
                                 throw new ASCOM.DriverException("This error should not happen");
 
                         }
+
                         break;
                     case false:
                         var maResponse = SerialPort.CommandChar(":MA#");
@@ -843,9 +961,15 @@ namespace ASCOM.MeadeAutostar497.Controller
                         {
                             throw new ASCOM.InvalidOperationException("fault");
                         }
+
                         break;
                 }
             }
+            finally
+            {
+                SerialPort.Unlock();
+            }
+        }
 
         public bool UserNewerPulseGuiding { get; set; } = true; //todo make this a device setting
     }

MeadeAutostar497/MeadeAutostar497.csproj

@@ -89,6 +89,7 @@
   </ItemGroup>
   <ItemGroup>
     <Compile Include="AscomClasses\Telescope.cs" />
+    <Compile Include="Controller\FirmwareVersion.cs" />
     <Compile Include="Controller\ISerialProcessor.cs" />
     <Compile Include="Controller\ITelescopeController.cs" />
     <Compile Include="Controller\SerialProcessor.cs" />

MeadeAutostar497/Properties/AssemblyInfo.cs

@@ -35,5 +35,5 @@ using System.Runtime.InteropServices;
 // by using the '*' as shown below:
 //
 // TODO - Set your driver's version here
-[assembly: AssemblyVersion("0.0.0.0")]
-[assembly: AssemblyFileVersion("0.0.0.0")]
+[assembly: AssemblyVersion("0.2.0.0")]
+[assembly: AssemblyFileVersion("0.2.0.0")]